Upgrade gourmet to 0.15

[Tomas Cassidy]

Binary package hint: gourmet

Version 0.15 of Gourmet Recipe Manager was released on 23/08/2009. Debian and Ubuntu currently only have version 0.14.5-2 in their development releases (karmic and sid). Source files are available from http://sourceforge.net/projects/grecipe-manager/files/

[Steve McGrath (smcgrath23)]

I'm going to make an attempt at packaging the new version. No guarantees, I'm still learning.

[Jamie Strandboge (jdstrand)]

Steve, since it has been a while, I'm am going to do this. We need to get gourmet to work without forcing python2.5 anyway.

[Jamie Strandboge (jdstrand)]

Marking Critical since the package will likely get dropped otherwise (ie, Lucid won't have python2.5).

[Jamie Strandboge (jdstrand)]

I now have preliminary packages in my PPA (https://launchpad.net/~jdstrand/+archive/ppa/+packages). Can people try one of the following and report back?

Karmic: 0.15.1-0ubuntu1~jdstrand0.9.10.0
Lucid: 0.15.1-0ubuntu1~jdstrand1

Please be sure to backup ~/.gourmet to somewhere safe in case you want to go back to the earlier packages, since trying out 0.15.1 requires a database upgrade as of 0.14.7. Once these are known to work well, I can get it into Ubuntu and send this to Debian. Thanks!

[Tomas Cassidy (tomas-cassidy)]

Testing with 0.15.1-0ubuntu1~jdstrand0.9.10.0.

When I try to uncheck an active plugin, I get "An error occured deactivating plugin" in a error messagebox.
I didn't have any previous gourmet database, so I've only done basic UI testing. That's all I can find at the moment.
I tested with creating a sample recipe and it appeared to work fine, with exporting the shopping list, etc..

[Thomas M. Hinkle (thomas-hinkle)]

Was the unchecking-plugin error present for all plugins?

[Tomas Cassidy (tomas-cassidy)]

Yes. The error was present when I tried to uncheck multiple plugins. I didn't try with every single plugin.

[Tomas Cassidy (tomas-cassidy)]

I just tested on Lucid and the same error is occuring for all plugins.

[Thomas M. Hinkle (thomas-hinkle)]

Thanks for doing the test. I'm not reproducing with the latest devel branch (0.15.2). What version are you testing?

[Tomas Cassidy (tomas-cassidy)]

I'm testing with 0.15.1-0ubuntu1~jdstrand0.9.10.0 from the ppa at https://launchpad.net/~jdstrand/+archive/ppa/+packages

[Jamie Strandboge (jdstrand)]

0.15.1-0ubuntu1~jdstrand0.9.10.0 is built using gourmet-0.15.1.tar.gz from sourceforge:
$ md5sum ./gourmet-0.15.1.tar.gz
fb1b635e9db5f3adb0568b3c5f8f2c45 ./gourmet-0.15.1.tar.gz

[Jamie Strandboge (jdstrand)]

It may be worth noting that Ubuntu 9.10 (Karmic) and Ubuntu 10.04 (Lucid) both use python 2.6.4.

[Jamie Strandboge (jdstrand)]

If it helps, the buildlog for 9.10 can be seen here:
http://launchpadlibrarian.net/36748095/buildlog_ubuntu-karmic-i386.gourmet_0.15.1-0ubuntu1~jdstrand0.9.10.0_FULLYBUILT.txt.gz

[Jamie Strandboge (jdstrand)]

Thomas, fyi, the packages in my PPA are in preparation for getting 0.15 into the next Ubuntu release (Lucid). Lucid won't have python2.5, so it is imperative that we have a version of gourmet that works with python2.6.

[Jamie Strandboge (jdstrand)]

Thomas:

Here is the traceback:
$ gourmet
version older than 0.11.4 -- doing update
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 94, in toggled_cb
    self.do_change_plugin(plugin_set, state, ls)
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 129, in do_change_plugin
    self.loader.deactivate_plugin_set(plugin_set)
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 172, in deactivate_plugin_set
    if plugin.get_module():
UnboundLocalError: local variable 'plugin' referenced before assignment

I find it a little odd that it keeps giving me the 'version older than 0.11.4 -- doing update' message, since I have launched this several times already, but that is a separate issue.

[Jamie Strandboge (jdstrand)]

Also, if I disable an active plugin, get the error, then close gourmet, the plugin is disabled. Thomas, would it be possibly to provide a small patch to fix this issue? We can then get 0.15.2 in later.

[Thomas M. Hinkle (thomas-hinkle)]

James,

As we're working with the latest devel version, why not use 0.15.2 to start
with? I can't reproduce the issue with 0.15.2. Also, I'm developing on
Karmic with python2.6, so it should work.

0.15.2 also fixes a number of other important bugs, such as one with unicode
characters that garnered a fair number of reports.

Tom

On Tue, Dec 15, 2009 at 9:00 AM, Jamie Strandboge <email address hidden> wrote:

> Also, if I disable an active plugin, get the error, then close gourmet,
> the plugin is disabled. Thomas, would it be possibly to provide a small
> patch to fix this issue? We can then get 0.15.2 in later.
>
> --
> Upgrade gourmet to 0.15
> https://bugs.launchpad.net/bugs/431806
> You received this bug notification because you are subscribed to gourmet
> in ubuntu.
>

[Jamie Strandboge (jdstrand)]

Tom,

How stable is 0.15.2? When is it due to be released? I don't mind uploading a prerelease, but wouldn't want a prerelease to end up in Lucid, which will be an LTS.

Thanks!

[Thomas M. Hinkle (thomas-hinkle)]

Jamie,

Well, 0.15.2 is just as stable as any other release in the 0.15.x series,
probably a bit more so. The only versions that have ever been packaged for
ubuntu or debian have been the "unstable" versions. This being a one-man
project (essentially) we don't have the resources to adhere to Ubuntu's
timetable.

I'll let you know if a major unstable change comes out, but otherwise you'd
be safe to assume that the latest is the most stable, best bet we have.

The biggest change 0.15.2 introduces is a new printing architecture. This
gets us out of using the deprecated gnomeprint.

The dependencies should change in the following way:
- ReportLab should now be required (Gourmet will work without it, but won't
print, which most users would see as a pretty big problem).
- gnomeprint is no longer required.

Tom

On Tue, Dec 15, 2009 at 11:20 AM, Jamie Strandboge <email address hidden> wrote:

> Tom,
>
> How stable is 0.15.2? When is it due to be released? I don't mind
> uploading a prerelease, but wouldn't want a prerelease to end up in
> Lucid, which will be an LTS.
>
> Thanks!
>
> --
> Upgrade gourmet to 0.15
> https://bugs.launchpad.net/bugs/431806
> You received this bug notification because you are subscribed to gourmet
> in ubuntu.
>

[Jamie Strandboge (jdstrand)]

Tom,

I was in no way suggesting you adhere to Ubuntu's timetable, but rather trying to understand yours. I am a fan of using the 0.15 series since it is the stable release. I just don't know your development model. It sounds like 0.15.2 is a good plan-- I would prefer we had an official 0.15.2, not something between 0.15.1 and 0.15.2 (with potentially unfinished features), which is why I asked about when you would release.

[Jamie Strandboge (jdstrand)]

I see that sourceforge now has 0.15.2, so I can package that and put it in my ppa for people to try.

[Jamie Strandboge (jdstrand)]

Ok, the following have been uploaded to my PPA (https://launchpad.net/~jdstrand/+archive/ppa/+packages):
Lucid: 0.15.2-0ubuntu1~jdstrand1
Karmic: 0.15.2-0ubuntu1~jdstrand0.9.10.0

Preliminary testing shows that the plugin issue is resolved as well as my 'version older than 0.11.4 -- doing update' issue.

Tom, it seems I am missing a dependency on python-poppler:
WARNING: Plugin module import failed
PATH: ['/usr/bin', '/usr/lib/python2.6', '/usr/lib/python2.6/plat-linux2', '/usr/lib/python2.6/lib-tk', '/usr/lib/python2.6/lib-old', '/usr/lib/python2.6/lib-dynload', '/usr/lib/python2.6/dist-packages', '/usr/lib/python2.6/dist-packages/PIL', '/usr/lib/python2.6/dist-packages/gst-0.10', '/usr/lib/pymodules/python2.6', '/usr/lib/python2.6/dist-packages/gtk-2.0', '/usr/lib/pymodules/python2.6/gtk-2.0', '/usr/local/lib/python2.6/dist-packages', '/usr/share/gourmet', '/usr/share/gourmet/gourmet/plugins', '/usr/share/gourmet/gourmet/plugins/import_export', '/usr/share/gourmet/']
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 242, in get_module
    self._loaded = __import__(self.module)
  File "/usr/share/gourmet/gourmet/plugins/import_export/pdf_plugin/__init__.py", line 1, in <module>
    import pdf_exporter_plugin,print_plugin
  File "/usr/share/gourmet/gourmet/plugins/import_export/pdf_plugin/print_plugin.py", line 4, in <module>
    import poppler
ImportError: No module named poppler
WARNING: Failed to load plugin pdf_plugin
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 92, in load_active_plugins
    self.active_plugins.extend(self.available_plugin_sets[p].plugins)
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 255, in __getattr__
    if attr == 'plugins': return self.get_plugins()
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 261, in get_plugins
    return self.get_module().plugins
AttributeError: 'NoneType' object has no attribute 'plugins'

How important is this plugin? Ie, should I Depends on python-poppler, Recommends or merely Suggests. Thanks!

[Jamie Strandboge (jdstrand)]

Yes, installing python-poppler makes this issue go away.

[Tomas Cassidy (tomas-cassidy)]

Testing the activation/deactivation of plugins gave me the following results. Plugins with no problems are not listed.

Nutritional info (activating):
The popup for loading nutritional info hangs and this appears in the terminal output. After closing the popup, the plugin appears activated and cannot be deactivated.

Grabbing nutrition database!
WARNING: PLUGIN FAILED TO LOAD <nutritional_information.main_plugin.NutritionMainPlugin instance at 0x9e31b0c>
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_loader.py", line 314, in plugin_plugin
    plugin_instance.activate(self)
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/main_plugin.py", line 13, in activate
    nutritionGrabberGui.check_for_db(pluggable.rd)
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/nutritionGrabberGui.py", line 70, in check_for_db
    dgg.load_db()
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/nutritionGrabberGui.py", line 39, in load_db
    self.grab_data(datad)
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/databaseGrabber.py", line 97, in grab_data
    os.path.join(directory,self.ABBREV_FILE_NAME)))
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/databaseGrabber.py", line 64, in get_abbrev
    self.parse_abbrevfile(afi)
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/databaseGrabber.py", line 150, in parse_abbrevfile
    d = self.parse_line(l,NUTRITION_FIELDS)
  File "/usr/share/gourmet/gourmet/plugins/nutritional_information/databaseGrabber.py", line 120, in parse_line
    lname,sname,typ = field_defs[n]
IndexError: list index out of range

Plain Text Guided Import (deactivating):
popup is shown saying "Webpage import" plugin requires plain text guided import. Clicking "cancel" results in a popup "Error deactivating plugin" with the terminal output:
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 94, in toggled_cb
    self.do_change_plugin(plugin_set, state, ls)
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 120, in do_change_plugin
    custom_no=_('Keep plugin active')
  File "/usr/share/gourmet/gourmet/gtk_extras/dialog_extras.py", line 1201, in getBoolean
    raise UserCancelledError("getBoolean dialog cancelled!")
gourmet.gtk_extras.dialog_extras.UserCancelledError: getBoolean dialog cancelled!

When clicking "keep plugin active":
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 94, in toggled_cb
    self.do_change_plugin(plugin_set, state, ls)
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 127, in do_change_plugin
    raise "Cancelled"
TypeError: exceptions must be classes or instances, not str

When closing the popup (clicking 'x' button in corner):
Traceback (most recent call last):
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 94, in toggled_cb
    self.do_change_plugin(plugin_set, state, ls)
  File "/usr/share/gourmet/gourmet/plugin_gui.py", line 120, in do_change_plugin
    custom_no=_('Keep plugin active')
  File "/usr/share/gourmet/gourmet/gt...

[Tomas Cassidy (tomas-cassidy)]

I forgot to mention that the plugin testing was done on 0.15.2-0ubuntu1~jdstrand1 in lucid.

[Jamie Strandboge (jdstrand)]

Thomas,

FYI-- attached are some quilt patches addresses several of the bugs Tomas' saw. These will be a part of my next upload to Ubuntu.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gourmet - 0.15.2-0ubuntu1

---------------
gourmet (0.15.2-0ubuntu1) lucid; urgency=low

  * New upstream release (LP: #431806, Closes: #530841). Also fixes the
    following bugs:
    - LP: #315836
    - LP: #295982
    - LP: #316445 (the GUI has been changed so this no longer applies)
  * Drop forcing of python2.5
  * debian/control: Recommends python-gnome2-extras for printing
  * drop debian/patches/05-add_manpage.patch, which is now included upstream
  * Fix some lintian warnings:
    - add debian/README.source
    - debian/control: bump Standards-Version to 3.8.3
    - debian/compat: bump to 5
  * debian/control: Depends on python-poppler (needed for printing)
  * debian/patches/01_fix_raise_str.patch: don't raise str exception
    in src/lib/plugin_gui.py
  * debian/patches/02_fix_nutrition_index_out_of_range.patch: don't
    add entries beyond the width of the field in databaseGrabber.py
  * debian/patches/03_dont_remove_nonexistent_plugin.patch: don't
    remove an inactive plugin in plugin_loader.py and don't deactivate
    a plugin from a non-existent database
 -- Jamie Strandboge <email address hidden> Tue, 29 Dec 2009 09:12:49 -0600