FTBFS

[Miguel Ruiz]

Binary package hint: stone

During the building process of stone (http://launchpadlibrarian.net/29636965/buildlog_ubuntu-karmic-i386.stone_2.3.e-1_FAILEDTOBUILD.txt.gz) we get the following error:

[..]

stone.c: In function 'strnUser':
stone.c:4509: error: dereferencing pointer to incomplete type
stone.c:4524: error: dereferencing pointer to incomplete type
stone.c:4536: error: dereferencing pointer to incomplete type
stone.c:4551: error: dereferencing pointer to incomplete type
stone.c:4557: error: dereferencing pointer to incomplete type
stone.c: In function 'openconfig':
stone.c:8675: warning: ignoring return value of 'dup', declared with attribute warn_unused_result
stone.c: In function 'initialize':
stone.c:10125: warning: ignoring return value of 'getcwd', declared with attribute warn_unused_result
stone.c:10142: warning: ignoring return value of 'fchown', declared with attribute warn_unused_result
stone.c:10143: warning: ignoring return value of 'fchown', declared with attribute warn_unused_result
make[4]: *** [stone] Error 1
make[4]: Leaving directory `/build/buildd/stone-2.3.e'
make[3]: *** [linux] Error 2
make[3]: Leaving directory `/build/buildd/stone-2.3.e'
make[2]: *** [ssl_stone] Error 2
make[2]: Leaving directory `/build/buildd/stone-2.3.e'
make[1]: *** [linux-ssl] Error 2
make[1]: Leaving directory `/build/buildd/stone-2.3.e'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
******************************************************************************

[..]

[Miguel Ruiz (mruiz)]

The package was built without problems.

[StefanPotyra (sistpoty)]

Hi,

generally looks good, apart from adding a patch system (now there are files outside of debian in the .diff.gz and a patch system, which is suboptimal).

As a general rule of thumb, please don't add a patch system, if there isn't one already present. Can you respin the debdiff please?

Thanks,
    Stefan.

[Miguel Ruiz (mruiz)]

Hi Stefan,

I patched the package without patch system.

Talking about the extra modified files, I don't understant why they appear.

mruiz@karmic:~/bzr/stone$ zcat stone_2.3.e-1.diff.gz |diffstat
 debian/changelog | 83 +++++++++++++++++++++++++
 debian/compat | 1
 debian/control | 19 +++++
 debian/copyright | 50 +++++++++++++++
 debian/dirs | 1
 debian/docs | 2
 debian/postinst | 28 ++++++++
 debian/postrm | 18 +++++
 debian/rules | 70 +++++++++++++++++++++
 stone.1 | 178 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 stone.1.ja | 178 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 628 insertions(+)

Cheers!

[Miguel Ruiz (mruiz)]

The extra files (not modified by myself) are:

 debian/compat | 1
 debian/copyright | 50 +++++++++++++++
 debian/dirs | 1
 debian/docs | 2
 debian/postinst | 28 ++++++++
 debian/postrm | 18 +++++
 stone.1 | 178 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 stone.1.ja | 178 +++++++++++++++++++++++++++++++++++++++++++++++++++++++

[StefanPotyra (sistpoty)]

Hi,

almost good: Now that you don't have a patch system, you also don't need to change debian/rules. Do you want to respin again? (I could also drop that parts before uploading, but since I won't come around to it until this evening, maybe you can provide a debdiff in the meantime ;)).

In regards to the files in .diff.gz: Obviously the DD added the manpages there, which is an indication that the DD doesn't want to use a patch system, hope that makes it clear ;).

Cheers,
   Stefan.

[Miguel Ruiz (mruiz)]

Stefan,

If I don't modify debian/rules, then how should I apply the patch during the building process ?

I followed the information from https://wiki.ubuntu.com/PackagingGuide/Complete#Patching%20Without%20a%20Patch%20System to patch this package.

Greetings and thanks for your review!

[StefanPotyra (sistpoty)]

Hi Miguel,

Am Friday 18 September 2009 19:48:31 schrieb Miguel Ruiz:
> Stefan,
>
> If I don't modify debian/rules, then how should I apply the patch during
> the building process ?
>
> I followed the information from
> https://wiki.ubuntu.com/PackagingGuide/Complete#Patching%20Without%20a%20Pa
>tch%20System to patch this package.

ah, sorry for the confusion.
What I meant when I wrote to not use a patch system is, that you simply apply
the fix straight to the Makefile so that it will end up *directly* in
the .diff.gz.

Cheers,
    Stefan.

[StefanPotyra (sistpoty)]

Hi,

that's what I mean. I'll upload that, and hope you're ok with my changes ;)

Thanks,
    Stefan.

[Launchpad Janitor (janitor)]

This bug was fixed in the package stone - 2.3.e-1ubuntu1

---------------
stone (2.3.e-1ubuntu1) karmic; urgency=low

  * Makefile: Added -D_GNU_SOURCE option to compile.
    Taken from Debian BTS and added to fix FTBFS. (LP: #431060)

 -- Miguel Ruiz <email address hidden> Thu, 17 Sep 2009 17:54:21 -0400