Add an option to chose the favourite filename for local cover fetching

[Steve Dodier-Lazaro]

Exaile 0.3.0.x

If the favourite search place for covers is "local", it makes sense to let users select a favourite file name (or list of file names) for their covers, as in Exaile 0.2.x, since many old users already have their covers named that way.

Another interesting option would be to allow saving remotely fetched covers under that favourite file name specified by the user.

[Ubuntuxer (johannes-schw)]

Hi, I wrote a small patch, so you can select your favourite locale cover file name.

[reacocard (reacocard)]

a few things that should changed in the patch:
- the setting is only loaded once, when the covers system is initialized. you should just re-read it from settings in find_covers and use preferred_names for the default in the call.
- this method doesn't allow for multiple file names to be chosen. many users will have covers with different names (cover, album...) so we need to support multiple choices, just as 0.2.14 did.
- "Favorite filename" is not very descriptive, perhaps something like "Preferred cover filename" would be clearer.

other than that, looks good

[Ubuntuxer (johannes-schw)]

thanks for your advices

Does it make sense to allow multiple file names? You have to evulate the file names and Exaile finds every image in the music directory anyway.

[Ubuntuxer (johannes-schw)]

thanks for your advices

Does it make sense to allow multiple file names? You have to evulate the file names and Exaile finds every image in the music directory anyway.

[Steve Dodier-Lazaro (sidi)]

It can make sense to want to use folder.png when available, and to fallback
to another file format when not. You can just let the user specify a simple
list of filenames, space separated, and go through these in the order
they've been specified. For instance:

cover.svg "other cover.png" "crappy cover.jpg"

would be a valid list.

[reacocard (reacocard)]

Steve is precisely correct - allowing multiple is to allow people to fall back to a second (or third, fourth...) preferred name if their collection contains more than one convention for names. IIRC 0.2.14 used a comma-separated list for that, eg. "cover, album, coverart"

[Ubuntuxer (johannes-schw)]

I have thought about how to sort the covers for half an hour, without making it extremely complicated, but I failed.

[reacocard (reacocard)]

Heh, yeah the sorting isn't too easy to do simply. I've attached what I came up with, which isn't too bad.

[Ubuntuxer (johannes-schw)]

I've tested your patch and it works perfectly well. Despite I still think there is no really need for it.

[Mathias Brodala (mathbr)]

Fixed with r3988.