Trying to add an email that's already registered as a SSO account but not a person, oopses

Bug #423447 reported by Ursula Junque
54
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
j.c.sackett

Bug Description

As seen on OOPS-1341F2700:

  AttributeError: 'NoneType' object has no attribute 'name'

It seems the problem happens when you try to +editemails and the email address you try to add is already associated with a SSO account, which means it doesn't have one associated person.

Gary Poster (gary)
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Guilherme Salgado (salgado)
Revision history for this message
Guilherme Salgado (salgado) wrote :

This one is slightly tricky because we'd need to explain to the user that they've got a Launchpad account and an SSO one, and in order to merge them they'd have to "upgrade" that SSO one into a Launchpad one (by logging into LP using the SSO credentials) and then merging the two. That's far from ideal, so we might want to make it possible to merge an SSO account into a LP one before we fix this.

Revision history for this message
Guilherme Salgado (salgado) wrote :

This one will become a non-issue once we stop sharing the EmailAddress table with SSO, which will happen soon

Changed in launchpad-foundations:
assignee: Guilherme Salgado (salgado) → nobody
importance: High → Undecided
status: Triaged → Won't Fix
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Even though we don't share the EmailAddress table with SSO anymore, we still have EmailAddress only associated to an OpenID account. Both for legacy reasons and because of ShipIt (which will create Account/EmailAddress pairs, but not Person.)

Changed in launchpad-foundations:
status: Won't Fix → Triaged
Gary Poster (gary)
tags: added: openid
Gary Poster (gary)
Changed in launchpad-foundations:
importance: Undecided → High
Revision history for this message
Gary Poster (gary) wrote :

After Stuart's work this just needs to have extra logic when you claim email addresses to handle the situation.

Changed in launchpad:
importance: High → Critical
Revision history for this message
Curtis Hovey (sinzui) wrote :

jcsackett fixed this in September 2009 when driving down registry oopses. in the same method.

Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.