Fix all occurrences of "Results 0-10"

Bug #418621 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Balazs Ree

Bug Description

In some places we say "Page 1 of 3". For example, on the OVERVIEW of a community, in the listing for recent items. I believe this is a table that isn't a GridTable.

In places where we *do* use GridTable, we use a different naming scheme. One that says "Results", and starts at number 0.

Try to make the GridTable match up with ZPT-driven display. Either make both say Results or both say Pages. More important, don't start numbering at zero.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Balazs, any comments on this?

Changed in karl3:
milestone: m29 → m30
Revision history for this message
Balazs Ree (ree) wrote :

No problem, I'll make the status in widget match up the static grid.

Balazs Ree (ree)
Changed in karl3:
status: New → In Progress
Revision history for this message
Balazs Ree (ree) wrote :

First I thought of matching the static-grid to the js-grid but then I changed my mind to the other way.

So far, I touched the js-grid only, fixed the zero at the beginning. We have the following (corrected) numbering now:

Result 1-10 of 14
Result 11-14 of 14

or even:

Result 1 of 1

I believe it is better to follow this output from the ZPT as well, because, we already see the pages in the right of the same footer, and showing the same info textually is superficial. However, writing Results shows the total number of records, which is more information.

Unless there are objections, I will change the static grid to match the above output as well.

Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 418621] Re: Fix all occurrences of "Results 0-10"

On Sep 3, 2009, at 3:25 PM, Balazs Ree wrote:

> First I thought of matching the static-grid to the js-grid but then I
> changed my mind to the other way.
>
> So far, I touched the js-grid only, fixed the zero at the beginning.
> We
> have the following (corrected) numbering now:
>
> Result 1-10 of 14
> Result 11-14 of 14
>
> or even:
>
> Result 1 of 1
>
> I believe it is better to follow this output from the ZPT as well,
> because, we already see the pages in the right of the same footer, and
> showing the same info textually is superficial. However, writing
> Results
> shows the total number of records, which is more information.
>
> Unless there are objections, I will change the static grid to match
> the
> above output as well.

Sounds ok to me. cc-ing Shane and Chris just in case.

--Paul

>
> --
> Fix all occurrences of "Results 0-10"
> https://bugs.launchpad.net/bugs/418621
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in KARL3: In Progress
>
> Bug description:
>
> In some places we say "Page 1 of 3". For example, on the OVERVIEW
> of a community, in the listing for recent items. I believe this is
> a table that isn't a GridTable.
>
> In places where we *do* use GridTable, we use a different naming
> scheme. One that says "Results", and starts at number 0.
>
> Try to make the GridTable match up with ZPT-driven display. Either
> make both say Results or both say Pages. More important, don't
> start numbering at zero.

Balazs Ree (ree)
Changed in karl3:
status: In Progress → Fix Committed
Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.