MIR for axis2c

[Chuck Short]

I would like to include axis2c in main:

https://wiki.ubuntu.com/Axis2cMIR

If you have any questions please let me know.

Regards
chuck

[Thierry Carrez (ttx)]

Note that this is required for Eucalyptus to reach main (it's one of the 2 non-Java packages required).

[Loïc Minier (lool)]

I pushed some packaging fixes.

FYI, new upstream 1.6.0 available. Server team should subscribe to bug mail.

Same remark about link flags as for librampart.

These issues are more serious and need to be addressed:
E: libaxis2c0: incorrect-libdir-in-la-file usr/lib/axis2/modules/addressing/libaxis2_mod_addr.la /usr/modules/addressing != /usr/lib/axis2/modules/addressing
E: libaxis2c0: incorrect-libdir-in-la-file usr/lib/axis2/modules/logging/libaxis2_mod_log.la /usr/modules/logging != /usr/lib/axis2/modules/logging
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_http_sender.so.0.5.0 usr/lib/libaxis2_http_sender.so
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_http_common.so.0.5.0 usr/lib/libaxis2_http_common.so
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_http_receiver.so.0.5.0 usr/lib/libaxis2_http_receiver.so
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_axiom.so.0.5.0 usr/lib/libaxis2_axiom.so
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_engine.so.0.5.0 usr/lib/libaxis2_engine.so
W: libaxis2c0: non-dev-pkg-with-shlib-symlink usr/lib/libaxis2_parser.so.0.5.0 usr/lib/libaxis2_parser.so

I think these are libaxis2 modules which should be living in /usr/lib/axis2c or something like that.

This needs to be fixed, someone needs to subscribe to bug mail, and then I'll pass this package to Kees to have a glance at it (network listening daemon).

FYI I started enabling the testsuite, but it doesn't build:
cc1: warnings being treated as errors
In file included from /usr/include/string.h:641,
                 from ../../include/axutil_string.h:26,
                 from test_util.c:22:
In function ‘strcpy’,
    inlined from ‘test_log_write’ at test_util.c:275:
/usr/include/bits/string3.h:106: error: call to __builtin___strcpy_chk will always overflow destination buffer

See rules to see the issue; would be nice to work on this.

[Kees Cook (kees)]

This package contains a highly modified and forked copy of pieces of the unzip package (see util/src/minizip). Memory allocation seems safe where spot-checked, and nothing else jumps out as a problem. This is a pretty large bit of code to maintain outside of Debian.

[Soren Hansen (soren)]

New upstream 1.6.0 uploaded. Everything moved out of /usr/lib into /usr/lib/axis2. Kees, I'm not sure what you want me to do about the minizip thing? Mention something in debian/copyright, perhaps?

As for the test suite, that failure is really strange. They declare "char msg[10]" and then try to copy a 13 byte string into it. That in itself is odd, but the oddest thing is that the variable isn't used for anything. It's only referenced in that strcpy call. Removing it (or extending the char array to 15) lets it continue a bit, but the test suite still fails. It would be nice to get this fixed, but it won't happen in time for FF (which is 40 minutes from now).

[Martin Pitt (pitti)]

I proactively promoted this, since it's blocking server CD building and testing. (cf. recent discussion about promoting the entire euca stack now, and reviewing it later, to avoid having to review/fix everything by FF).

[Loïc Minier (lool)]

I'm happy with the changes, moving to Kees for the other security questions.

[Kees Cook (kees)]

I'm okay with the minizip stuff as long as you're aware of it existing in the package. I would, however, like the testsuite working as much as possible before karmic releases. Once that's set, I'd +1 this as well.

[Spiffysiron (iamwired2000)]

Hi. Well let me start with my name. I am giving it too you because I just recieved an e-mail message from your address.

I do have a question. How do I manage this bug thing, I mean, how do I help other unsucsessfull users?.

Mark.

> Date: Mon, 14 Sep 2009 14:10:45 +0000
> From: <email address hidden>
> To: <email address hidden>
> Subject: [Bug 418225] Re: MIR for axis2c
>
> ** Changed in: axis2c (Ubuntu Karmic)
> Assignee: Soren Hansen (soren) => Thierry Carrez (ttx)
>
> --
> MIR for axis2c
> https://bugs.launchpad.net/bugs/418225
> You received this bug notification because you are subscribed to Karmic.
>
> Status in “axis2c” package in Ubuntu: Incomplete
> Status in axis2c in Ubuntu Karmic: Incomplete
>
> Bug description:
> I would like to include axis2c in main:
>
> https://wiki.ubuntu.com/Axis2cMIR
>
> If you have any questions please let me know.
>
> Regards
> chuck

_________________________________________________________________
With Windows Live, you can organize, edit, and share your photos.
http://www.microsoft.com/southafrica/windows/windowslive/products/photo-gallery-edit.aspx

[Thierry Carrez (ttx)]

Testsuite was enabled in the latest upload.
It's still slightly disturbing that there is no way the testsuite can actually ever run without the patch we added though :)

[Loïc Minier (lool)]

Fix committing since testsuite was enabled and that was the last blocker

[Kees Cook (kees)]

+1, thanks for getting that running!

[Kees Cook (kees)]

Err, it seems you have a diff.gz change combined with a patches change to un-do it?

--- axis2c-1.6.0/util/test/util/test_util.c
+++ axis2c-1.6.0.orig/util/test/util/test_util.c
@@ -243,6 +243,7 @@
 test_log_write(
     )
 {
+ char msg[10];
     printf("start of test_log_write\n\n");
     axutil_allocator_t *allocator = axutil_allocator_init(NULL);
     if (!allocator)
@@ -271,6 +272,7 @@
         printf("cannot create env with error and log\n");
         return;
     }
+ strcpy(msg, "abcd test123");

     AXIS2_LOG_CRITICAL(env->log, AXIS2_LOG_SI, "log1 %s", "test1");
     AXIS2_LOG_ERROR(env->log, AXIS2_LOG_SI, "log2 %d", 2);
only in patch2:
unchanged:
--- axis2c-1.6.0.orig/debian/patches/04_fix_testsuite.patch
+++ axis2c-1.6.0/debian/patches/04_fix_testsuite.patch
@@ -0,0 +1,38 @@
+--- axis2c-1.6.0.orig/util/test/util/test_util.c
++++ axis2c-1.6.0/util/test/util/test_util.c
+@@ -243,7 +243,6 @@
+ test_log_write(
+ )
+ {
+- char msg[10];
+ printf("start of test_log_write\n\n");
+ axutil_allocator_t *allocator = axutil_allocator_init(NULL);
+ if (!allocator)
+@@ -272,7 +271,6 @@
+ printf("cannot create env with error and log\n");
+ return;
+ }
+- strcpy(msg, "abcd test123");
+
+ AXIS2_LOG_CRITICAL(env->log, AXIS2_LOG_SI, "log1 %s", "test1");
+ AXIS2_LOG_ERROR(env->log, AXIS2_LOG_SI, "log2 %d", 2);

[Thierry Carrez (ttx)]

Kees:
soren started playing with the testsuite before and one of his changes (a direct mod of test_util.c) accidentally made it into -0ubuntu4. I moved that change into the 04_fix_testsuite.patch, resulting in that apparent noop in the debdiff. I mentionned it in the changelog.