apt urls on private ppa pages are incorrect (missing credentials)
Bug #404279 reported by
Michael Nelson
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Diogo Matsubara | ||
Bug Description
Currently viewing a private PPA page presents the apt urls as per normal, but these won't work for private PPAs as everyone needs to use their own private access token.
The apt-url section should not be present on the ppa page for private PPAs, but it should instead refer the person to their subscription - or perhaps present their personal apt-line own token on the page (if they have one). Hmm... needs some thought.
Related branches
lp:~matsubara/launchpad/404279-private-ppa-link
- Abel Deuring (community): Approve (code)
- Martin Pool (community): Approve (code*)
-
Diff: 340 lines (+77/-79)7 files modifiedlib/lp/soyuz/browser/archive.py (+5/-31)
lib/lp/soyuz/browser/archivesubscription.py (+7/-32)
lib/lp/soyuz/browser/sourceslist.py (+55/-0)
lib/lp/soyuz/browser/tests/archive-views.txt (+1/-2)
lib/lp/soyuz/browser/tests/archivesubscription-views.txt (+1/-6)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt (+4/-4)
lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt (+4/-4)
| Changed in soyuz: | |
| importance: | Undecided → Medium |
| milestone: | none → 3.0 |
| status: | New → Triaged |
| tags: | added: p3a ppa ui |
| Changed in soyuz: | |
| assignee: | nobody → Michael Nelson (michael.nelson) |
| Changed in soyuz: | |
| milestone: | 3.0 → none |
Revision history for this message
| Cody A.W. Somerville (cody-somerville) wrote | #1 |
| Changed in soyuz: | |
| assignee: | Michael Nelson (michael.nelson) → nobody |
| tags: | added: bugjam2010 |
| tags: | added: ui-easy |
| tags: |
added: easy removed: ui-easy |
| summary: |
- apt urls on private ppa pages should not be displayed + apt urls on private ppa pages are incorrect (missing credentials) |
| Changed in launchpad: | |
| importance: | Medium → High |
| Changed in launchpad: | |
| assignee: | nobody → Diogo Matsubara (matsubara) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: dublin |
Revision history for this message
| Martin Pool (mbp) wrote | #3 |
To post a comment you must log in.
I like having them there as I often need to copy and paste that information without the username and password. However, I do agree that it should be updated to let the user know they won't work and provide a quick link to their subscription page.