Sensors plugin does not obey "ignore" configuration line

[Andrew Cleveland]

Binary package hint: cpufreqd

Release: Ubuntu 9.04
Package: cpufreqd 2.3.3-4

Current behavior: The sensors plugin does not honor the "ignore" line in sensors.conf. This makes it impossible to choose between two features with the same name on different chips.
My sensors.conf:
chip "it8716-*"
chip "k8temp-*"
ignore temp1

Both chips have a feature named temp1, but the one for k8temp is garbage.
Cpufreqd.conf line: sensor=temp1:55-100
On my system, cpufreqd picks the first feature named "temp1" it finds, which is the one attached to k8temp. There is no way to make it pick the it8716 chip.

Expected behavior: if a certain feature on a chip is set to "ignore" in sensors.conf, cpufreqd's sensor plugin will not use it.

A patch is attached that fixes the problem for me. I have reported the bug upstream but I'm not sure how often it is updated.

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
NonfreeKernelModules: nvidia
Package: cpufreqd 2.3.3-4
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: cpufreqd
Uname: Linux 2.6.28-13-generic x86_64

[Andrew Cleveland (evil-saltine)]

Patch against 2.3.3-4 package

[Andrew Cleveland (evil-saltine)]

Other comments about this bug:
http://sourceforge.net/tracker/?func=detail&aid=2008452&group_id=58904&atid=489239
http://sourceforge.net/tracker/?func=detail&aid=1818312&group_id=58904&atid=489239

[Sebastien Bacher (seb128)]

thank you for your work there, is there any reason you change config.sub and config.guess?

[Sebastien Bacher (seb128)]

could you also send the change to the debian bts, the package is on sync right now and it would be nice to keep it this way

[Andrew Cleveland (evil-saltine)]

I don't know why those two files were changed, I followed the instructions on the ubuntu wiki for modifying the deb and creating a debdiff. Maybe I made a mistake somewhere. Thanks for replying. I have forwarded the patch to the Debian tracker.

[Julien Lavergne (gilir)]

Uploaded with a few modifications :
- Remove config.sub and config.guess modifications (it's sometimes generated automatically ).
- Update Maintainer address to Ubuntu Developers <email address hidden> (see https://wiki.ubuntu.com/DebianMaintainerField)
- Use "LP: #" syntax instead of "Closes: #" in debian/changelog ("Closes: #" syntax is for Debian bugs).

Thanks for your work.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cpufreqd - 2.3.3-4ubuntu1

---------------
cpufreqd (2.3.3-4ubuntu1) karmic; urgency=low

  * sensors-plugin: Change to support "ignore" lines in
    sensors.conf (LP: #403868).

 -- Andrew Cleveland <email address hidden> Fri, 24 Jul 2009 11:36:44 +0000

[Andrew Cleveland (evil-saltine)]

Thank you.

This bug is fixed in 2.4.0.