Requester.get_all_tags isn't used and should be deleted

[Jonathan Lange]

A comment in Requester.get_all_tags says that it isn't used. If it's not used, it should be deleted.

[Bertrand Rousseau (bertrand-rousseau)]

I performed a grep on gtg code, and Requester.get_all_tags() does seem not to be used. Should it be considered as a kind of API? If not, I'm fine with deleting it. Besides, this could have no sense after the refactoring since a TreeModel browse a data structure with its own iterators, not through a python list.

[Lionel Dricot (ploum-deactivatedaccount)]

I will handle it, please don't delete it without my confirmation.

[Bertrand Rousseau (bertrand-rousseau)]

Won't do.

On Wed, Jul 15, 2009 at 9:33 AM, Lionel Dricot<email address hidden> wrote:
> I will handle it, please don't delete it without my confirmation.
>
> ** Changed in: gtg
>     Assignee: (unassigned) => Lionel Dricot (ploum)
>
> --
> Requester.get_all_tags isn't used and should be deleted
> https://bugs.launchpad.net/bugs/398647
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> A comment in Requester.get_all_tags says that it isn't used. If it's not used, it should be deleted.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : [phone]

[Lionel Dricot (ploum-deactivatedaccount)]

Fixed in rev. 289

The function has been rewritten in order to be useful. Currently, it's indeed not used but I believe it can be useful to a plugin writer and is well placed in the requester. I don't see the need to remove it.