LaunchpadDirectory shouldn't use xmlrpc
Bug #397739 reported by
Martin Pool
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
John A Meinel | ||
2.3 |
Won't Fix
|
Medium
|
John A Meinel | ||
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
Possibly bzr's LaunchpadDirectory (the thing that provides a directory service like "lp:bzr") shouldn't use xmlrpc lib but rather another protocol:
* xmlrpclib is an external dependency with some bugs like bug 186920
* it's inconsistent with other API-type services on Launchpad
* it's also inconsistent at the code level with the mechanisms used by bzr
We could alternatively send a (possibly authenticated) http REST request.
On the other hand, other than possibly implicitly fixing those bugs, there may not be much of a benefit in changing this, and it would require a new deployment on the Launchpad side.
Related branches
lp:~jameinel/bzr/2.3-avoid-xmlrpc-ssh-397739
- bzr-core: Pending requested
-
Diff: 150 lines (+60/-23)3 files modifiedbzrlib/plugins/launchpad/lp_directory.py (+38/-17)
bzrlib/plugins/launchpad/test_lp_directory.py (+6/-6)
doc/en/release-notes/bzr-2.3.txt (+16/-0)
Rejected
for merging
into
lp:bzr/2.3
- Vincent Ladeuil: Approve
- Jelmer Vernooij (community): Needs Information
-
Diff: 142 lines (+53/-23)3 files modifiedbzrlib/plugins/launchpad/lp_directory.py (+38/-17)
bzrlib/plugins/launchpad/test_lp_directory.py (+6/-6)
doc/en/release-notes/bzr-2.3.txt (+9/-0)
lp:~jameinel/bzr/2.3-three-part-resolution-stacking-741375
- Vincent Ladeuil: Approve
-
Diff: 267 lines (+168/-11)4 files modifiedbzrlib/plugins/launchpad/lp_directory.py (+31/-6)
bzrlib/plugins/launchpad/lp_registration.py (+2/-1)
bzrlib/plugins/launchpad/test_lp_directory.py (+133/-3)
doc/en/release-notes/bzr-2.3.txt (+2/-1)
tags: | added: lpurl |
Changed in launchpad: | |
status: | Triaged → Invalid |
tags: | added: easy |
Changed in launchpad: | |
status: | Invalid → Fix Released |
To post a comment you must log in.
Not as much of a deployment on the Launchpad side as you might think. We already have a public method that takes a branch URL (including an lp: URL) and returns a branch object.
There is already a patch to bzr providing a facility for doing authenticated http REST requests to Launchpad. Note that this introduces more external dependencies. These deps are in some ways worse than xmlrpclib, since they don't come with the standard library.
If Bazaar would like to avoid these dependencies, then we could perhaps provide our own implementation of a subset of launchpadlib.
I'm definitely personally interested in seeing this bug fixed.