Missing line-end comma in debian/control

[Andrew Sayers]

Binary package hint: gnome-format

This bug was sent manually, but the text was written to a template, as I have several similar bugs to report today. Please see my recent bug reports for a list, or bug #391165 for the root cause.

Version 0.1.1-0ubuntu5 of gnome-format has a missing line-end comma in the "Build-Dependencies" section of debian/control. There should be a comma in the area marked by ***asterisks***:

Build-Depends: debhelper (>= 6),
 libglib2.0-dev (>= 2.10.0),
 libgtk2.0-dev (>= 2.10.0),
 libdbus-glib-1-dev,
 libgee-dev,
 libglade2-dev,
 libparted1.8-dev***
 ***intltool,
 valac (>= 0.5.1),
 gnome-doc-utils,
 docbook-utils,
 dpatch

I haven't tested the exact effects of this issue in gnome-format. It might be that these dependencies are unnecessary and can be removed, or it might be that some features are silently disabled (see bug #365770 for an example). If the dependencies should stay, the bug can be fixed by inserting a comma in the marked area.

[David Stansby (dstansby-deactivatedaccount)]

Here's the patch that fixes this bug.

[Alessio Treglia (quadrispro)]

It FTBFS:

Checking for gmodule-2.0 flags : ok
Checking for gio-unix-2.0 flags : ok
Checking for libparted flags : ok
Checking for gthread-2.0 flags : ok
touch configure-stamp
dh_testdir
/tmp/buildd/gnome-format-0.1.1/waf
[1/9] valac_task: src/gnome-format-dialog.vala src/gnome-format-hal-storage-provider.vala src/gnome-format-main.vala src/gnome-format-storage-provider.vala src/gnome-format-storage.vala -> build/default/src/gnome-format-dialog.c build/default/src/gnome-format-dialog.h build/default/src/gnome-format-hal-storage-provider.c build/default/src/gnome-format-hal-storage-provider.h build/default/src/gnome-format-main.c build/default/src/gnome-format-main.h build/default/src/gnome-format-storage-provider.c build/default/src/gnome-format-storage-provider.h build/default/src/gnome-format-storage.c build/default/src/gnome-format-storage.h
[2/9] po: po/de.po -> build/default/po/de.mo
gnome-format-dialog.vala:85.48-85.69: error: method `GnomeFormat.FormatDialog.on_window_delete_event' is incompatible with signal `Gtk.Widget.delete_event', expected `bool on_window_delete_event (Gdk.Event)'
Build failed
 -> task failed (err #1):
 {task: valac_task gnome-format-dialog.vala,gnome-format-hal-storage-provider.vala,gnome-format-main.vala,gnome-format-storage-provider.vala,gnome-format-storage.vala -> gnome-format-dialog.c,gnome-format-dialog.h,gnome-format-hal-storage-provider.c,gnome-format-hal-storage-provider.h,gnome-format-main.c,gnome-format-main.h,gnome-format-storage-provider.c,gnome-format-storage-provider.h,gnome-format-storage.c,gnome-format-storage.h}
make: *** [build-stamp] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2
pbuilder: Failed autobuilding of package
 -> Aborting with an error
 -> unmounting dev/pts filesystem
 -> unmounting proc filesystem
 -> cleaning the build env
    -> removing directory /home/debomatic/incoming/karmic/build/30472 and its subdirectories

I'm in touch with upstream, I will try to fix both issues.

Please next time test-build the package before submitting a patch.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-format - 0.1.1-0ubuntu6

---------------
gnome-format (0.1.1-0ubuntu6) karmic; urgency=low

  * Rebuild for libparted1.8-10 -> 12 transition.
  * debian/control:
    - Add missing comma to build-depends (LP: #392205).
    - Add build-depend on waf.
  * debian/patches/02-compile_with_latest_vala_fix_from_git.dpatch:
    - Backport fix from GIT to fix FTBFS with latest vala.
  * debian/patches/03-add_parted_vapi,
    debian/patches/04-remove_old_vapi.dpatch:
    - Backport patches from GIT to add vapi/parted.vapi and remove old
      vapi from src/wscript_build, needed for above patch.
  * debian/patches/05-fix_use_of_uninitialized_variable.dpatch:
    - Fix use of possibly unassigned local variable `storage_provider',
      causing FTBFS with latest vala.
  * debian/rules:
    - Use system /usr/bin/waf to build source rather than the version
      in the source package. It fails to build with the shipped version.

 -- Chris Coulson <email address hidden> Mon, 14 Sep 2009 00:22:18 +0100