Please update flatnuke 2.7.1 to 2.7.2

[Andres Rodriguez]

Binary package hint: flatnuke

New upstream release includes several fixes, changes and new features:

        Change: Redirect to the self page when changing language (idea from Jack Overfull)
        Fix: Prevent posting blank comments
        Fix: Display button management for sections in homepage
        Fix: Hide sections list if the current section is displayed as homepage
        Fix: Moved saving comments from verify.php to Flatnuke main engine
        Fix: Fixed security bug http://www.securityfocus.com/bid/34486

        Alessandro Vernassa <email address hidden>
        Fix: patch for preventing warnings in non xhtml themes

        Lorenzo Caporale <email address hidden>
        Add: New layout for missing pages and access denied

        Ignazio Coco <email address hidden>
        Change: Better blocks layout management by themes

[Charlie_Smotherman (cjsmo)]

Andres,

After working on this bug myself I would like to take this opportunity to raise a few concerns about the flatnuke upgrade.

The first and biggest concern I have is did you test install, test remove and test purge flatnuke on a karmic system? This must be done to ensure that flatnuke does not leave a users system in a failed state. These are thing we as developers must do.

When you build your package do you test the package with lintian? If not please consider using it. It can give you a wealth of information about packaging mistakes. It checks your packages to make sure it conforms to policy.

I see very few changes in your debdiff that affect the debian directory. You should take this opportunity to get the package in the best shape possible, since this package in not in debian.

You should check very carefully debian/dirs and debian/install for any addition or deletion of files or directories, there are a number that have changed.

You should add the GPL-2 preamble to debian/copyright

Lintian will probably complain of the debhelper version being to old. Consider bumping the debian/control Build-Depends section to debhelper (>=7).

You will also have to set debian/compat to 7

Consider bumping debian/control Standards-Version to 3.8.1

Lintian will also complain of wrong file permissions, I would consider adding this to debian/rules

 dh_install
   find ../ -type d -exec chmod 755 {} \;
   find ../ -type f -exec chmod 644 {} \;

You will also need to flip the build arch section of debian/rules to look something like this

# Build architecture-dependent files here.
binary-arch: build install
# We have nothing to do by default.

# Build architecture-independent files here.
binary-indep: build install

Lintian will probably complain of the installation of empty files and directories. Please check to see if these empty files are needed for flatnuke generated content. In this case they are allowed by policy. If they are needed then consider adding a lintian override.

These are all I can find at the moments. I'm sure once MOTU takes a look there will be others.

Best regards
Charlie Smotherman

[Charlie_Smotherman (cjsmo)]

Here is a .diff.gz of the flatnuke upgrade.

[Andres Rodriguez (andreserl)]

Hi there.

Sorry for the delay on responding but I've been away the last week. Anyways, It seems that you've already done your changes. Thanks for the suggestions though.

Cheers,

Andres.

[Nick Ellery (nick.ellery)]

Hi Charlie,

Took a quick look at the diff, and a few things need to be changed:
- update to standards-version 3.8.2
- the homepage link in the long description can be removed
- dh_clean should not be change to dh_prep. dh_prep replaces only dh_clean -k. See the dh_prep manpage.
- the GPL license you added in debian/copyright with just "either version 2 of the License." You need to see whether the author licensed this under GPL-2 only, or any later version at your option. If it's specifically GPL-2, then the either can be dropped, and if it's any later version, that needs to be included in that sentence.

Thanks,
Nick

[Charlie_Smotherman (cjsmo)]

Nick,

Thanks for looking at this. I am attaching a new .diff.gz and debdiff with the above changes.

[Charlie_Smotherman (cjsmo)]

attaching a new .diff.gz. I simplified debian/rules to take advantage of dh 7

[Andreas Moog (ampelbein)]

Ouch, sorry I hadn't seen this report before. I uploaded 2.7.2 just a few minutes ago. Sorry again, will look for open sponsoring bugs next time, I promise.