openafs-modules-dkms should depend on dkms

[Jesper Larsen]

Impact:
openafs-modules-dkms fails to install because the postinst scripts cannot complete without dkms being installed

How the bug is addressed:
Add dkms to the dependency list for the openafs-modules-dkms package

Patch:
There's a debdiff in comment 1 for jaunty-proposed.

TEST CASE;
Without having dkms installed, run "sudo aptitude install openafs-modules-dkms" and watch it fail to install

Regression Potential:
None, openafs-modules-dkms doesn't install at the moment.

[Anders Kaseorg (andersk)]

This might be worth a quick SRU.

[Anders Kaseorg (andersk)]

For Karmic, this will be fixed by my patch in bug #370458.

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.4.10+dfsg1-1+ubuntu1

---------------
openafs (1.4.10+dfsg1-1+ubuntu1) karmic; urgency=low

  * Merge from Debian unstable (LP: #370458), remaining changes:
    - Reenable DKMS support, which was commented out of 1.4.8.dfsg1-1.
  * Make openafs-modules-dkms depend on dkms. (LP: #368471)
  * Parse $(VERSION) and $(DEBVERS) from debian/changelog.
    (LP: #364426)

openafs (1.4.10+dfsg1-1) unstable; urgency=high

  * New upstream release.
    - OPENAFS-SA-2009-001: Avoid a potential kernel memory overrun if more
      items than requested are returned from an InlineBulk or BulkStatus
      message. (CVE-2009-1251)
    - OPENAFS-SA-2009-002: Avoid converting negative errors into invalid
      kernel memory pointers. (CVE-2009-1250)
    - Preliminary support for 2.6.30 kernels.
    - Dynamic vcache allocation support to deal with inotify vcache
      pinning.
    - Do appropriate locking for CellServDB in /proc.
    - Use +dfsg instead of .dfsg for saner version sorting.
  * Debian's 2.6.29 packages no longer include symlinks from the
    architecture-specific header tree to the common header tree and
    instead overlay both header trees using kbuild. Change the Autoconf
    probes to always use kbuild and generate stub headers in the paths
    that OpenAFS expects that include the linux headers. Patch from Aaron
    M. Ucko. (Closes: #521745)
  * Build PIC versions of libafsauthent and libafsrpc and install them in
    libopenafs-dev for use when AFS code should be embedded into shared
    libraries. Patch from Garrett Wollman.
  * Update CellServDB to 2008-11-07 version. (Closes: #522451)
  * Update debian/watch for +dfsg naming instead of .dfsg.
  * Update standards version to 3.8.1 (no changes required).
  * Translation updates:
    - Japanese, thanks Hideki Yamane. (Closes: #521518)

 -- Anders Kaseorg <email address hidden> Wed, 29 Apr 2009 02:31:47 -0400

[John Dong (jdong)]

ACK from MOTU-SRU for Jaunty

[Sarah Kowalik (hobbsee-deactivatedaccount)]

Accepted into jaunty proposed, please solicit the usual testing.

[Anders Kaseorg (andersk)]

Works for me.

[Steve Beattie (sbeattie)]

I've reproduced the installation failure with openafs-modules-dkms 1.4.9.dfsg1-0+ubuntu3. When I tried to verify the fix, the upgrade from the broken version to the version in jaunty-proposed, 1.4.9.dfsg1-0+ubuntu3.1, failed in the prerm script in the 'dkms remove -m openafs -v "$version" --all' command with the message:

  Error! There are no instances of module: openafs
1.4.9 located in the DKMS tree.

But the 'dkms add' command in the postinst succeeded, so doing dpkg-reconfigure on the openafs-modules-dkms package caused the build to happen. It seems to me that the fix is incomplete and that prerm script ought to wrap the 'dkms remove' call to prevent its failure from causing the upgrade to fail.

[Anders Kaseorg (andersk)]

Victornurse: No, I assure you this bug is already fixed in Karmic.

Package: openafs-modules-dkms
Version: 1.4.11+dfsg-1
Depends: dkms, bison, flex
         ^^^^

This bug is about a Jaunty SRU. If you’re seeing some other bug in the Karmic package, don’t hesitate to open a new bug report.

[Martin Pitt (pitti)]

Marked as verification-failed according to Steve Beattie's test in comment 7.

[Benjamin Drung (bdrung)]

Nothing to do for ubuntu-universe-sponsors. Therefore I unsubscribe them.

[Martin Pitt (pitti)]

It seems that the updated package helps, but doesn't fix it completely. I'll send it to -updates but keep the bug open for the remaining case that Steve pointed out.

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.4.9.dfsg1-0+ubuntu3.1

---------------
openafs (1.4.9.dfsg1-0+ubuntu3.1) jaunty-proposed; urgency=low

  * Make openafs-modules-dkms depend on dkms. (LP: #368471)

 -- Anders Kaseorg <email address hidden> Fri, 01 May 2009 12:59:29 -0400

[Evan Broder (broder)]

I'm going to go ahead and close this bug - I'll be including a patch for the remaining issue as part of my fix for bug #463429.