utils.calculate_cloud() can leave font_size unset for most frequent tag

[Rob van der Linde]

Binary package hint: python-django-tagging

Current version of package ``python-django-tagging'' has a long standing bug in a _calculate_tag_weight() method.

When a programmer creates tag cloud using method util.calculate_cloud() or Tag.objects.cloud_for_model() and sets distribution argument to ``LOGARITHMIC'' (or leave it empty as it is default value) _calculate_tag_weight() in some cases may return result which is greater than max_weight - because of that Tag object (the one most frequently used in model) will be missing argument ``font_size'' and throw AttributeError exception. It happens because of the way a floating point division is done in Python.

The proposed patch address this issue by returning ``max_weight'' in case when result of computation is greater than it.

I'm attaching a testcase in a form of a django project. To use it you must install python-django-tagging and then from project root execute ``./manage.py test''. AssertionError will be thrown. After fixing this issue test passes.

A link to upstream bugreport: http://code.google.com/p/django-tagging/issues/detail?id=91

[Krzysztof Klimonda (kklimonda)]

I'll ask MOTU if this bug qualifies for a SRU. In the meantime could You provide a test case that illustrates it?

[John Dong (jdong)]

ACK from MOTU-SRU.

[Scott Kitterman (kitterman)]

Accepted into jaunty-proposed, the package will build now and be available in a few hours.Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Krzysztof Klimonda (kklimonda)]

I've tested updated package using my testcase in clean jaunty environment and it fixes the issue. More feedback would be great. :)

[Krzysztof Klimonda (kklimonda)]

This bug will be fixed in KK when sync (LP #373845) is done.

[Krzysztof Klimonda (kklimonda)]

As sync is impossible I'm attaching a debdiff against python-django-tagging_0.2.1+svn154-0ubuntu2 for KK (It's the same as previous with changed release name.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-django-tagging - 0.2.1+svn154-0ubuntu2.1

---------------
python-django-tagging (0.2.1+svn154-0ubuntu2.1) jaunty-proposed; urgency=low

  * debian/patches/02_fix_calculate_tag_weight.patch: Fix error in
    _calculate_tag_weight which in some cases may lead to font_size
    attribute of most frequent used tag set to None. (LP: #367214)

 -- Krzysztof Klimonda <email address hidden> Sun, 26 Apr 2009 23:39:17 +0200

[Daniel Holbach (dholbach)]

Uploaded. Maybe you can make use of https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines the next time? :-)