Bashism in vznetcfg makes it impossible to use veth in a vz

[Michael Jeanson]

Binary package hint: vzctl

In Hardy, the vznetcfg script contains a bashism that makes it impossible to use veth devices. This was fixed in debian unstable and synced in Jaunty.

TEST CASE:
On a functionnal openvz host, create a new vz :
vzctl create 101

Add a veth interface to the vz
vzctl set 101 --netif_add eth0 --save

Try to start the vz:
vzctl start 101
Starting VE ...
VE is mounted
Setting CPU units: 1000
Configure meminfo: 9223372036854775807
Configure veth devices: veth101.0
/usr/sbin/vznetcfg: 20: source: not found
VE start in progress...

The vz starts but the veth device is not configured.

Regression potential:
The fix is a oneliner that removes a bashism, regression potential is very low.

[Michael Jeanson (mjeanson)]

Patch was done inline as in debian. I could add a minimal patch system if it's the preffered method.

[Stéphane Graber (stgraber)]

Set priority, without that fix the user has to symlink /bin/sh to /bin/bash in order to make the script work (or change it by hand).

[Stéphane Graber (stgraber)]

Can you please add the LP bug number in the changelog entry like : " (LP: #365689)" ?
That way the LP bug gets closed when the package is uploaded.

[Cody A.W. Somerville (cody-somerville)]

ACK

There were some problems with your changelog entry though. I've corrected them for you and sponsored the upload. Please take note of the following for the next time you prepare an SRU:

 - The target specified in the changelog should be the proposed pocket of the series, not the release suite. So in this case, the changelog should have targeted hardy-proposed instead of hardy.
 - There are strict versioning requirements for Stable Release Updates to ensure that the update does not conflict with any later and future version in other Ubuntu releases. Instead of version 3.0.22-5ubuntu2, the correct version for this SRU is 3.0.22-5ubuntu1.1.
 - Changelog entries should list the LP bug numbers that it is fixing and, if not the same, it should also list the bug created for the SRU process. In this case, your changelog entry should have referred to LP: #365689 and not the Debian bug.
 - Changelog entries should always strive for accuracy, brevity, and clarity. This is especially important when performing an SRU. Please be more detailed in the future.

For more information about the Stable Release Update process and procedures, please refer to https://wiki.ubuntu.com/StableReleaseUpdates

If you have any questions, comments, or concerns then please feel free to send me an e-mail or ping me on IRC.

Thank you for your contribution to Ubuntu; it is highly appreciated.

[Cody A.W. Somerville (cody-somerville)]

Marking karmic task as fix released since it already has the fix.

[Michael Jeanson (mjeanson)]

You're work is greatly appreciated. I'll make to test when it gets in proposed.

[Jonathan Riddell (jr)]

Accepted into hardy-proposed, please test.

[Stéphane Graber (stgraber)]

I can confirm the fix as shown below:

----
BEFORE

root@athos:~# vzctl start 999
Starting VE ...
VE is mounted
Setting CPU units: 1000
Configure meminfo: 9223372036854775807
Set hostname: test
Configure veth devices: veth999.0
/usr/sbin/vznetcfg: 20: source: not found
VE start in progress...

----
AFTER

root@athos:~# vzctl start 999
Starting VE ...
VE is mounted
Setting CPU units: 1000
Configure meminfo: 9223372036854775807
Set hostname: test
Configure veth devices: veth999.0
Adding interface veth999.0 to bridge br0 on CT0 for CT999
VE start in progress...

[Michael Jeanson (mjeanson)]

I confirm it fixes the problem on my systems too.

[Marc Gariépy (mgariepy)]

It does fix the same issue on my system.

thanks

[Bruno Lambert (bruno.lambert)]

I confirm it WFM too.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vzctl - 3.0.22-5ubuntu1.1

---------------
vzctl (3.0.22-5ubuntu1.1) hardy-proposed; urgency=low

  [Michael Jeanson]
  * bin/vznetcfg.in, bin/vzmigrate.in:
    - Fix bashisms that prevented the use of veth devices.
    - Closes LP: #365689

  [Cody A.W. Somerville]
  * Fixed up the changelog entry for SRU.

 -- Michael Jeanson <email address hidden> Thu, 23 Apr 2009 15:50:20 -0400