sysinfo shows incorrect Release

[William Wynn]

Binary package hint: sysinfo

I'm not completely sure this is a bug, or that it applies to sysinfo, but I couldn't find anything about it online.

I installed 9.04 Jaunty during Beta 5, and ever since then, the "Release" section under "General system information" lists 5.0. Considering that Jaunty is in RC now, I know this isn't correct. Will this fix when the final version is released. I assume those that install normally will have the right thing listed. I'm not sure why this isn't updating though.

lsb-release seems fine and doesn't even mention anything about 5.0.

Release: 9.04
Codename: jaunty

[Koen (koen-beek)]

Confirmed on Jaunty RC d.d. 18/4/2009

[Koen (koen-beek)]

I can confirm that this error occurs with the binary package of sysinfo

ii sysinfo 0.7-1ubuntu5 display computer and system information

however, when I build from source package using debuild it creates a binary package where it works correctly

> apt-get source sysinfo
> sudo apt-get build-dep sysinfo
> cd sysinfo-0.7
> debuild
> sudo dpkg -i ../sysinfo_0.7-1ubuntu5_all.deb

and then it works

it seems the binary build dit not take into account the patch - 09-ubuntu_lsb_release.diff
the build log confirms this http://launchpadlibrarian.net/20959796/buildlog_ubuntu-jaunty-i386.sysinfo_0.7-1ubuntu5_FULLYBUILT.txt.gz
last patch to be taken into account is 08-correct_url.diff

In the log file of debuild patch 09-ubuntu_lsb_release.diff is taken into account

[Koen (koen-beek)]

The build log contains the following error :

make: lsb_release: Command not found

in the rules file the following command fails : DISTRO = "$(shell lsb_release -si)"

this causes
ifeq ($(DISTRO),"Ubuntu")
export QUILT_SERIES=$(QUILT_PATCH_DIR)/series-ubuntu
endif

to not use the ubuntu series of patches -- the difference with the one for debian is the 09-ubuntu-release.diff patch

I would suggest we can avoid these tests, as the 09-ubuntu_release.diff patch should not cause any problems for other distros, as it will first check all the options as now (debian_version, fedora-release, SuSE-release etc) and then try lsb-release

[Koen (koen-beek)]

Following debdiff can be used for a corrected version where

The above tests are not done in rules and all patches including patch 09-ubuntu_lsb_release.diff is applied

[Koen (koen-beek)]

I've added a corrected version to my PPA : https://launchpad.net/~koen-beek/+archive/ppa

see here how to add a PPA to your software repo's : https://help.launchpad.net/Packaging/PPA#Adding%20a%20PPA%20to%20your%20Ubuntu%20repositories

in stead of awn-testing used as an example in the guide you'll need to use koen-beek

[Koen (koen-beek)]

This is a debdiff with a better log in the changelog as it includes the LP bug number

[Thierry Carrez (ttx)]

@Koen Beek:
Wouldn't that be better handled by properly build-depending on lsb-release, so that the patchset is properly selected ? See sysinfo - 0.7-2ubuntu1~ppa2 on https://launchpad.net/~ttx/+archive/ppa if you want to test it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package sysinfo - 0.7-2ubuntu1

---------------
sysinfo (0.7-2ubuntu1) karmic; urgency=low

  * debian/control: Add Build-depend on lsb-release so that the right
    patchset gets selected and release info is correct (LP: #363130)

 -- Thierry Carrez <email address hidden> Mon, 27 Jul 2009 09:26:58 +0200

[Iain Lane (laney)]

Hiya,

I just came across this patch when merging. It could have been applied in Debian, then this package would (again) be in sync. Please forward such changes to Debian in future. I have applied it directly in sysinfo's SVN repo now.

Cheers,
Iain