GTG

remember the window sizes and position

Bug #354831 reported by Jeff Fortin Tam
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Medium
Unassigned

Bug Description

The taskeditor window does not remember its size.

Changed in gtg:
importance: Undecided → Medium
milestone: none → 0.2
status: New → Confirmed
Revision history for this message
Dennis Craven (dcraven) wrote :

Is each task supposed to remember it's own position or should the edit window open in the same place? If the latter, then which position is remembered when multiple tasks are opened?

Revision history for this message
Jeff Fortin Tam (kiddo) wrote :

Nah, I don't think remembering the size/position on a "per note" basis would be good, users would spend more time managing windows instead of contents.

I'd suggest simply saving the size when a taskeditor window is closed. Thus the last one to be closed is the one whose dimensions will be used for opening new windows? Does that implementation make sense ?_?

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

From a spatial pov, remembering size and position makes sense and I want to try that solution. It's already implemented in the code but, for some reason, the setting of the position doesn't work. (but this position is well saved ). If someone is interested, just have a look at line 572 of taskbrowser/browser.py

Revision history for this message
Dennis Craven (dcraven) wrote : Re: [Bug 354831] Re: remember the window sizes

On Tue, Nov 3, 2009 at 3:28 AM, Lionel Dricot <email address hidden> wrote:

> >From a spatial pov, remembering size and position makes sense and I want
> to try that solution. It's already implemented in the code but, for some
> reason, the setting of the position doesn't work. (but this position is
> well saved ). If someone is interested, just have a look at line 572 of
> taskbrowser/browser.py
>
>
That code does work. The problem is that it only gets run when gtg is
initially started. To see it work, uncomment that line, start gtg, open a
few task editor windows and move them around the screen. When you're ready,
close gtg while still having task editor windows open. Next time you start
gtg those windows will open in the correct position.

The problem is that, with a spatial implementation of window position, you
should be able to open a task editor window, move it, close it, then have it
reopen in that position all within the same run of the application (does
that make sense?).

To solve this, each separate task would need it's own size attributes in the
database (whatever db that may be). Then it could move itself when it is
opened.

Is this what you want to happen? Or is Jean-Francois's idea what you guys
were thinking?

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote : Re: [Gtg] [Bug 354831] Re: remember the window sizes

On Wed, Nov 4, 2009 at 5:32 PM, Dennis Craven <email address hidden> wrote:

> On Tue, Nov 3, 2009 at 3:28 AM, Lionel Dricot <email address hidden> wrote:
>
> > >From a spatial pov, remembering size and position makes sense and I want
> > to try that solution. It's already implemented in the code but, for some
> > reason, the setting of the position doesn't work. (but this position is
> > well saved ). If someone is interested, just have a look at line 572 of
> > taskbrowser/browser.py
> >
> >
> That code does work. The problem is that it only gets run when gtg is
> initially started. To see it work, uncomment that line, start gtg, open a
> few task editor windows and move them around the screen. When you're ready,
> close gtg while still having task editor windows open. Next time you start
> gtg those windows will open in the correct position.
>
> The problem is that, with a spatial implementation of window position, you
> should be able to open a task editor window, move it, close it, then have
> it
> reopen in that position all within the same run of the application (does
> that make sense?).
>
> To solve this, each separate task would need it's own size attributes in
> the
> database (whatever db that may be). Then it could move itself when it is
> opened.
>
> Is this what you want to happen? Or is Jean-Francois's idea what you guys
> were thinking?
>

Yes, in my view, this is the behaviour we should adopt: each task has its
own spatial information. So that you can build some kind of spatial
organization of your task while you read or edit them. I guess we should
store size and position somewhere. Probably in the configuration directory
since this is machine-related.

> --
> remember the window sizes
> https://bugs.launchpad.net/bugs/354831
> You received this bug notification because you are a member of Gtg
> developers, which is subscribed to Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> The taskeditor window does not remember its size.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> More help : https://help.launchpad.net/ListHelp
>

--
Bertrand Rousseau
Rue Victor Horta, 31/202 1348 Louvain-la-Neuve, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Revision history for this message
Dennis Craven (dcraven) wrote :

>
> Yes, in my view, this is the behaviour we should adopt: each task has its
> own spatial information. So that you can build some kind of spatial
> organization of your task while you read or edit them. I guess we should
> store size and position somewhere. Probably in the configuration directory
> since this is machine-related.
>
>
If that's the case, then there would need to be attributes or tags added to
the task XML data file to store this information. Trying to synchronize
attributes like position by task in a separate file (or files) from the
actual task data (XML) might be messy.

Is this an acceptable solution? This would mean GUI specific data being
added to the task XML file.

Revision history for this message
Luca Invernizzi (invernizzi) wrote : Re: remember the window sizes

Since each task has an UUID, I don't believe that splitting task specific and GUI specific attributes in separate files would be messy, as you can use the UUID to link them.

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote : Re: [Gtg] [Bug 354831] Re: remember the window sizes

I'm not sure we need to synchronize positions and size. I think this could
be fine if it's only stored locally. I don't think having positional
information synchronized over different computer is relevant.

On Wed, Nov 4, 2009 at 11:47 PM, Luca Invernizzi <email address hidden>wrote:

> Since each task has an UUID, I don't believe that splitting task
> specific and GUI specific attributes in separate files would be messy,
> as you can use the UUID to link them.
>
> --
> remember the window sizes
> https://bugs.launchpad.net/bugs/354831
> You received this bug notification because you are a member of Gtg
> developers, which is subscribed to Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> The taskeditor window does not remember its size.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> More help : https://help.launchpad.net/ListHelp
>

--
Bertrand Rousseau
Rue Victor Horta, 31/202 1348 Louvain-la-Neuve, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote : Re: remember the window sizes

I think that the size and position information are already saved for each task in the config file, which is exactly what bertrand is describing in comment #8.

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote : Re: [Gtg] [Bug 354831] Re: remember the window sizes

On Thu, Nov 5, 2009 at 9:00 AM, Lionel Dricot <email address hidden> wrote:

> I think that the size and position information are already saved for
> each task in the config file, which is exactly what bertrand is
> describing in comment #8.
>
>
It seems only opened tasks have their positions saved. I think we should go
truly spatial, and save position data for each task. Maybe in a separate
configuration file, to avoid cluterring.

> --
> remember the window sizes
> https://bugs.launchpad.net/bugs/354831
> You received this bug notification because you are a member of Gtg
> developers, which is subscribed to Getting Things GNOME!.
>
> Status in Getting Things GNOME!: Confirmed
>
> Bug description:
> The taskeditor window does not remember its size.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~gtg <https://launchpad.net/%7Egtg>
> More help : https://help.launchpad.net/ListHelp
>

--
Bertrand Rousseau
Rue Victor Horta, 31/202 1348 Louvain-la-Neuve, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote : Re: remember the window sizes

bug #406887 is also somewhat related.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Spatial GTG implemented in rev. 353

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
status: Confirmed → Fix Committed
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

reopening, I don't know why but it doesn't work anymore

summary: - remember the window sizes
+ remember the window sizes and position
Changed in gtg:
status: Fix Committed → Confirmed
Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Fixed in rev. 396

Signal on_move was lost with GtkBuilder transition

Changed in gtg:
status: Confirmed → Fix Committed
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.