(jaunty) Text hidden on "Who are you?" step

[Juanje Ojeda]

Binary package hint: ubiquity

I'm testing Ubuntu Jaunty daily-build from 01-Apr-2009 and I've started it in Spanish.

When I arrive to the "Who are you?" step I found there are some strings (the autologin ones) which were there before but now doen't show up.

But when I choose one autologin option, then all hidden texts show up.

I attacth 2 screenshots. The first is before the click and the second, just after.

I believe the problem comes from the change on revision 3136[1], because it changed som autologin stuff in gtk_ui.py, but I didn't check well yet.

[1] http://bazaar.launchpad.net/~ubuntu-installer/ubiquity/trunk/revision/3136

[Juanje Ojeda (juanje)]

There is also part of the comment for the second question which was hidden and suddenly showed up when the click was done.

[Juanje Ojeda (juanje)]

I've just comfirmed that it also happends in English version, not just with Spanish translations

[Colin Watson (cjwatson)]

I see this too, but I haven't yet worked out what's going on ...

[Colin Watson (cjwatson)]

By the way, surely r3136 changed autopartitioning, not autologin?

[Juanje Ojeda (juanje)]

Yes, I think I was wrong with the revision. I was looking for any changes on autologin at the logs and it showed up, but after I got a better look and I think it's not there...

I'm still looking...

[Martin Pitt (pitti)]

Robert, can you please take a look at this? This looks like a GTK quirk, and Colin doesn't get further with this.

2009 Apr 03 17:21:10 <cjwatson> I've reproduced it, it's just a mystery. The radio button labels are blank until you select one of them

[Colin Watson (cjwatson)]

This doesn't appear to reproduce by simply loading up /usr/share/ubiquity/glade/stepUserInfo.glade in Python.

[Robert Ancell (robert-ancell)]

It does appear to be a GTK+ quirk that is being triggered by translate_widget(). It occurs when the label is set for the GtkRadioButtons. This can be proven by skipping this step for widgets which start with 'login_', i.e.
            if not widget.get_name().startswith('login_'):
                widget.set_label(text)

I haven't yet been able to reproduce this in a simple test case yet. My guess is that setting the radio button labels while they are not visible (they are on a different tab) is not rendering the label when they become visible. As reported the labels get rendered when clicked on.

Note also the attached screenshots show one of the labels being truncated - not sure if this is related, I think it is a long-standing GTK+ bug but I haven't got the bug number handy.

[Robert Ancell (robert-ancell)]

It appears to be on the second translate that the problem occurs.
1. Hack ubiquity.glade to add tabs to the notebook

2a. Start ubiquity and change to page 7. The RadioButtons have been translated once and have the labels showing. Return to page 2 and continue.
3a. During the transition to page 3 the widgets are all retranslated
4a. When page 7 is reached it will show the RadioButtons with labels

2b. Start uniquity. Do not view page 7.
3b. During the transition to page 3 the widgets are all retranslated
4b. When page 7 is reached it will show the RadioButtons *without* labels

It appears that setting the RadioButton labels a second time without them having being realized causes them not to be re-rendered. Still haven't reproduced in a simple test case.

[Robert Ancell (robert-ancell)]

Added a branch with a proposed workaround:
lp:~robert-ancell/ubiquity/trunk

This calls widget.realize() after the label has been updated and causes the labels to be displayed correctly.

[Robert Ancell (robert-ancell)]

I don't know if the bzr change is useful (it required a 40M upload to push). The changes are:
=== modified file 'debian/changelog'
--- debian/changelog 2009-04-06 18:47:37 +0000
+++ debian/changelog 2009-04-07 07:19:48 +0000
@@ -1,3 +1,9 @@
+ubiquity (1.12.4ubuntu1) jaunty; urgency=low
+
+ * Workaround for radio button labels dissapearing (LP: #353090)
+
+ -- Robert Ancell <email address hidden> Tue, 07 Apr 2009 17:18:57 +1000
+
 ubiquity (1.12.4) jaunty; urgency=low

   [ Colin Watson ]

=== modified file 'ubiquity/frontend/gtk_ui.py'
--- ubiquity/frontend/gtk_ui.py 2009-04-03 11:43:26 +0000
+++ ubiquity/frontend/gtk_ui.py 2009-04-07 07:21:21 +0000
@@ -722,6 +722,11 @@

             question = i18n.map_widget_name(widget.get_name())
             widget.set_label(text)
+
+ # Workaround for radio button labels dissapearing on second
+ # translate when not visible. LP: #353090
+ widget.realize()
+
             if question.startswith('ubiquity/imported/'):
                 stock_id = question[18:]
                 widget.set_use_stock(False)

[Colin Watson (cjwatson)]

Thanks! That seems like a viable workaround. (And the bzr branch seems fine, so I'll just merge that.)

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubiquity - 1.12.5

---------------
ubiquity (1.12.5) jaunty; urgency=low

  [ Robert Ancell ]
  * GTK frontend:
    - Workaround for radio button labels disappearing (LP: #353090).

  [ Colin Watson ]
  * KDE frontend:
    - Fix typo in installation_medium_mounted handler (LP: #354515).
  * Automatic update of included source packages: user-setup 1.23ubuntu17.

 -- Colin Watson <email address hidden> Wed, 08 Apr 2009 02:29:12 +0100

[Paul Larson (pwlars)]

Confirmed fixed in todays build

[Adric Riedel (adric-riedel)]

This problem showed up in the Kubuntu Karmic Desktop install CD. There were, in a few places, not enough space for the lines of text the system tried to display.