Please sync urwid 0.9.8.4-1 (universe) from Debian unstable (main)

Bug #343347 reported by Ian Ward
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
urwid (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: python-urwid

Sending invalid data to a widget keypress method (not checking for mouse event for example) causes python-urwid to segfault. I expected a python error that can be handled gracefully.

python-urwid is version 0.9.8.3-1ubuntu1 in jaunty.
Fix is in upstream version 0.9.8.4-1 (debian unstable)
A number of other minor problems have been fixed in the same release.

This is the changelog for this micro-release:
    * Fixed incompatibilities with Python 2.6 (by Friedrich Weber)
    * Fixed a SimpleListWalker? with emptied list bug (found by Walter Mundt)
    * Fixed a curses_display stop()/start() bug (found by Christian Scharkus)
    * Fixed an is_wide_character() segfault on bad input data bug (by Andrew Psaltis)
    * Fixed a CanvasCache? with render() used in both a widget and its superclass bug (found by Andrew Psaltis)
    * Fixed a ListBox?.ends_visible() on empty list bug (found by Marc Hartstein)
    * Fixed a tutorial example bug (found by Kurtis D. Rader)
    * Fixed an Overlay.keypress() bug (found by Andreas Klöckner)
    * Fixed setuptools configuration (by Andreas Klöckner)

All changes are strictly bug fixes, there are no new features in this release. This package has been built and tested on Debian unstable and has been accepted into Debian.

Ian Ward (ian-excess)
description: updated
description: updated
Ian Ward (ian-excess)
Changed in urwid:
status: New → Fix Released
Ian Ward (ian-excess)
Changed in urwid:
status: Fix Released → New
Revision history for this message
Ian Ward (ian-excess) wrote :

I have tested this release against all the example programs included and the unit and doctests in the source.

build logs are here: https://launchpad.net/~ian-excess/+archive/ppa/+sourcepub/5238

Changed in urwid (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Savvas Radevic (medigeek) wrote :

Nathan, so there's no need for merge? Cool! :)

Revision history for this message
Nathan Handler (nhandler) wrote :

Savvas, I did not look over the changes. It just looked like he was requesting a sync. He also built 0.9.8.4-1 in his PPA. If the Ubuntu changes are still needed, please attach the necessary debdiffs and update the title.

Revision history for this message
Savvas Radevic (medigeek) wrote : Re: [Bug 343347] Re: Please sync urwid 0.9.8.4-1 (universe) from Debian unstable (main)

No changes left, the patch for python 2.6 compatibility has been
applied upstream! (yay :) )

Revision history for this message
Ian Ward (ian-excess) wrote :

I've attached one patch you might want to include. It is from the latest stable branch:
https://excess.org/hg/urwid-0.9.8/rev/445847075567

Revision history for this message
Alessio Treglia (quadrispro) wrote :

 status inprogress
 assignee quadrispro

--
Alessio Treglia <email address hidden>
Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com
0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0

Changed in urwid:
assignee: nobody → quadrispro
status: New → In Progress
Revision history for this message
Alessio Treglia (quadrispro) wrote :

Hi guys, thanks for your work!

 status confirmed
 assignee nobody
 subscribe ubuntu-archive
 unsubscribe ubuntu-universe-sponsors

Package builds fine, sync request ACK'd.

That patch only suppress a warning, it's not a sufficient reason to maintain a delta between Ubuntu and Debian.

However, please submit the patch to Debian BTS, we'll sync it later.

--
Alessio Treglia <email address hidden>
Ubuntu MOTU Developer | Homepage: http://www.alessiotreglia.com
0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0

Changed in urwid:
assignee: quadrispro → nobody
status: In Progress → Confirmed
Revision history for this message
Ian Ward (ian-excess) wrote :

Debian won't be using python2.6 for some time(?), so the patch is only really useful for Ubuntu users. The patch will be included in the next Urwid release, so there is nothing to maintain.

Revision history for this message
Steve Langasek (vorlon) wrote :

python2.6 is already present in experimental for Debian.

I disagree that getting rid of python warnings isn't a reason to maintain a Debian delta; a number of command-line python programs are still quite a mess in jaunty due to deprecation warnings. I'm going ahead for now since this is a proper sync request, but I would encourage you to fix this warning for jaunty anyway.

Revision history for this message
Steve Langasek (vorlon) wrote :

[Updating] urwid (0.9.8.3-1ubuntu2 [Ubuntu] < 0.9.8.4-1 [Debian])
 * Trying to add urwid...
  - <urwid_0.9.8.4-1.dsc: downloading from http://ftp.debian.org/debian/>
  - <urwid_0.9.8.4-1.diff.gz: downloading from http://ftp.debian.org/debian/>
  - <urwid_0.9.8.4.orig.tar.gz: downloading from http://ftp.debian.org/debian/>
I: urwid [universe] -> python-urwid_0.9.8.3-1ubuntu2 [universe].

Changed in urwid:
status: Confirmed → Fix Released
Revision history for this message
Savvas Radevic (medigeek) wrote : Re: [Bug 343347] Re: Please sync urwid 0.9.8.4-1 (universe) from Debian unstable (main)

Hello, I'll try and look at it again, perhaps there's a possible
backwards/future compatible way to fix it. :-)

On 3/23/09, Steve Langasek <email address hidden> wrote:
> [Updating] urwid (0.9.8.3-1ubuntu2 [Ubuntu] < 0.9.8.4-1 [Debian])
> * Trying to add urwid...
> - <urwid_0.9.8.4-1.dsc: downloading from http://ftp.debian.org/debian/>
> - <urwid_0.9.8.4-1.diff.gz: downloading from
> http://ftp.debian.org/debian/>
> - <urwid_0.9.8.4.orig.tar.gz: downloading from
> http://ftp.debian.org/debian/>
> I: urwid [universe] -> python-urwid_0.9.8.3-1ubuntu2 [universe].
>
>
> ** Changed in: urwid (Ubuntu)
> Status: Confirmed => Fix Released
>
> --
> Please sync urwid 0.9.8.4-1 (universe) from Debian unstable (main)
> https://bugs.launchpad.net/bugs/343347
> You received this bug notification because you are a direct subscriber
> of the bug.
>

--
Sent from my mobile device

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.