Woda 4.603 is not compatible with perl 5.10

Bug #342308 reported by Xavier Brochard
2
Affects Status Importance Assigned to Milestone
Woda
Fix Released
High
Xavier Brochard

Bug Description

There is pieces of code in Woda that are not compatible with Perl 5.10:
$*, which was deprecated in favor of the /s and /m regexp modifiers, has been removed.

These functions has changed a bit and should be checked:
pack() has change regarding UTF-8 encoded data
chdir FOO A bareword argument to chdir() is now recognized as a file handle. Earlier releases interpreted the bareword as a directory name.

for the complete list of changes see
http://search.cpan.org/dist/perl-5.10.0/pod/perl5100delta.pod

Woda functions used with $*
----------------------------------------
- $* used to call a function to extend its regexp to multiline
htParseMulti()
htParseSimple()

- $* in the function
formatHtm2Txt()
FETCH()
cgiHtml()

- functions called with both multiline ($*) and single line
recFromRow()
    called by wbGrepRecords() with multiline
evalSafe()
    called by wbGrepRecords() and recValidate() with multiline
printHead()
   called by cgiHtml with multiline

Related branches

Revision history for this message
Xavier Brochard (xavier) wrote :

French explanation of what is new in perl 5.10
http://www.unixgarden.com/index.php/news/les-nouveautes-de-perl-510-–-premiere-partie

Changed in woda:
importance: Undecided → High
description: updated
Xavier Brochard (xavier)
Changed in woda:
assignee: nobody → xavier
status: New → In Progress
Revision history for this message
Xavier Brochard (xavier) wrote :

I've added /m in regexp and removed $* into these functions:
- sub run
- htParseMulti()
- htParseSimple()
- formatHtm2Txt()
- FETCH()
- cgiHtml()

TODO
sub wbGrepRecords, sub recValidate
and functions called with both multiline ($*) and single line, i.e. recFromRow() and evalSafe()

Revision history for this message
Xavier Brochard (xavier) wrote :

partialy done, ok for most cases of use

Changed in woda:
milestone: none → merge-mf-and-xavier
Revision history for this message
Xavier Brochard (xavier) wrote :

don't forget to check also release files, i.e. 1TRANS, 2SPLIT, etc. Thoses files makes heavy use of $*

Revision history for this message
Xavier Brochard (xavier) wrote :

multiline calls of functions:
recFromRow
             called in multiline by wbGrepRecords
             why? I don't understand

evalSafe
            called in multiline by recValidate

all other calls are singleline

Revision history for this message
Xavier Brochard (xavier) wrote :

in xavier4.620 branch

Changed in woda:
milestone: merge-mf-and-xavier → none
status: In Progress → Fix Committed
Xavier Brochard (xavier)
Changed in woda:
milestone: none → merge-with-pro
Xavier Brochard (xavier)
Changed in woda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.