test_walkdirs_os_error not robust

[James Westby]

I get:

FAIL: test_osutils.TestWalkDirs.test_walkdirs_os_error
    not equal:
a = "[Errno 13] Permission denied: './test-unreadable'"
b = "[Errno 13] chdir: Permission denied: './test-unreadable'"

perhaps because of a different python or glibc or similar.

Thanks,

James

[Vincent Ladeuil (vila)]

This is triggered as soon as the C extensions are not built.
Anyway, testing e.errno should achieve the same result while being less fragile.

[Martin Pool (mbp)]

The point of this test is to check the string representation includes the filename, which was bug 338653. So please make sure that's still in there after this change.

[Martin Pool (mbp)]

but you're right that the message is inconsistent about including 'chdir' or not depending on whether the extensions are up to date, so the test should probably match using a regexp or something.

[Vincent Ladeuil (vila)]

Sorry about that, fix submitted to pqm including an explicit check that the filename appears in the stringified exception.