checkwatches.py doesn't handle http -> https redirects
Bug #34102 reported by
Björn Tillenius
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Jeroen T. Vermeulen |
Bug Description
If a bugzilla bug tracker automatically redirects http requests to https, and the bug tracker's base URL in Launchpad is http://
We should address this issue somehow, I think we can define our own redirect handler for urllib2, which will POST the form data to the new page, if it's only a http -> https redirect.
Related branches
lp:~jtv/launchpad/bug-34102
- Graham Binns (community): Approve (code)
-
Diff: 366 lines (+188/-42)7 files modifiedlib/lp/bugs/doc/bugsubscription.txt (+5/-2)
lib/lp/bugs/doc/externalbugtracker-bugzilla.txt (+1/-1)
lib/lp/bugs/externalbugtracker/base.py (+22/-8)
lib/lp/bugs/externalbugtracker/bugzilla.py (+44/-25)
lib/lp/bugs/externalbugtracker/tests/test_bugzilla.py (+57/-0)
lib/lp/bugs/externalbugtracker/tests/test_externalbugtracker.py (+57/-4)
lib/lp/bugs/tests/externalbugtracker.py (+2/-2)
Changed in malone: | |
assignee: | nobody → bjornt |
Changed in malone: | |
assignee: | Björn Tillenius (bjornt) → nobody |
Changed in launchpad: | |
importance: | Low → Critical |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Working around this is pretty trivial; just update the bugtracker URL.