Patch: Adds preliminary ipod support to 0.2.99.1
Bug #331047 reported by
andy_js
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Exaile |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The patch adds support to the latest Exaile for multiple iPods with auto-detection.
Syncing/Downloading is not implemented (and I don't think sinking should be implemented personally: leave it to Conduit).
Playback works great and downloading tracks from the ipod should work but I've not tried it.
Auto-detection is not fully implemented so you must connect any ipods before starting Exaile, but its a start.
Changed in exaile: | |
milestone: | none → 0.3.0 |
Changed in exaile: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
A few things I noticed:
1) You need to re-work your autodetection so that it uses the infrastructure established in xl/hal.py (see the massstorage plugin for an example).
2) You should pass the raw iPod name to the Device __init__ so it can handle name collisions for you (again, see massstorage).
3) I'm not entirely sure it's a good idea to actually unmount the iPod from inside Exaile, since the user might still want to do something with it (like transfer videos or pictures via another program), or the umount could fail unexpectedly causing Exaile to behave unexpectedly as disconnect() failed partway through. Perhaps this would be best left unimplemented for now, and revisited when we get a full device management UI (probably in 0.3.1).
Aside from those issues, the code looks very good.