Numpad Enter from BibNo in Results moves activity to FirstName

[Ken McLean]

Enter from BibNo in Results moves activity to FirstName. Doing the same with tab moves activity to AgeGroup.

[Craig Mahony (cmahony)]

Fixed.

[Ken McLean (kenmclean)]

This is still happening. Hitting enter doesn't jump to AgeGroup, like tab does.

[Craig Mahony (cmahony)]

This is working for me now. Possibly Tudor needs to port over my branch version.

[Craig Mahony (cmahony)]

I have tested this bug on the nightly build from 1/5/09 and it works fine on both my XP PC and on my Vista UX.

[Ken McLean (kenmclean)]

This is not fixed.

When I enter a BibNo in results, if i hit ENTER is moved the focus to Firstname. If I hit TAB instead the focus is moved to AgeGroup.

[Craig Mahony (cmahony)]

What version are you using and what OS? On version 20080501 it works fine on
three different PCs i had tried.

The code has a trap for TAB and ENTER which should move the cursor to field
6(starting at zero). So I am not sure why it will not wrk for you.

Craig
----- Original Message -----
From: "Ken McLean" <email address hidden>
To: <email address hidden>
Sent: Thursday, May 07, 2009 3:00 PM
Subject: [Bug 326118] Re: Enter from BibNo in Results moves activity
toFirstName

This is not fixed.

When I enter a BibNo in results, if i hit ENTER is moved the focus to
Firstname. If I hit TAB instead the focus is moved to AgeGroup.

** Changed in: openscore
       Status: Confirmed => Triaged

--
Enter from BibNo in Results moves activity to FirstName
https://bugs.launchpad.net/bugs/326118
You received this bug notification because you are a bug assignee.

Status in OpenScore: Triaged

Bug description:
Enter from BibNo in Results moves activity to FirstName. Doing the same with
tab moves activity to AgeGroup.

[Ken McLean (kenmclean)]

OpenScore-Nightly-Windows-x86-0.1-20090507

Windows XP Professional

[Ken McLean (kenmclean)]

In fact, I just tested it again, and started getting Nullpointers:

16:57:39.187:INFO :New composite added.
16:57:44.078:INFO :Added CompetitorResult[4437] object to MODIFIED queue.
16:57:44.078:INFO :CompetitorResult[4437] came from storage, so not adding to any queue.
16:57:44.078:INFO :Ignored because incorrect gender or no DOB. LACHLAN GEORGE
16:57:44.078:Last message repeated 5 times.
16:57:44.078:INFO :Constraint filter Accepted LACHLAN GEORGE into M16
16:57:44.078:INFO :Ignored because incorrect gender or no DOB. LACHLAN GEORGE
16:57:44.078:Last message repeated 5 times.
16:57:44.078:INFO :Constraint filter Accepted LACHLAN GEORGE into M16
16:57:44.078:Last message repeated 2 times.
16:57:44.078:INFO :Results filter Accepted GEORGE, LACHLAN into M16
java.lang.NullPointerException
        at avscoreswt.gui.ResultsEditSupport.setValue(ResultsTable.java:1814)
        at org.eclipse.jface.viewers.EditingSupport.saveCellEditorValue(EditingSupport.java:109)
        at org.eclipse.jface.viewers.ColumnViewerEditor.saveEditorValue(ColumnViewerEditor.java:454)
        at org.eclipse.jface.viewers.ColumnViewerEditor.applyEditorValue(ColumnViewerEditor.java:311)
        at org.eclipse.jface.viewers.ColumnViewerEditor.handleEditorActivationEvent(ColumnViewerEditor.java:438)
        at org.eclipse.jface.viewers.ColumnViewer.triggerEditorActivationEvent(ColumnViewer.java:680)
        at org.eclipse.jface.viewers.ColumnViewerEditor.processTraverseEvent(ColumnViewerEditor.java:559)
        at org.eclipse.jface.viewers.ColumnViewerEditor$5.keyTraversed(ColumnViewerEditor.java:248)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:241)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1027)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1012)
        at org.eclipse.swt.widgets.Control.traverse(Control.java:3499)
        at org.eclipse.swt.widgets.Control.translateTraversal(Control.java:3481)
        at org.eclipse.swt.widgets.Display.translateTraversal(Display.java:4358)
        at org.eclipse.swt.widgets.Display.filterMessage(Display.java:1198)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3418)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
        at org.eclipse.jface.window.Window.open(Window.java:801)
        at avscoreswt.gui.BaseFrame.run(BaseFrame.java:183)
        at avscoreswt.gui.BaseFrame.start(BaseFrame.java:986)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at avscoreswt.OpenScore.main(OpenScore.java:57)
java.lang.NullPointerException
        at avscoreswt.gui.ResultsEditSupport.setValue(ResultsTable.java:1814)
        at org.eclipse.jface.viewers.EditingSupport.saveCellEditorValue(EditingSupport.java:109)
        at org.eclipse.jface.viewers.ColumnView...

[Craig Mahony (cmahony)]

I have fixed the NullPointerException and committed to the Cranbourne branch. IThe NPE may have been getting in the way, but it should not have unless a competitor was selected who was missing a first name. The code to move to the age group column is there for bothe TAB and ENTER. It has been for some time. Tudor will need to port this section of code from the ResultsTable class into the main branch.

[Ken McLean (kenmclean)]

This is confirmed for the numpad enter key only, hence the mixup. The standard enter/return key works the same as tab. The Enter on the numpad doesn't work

[Ken McLean (kenmclean)]

Brought forward to heatwave

[Craig Mahony (cmahony)]

Done. The keyCode, in swt at least, for KeyPad 'enter' was 16777296 not 13 as on the main keyboard.

[Ken McLean (kenmclean)]

Sorry, but this is still not fixed. I reckon you should take a usb numpad home to test this out Craig.

[Craig Mahony (cmahony)]

Think this is fixed now. I did put n a correction for the Numpad but only in the perf field. I had to include it in the bibno field. Elsewhere it seems to work ok.

However, I found in doing all this that hitting enter when the bibno was blank the putting in a number when the focus did not move created some weird behaviour because the editor became deactivated. Think this is also fixed now but please test.

I have only put the numpad enter in the resultsTable gui since I thought in the others that text was needed so a keyboard would be in use. If you think I need to put it elsewhere as well please indicate where.

[Ken McLean (kenmclean)]

I was just thinking about this yesterday. When you hit enter when the BibNo is blank, it triggers and error and loses focus. You then hit enter again and the BibNo has focus again.

I understand this was done to force people to enter the correct BibNo, and I think we should do it when you enter a bibno and it does not match with an actual Bibno.

However, I think when you do not add a BibNo (blank) focus should move to the FirstName column. This is because if you do not know the BibNo, you want to be able to use the Lookup function to find your competitor.

So, if I need to enter in a competitor and I ask for their surname, I would hit enter (from Station to BibNo), enter, enter, type in "McLean" and find "Ken McLean" in the lookup.

This means up until this point I do not have to use a mouse.

Is it possible to do this? Sorry, I know it's a pain. We can list it as a new bug for the next milestone if you prefer. It's not incredibly urgent.

[Craig Mahony (cmahony)]

That would actually make it easier as yesterday I had to put code in to stop
some strange behaviour happening. I will check with Tudor on what our
'policy' for this situation should be.

Craig
----- Original Message -----
From: "Ken McLean" <email address hidden>
To: <email address hidden>
Sent: Sunday, August 16, 2009 10:31 AM
Subject: [Bug 326118] Re: Numpad Enter from BibNo in Results moves activity
toFirstName

I was just thinking about this yesterday. When you hit enter when the
BibNo is blank, it triggers and error and loses focus. You then hit
enter again and the BibNo has focus again.

I understand this was done to force people to enter the correct BibNo,
and I think we should do it when you enter a bibno and it does not match
with an actual Bibno.

However, I think when you do not add a BibNo (blank) focus should move
to the FirstName column. This is because if you do not know the BibNo,
you want to be able to use the Lookup function to find your competitor.

So, if I need to enter in a competitor and I ask for their surname, I
would hit enter (from Station to BibNo), enter, enter, type in "McLean"
and find "Ken McLean" in the lookup.

This means up until this point I do not have to use a mouse.

Is it possible to do this? Sorry, I know it's a pain. We can list it as
a new bug for the next milestone if you prefer. It's not incredibly
urgent.

--
Numpad Enter from BibNo in Results moves activity to FirstName
https://bugs.launchpad.net/bugs/326118
You received this bug notification because you are a bug assignee.

Status in OpenScore: Fix Committed

Bug description:
Enter from BibNo in Results moves activity to FirstName. Doing the same with
tab moves activity to AgeGroup.