PostgreSQL string quoting type detection spams error logs
Bug #322206 reported by
Stuart Bishop
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Storm |
Fix Released
|
Medium
|
Stuart Bishop |
Bug Description
With the PostgreSQL backend, Storm detects what sort of string quoting mechanism to use by issuing a test query that possibly fails and issuing a rollback. This generates false error messages in PostgreSQL logs.
2009-01-28 14:43:27 ICT LOG: statement: SHOW server_version
2009-01-28 14:43:27 ICT LOG: statement: SELECT EE''
2009-01-28 14:43:27 ICT ERROR: type "ee" does not exist at character 8
2009-01-28 14:43:27 ICT STATEMENT: SELECT EE''
2009-01-28 14:43:27 ICT LOG: statement: ROLLBACK
We should be able to detect the quoting mechanism to use better, and make DBAs and their log analysis and fault monitoring systems happier.
Related branches
lp:~stub/storm/bug-322206
- Thomas Herve (community): Approve
- James Henstridge: Approve
- Diff: 111 lines
Changed in storm: | |
importance: | Undecided → Medium |
Changed in storm: | |
status: | New → In Progress |
Changed in storm: | |
milestone: | none → 0.15 |
Changed in storm: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think current versions of psycopg2 handle this properly, so one fix would be to add a minimum version requirement for psycopg2 to Storm and remove the workaround code.
Given the number of bugs in ancient versions of psycopg2, this is probably a good idea anyway.