Empathy tabs apperance is ugly (return back upstream version)

[Joe_Bishop]

See the shots below: the first shot contains upstream-like version, the second is the latest ubuntu.
This appearance is ugly and inconsistent (only gnome-terminal have similar behaviour - and I prefer not to use tabs there). And I hate this blue color in message titles.

[Chris Coulson (chrisccoulson)]

It's not obvious what the issue is here. The only difference I can see between the 2 screenshots is that the tabs expand to fill the available horizontal space in the bottom one.

[Joe_Bishop (denis-cheremisov-gmail)]

Oops, yes. In upstream version tab only fits contact name, whereas in new
Ubuntu's (2.25.4) they fill a whole tab bar.

2009/1/22 Chris Coulson <email address hidden>

> It's not obvious what the issue is here. The only difference I can see
> between the 2 screenshots is that the tabs expand to fill the available
> horizontal space in the bottom one.
>
> ** Changed in: empathy (Ubuntu)
> Status: New => Incomplete
>
> --
> Empathy tabs apperance is ugly (return back upstream version)
> https://bugs.launchpad.net/bugs/319969
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Chris Coulson (chrisccoulson)]

If there is a difference in appearance between 2.25.4 upstream and 2.25.4 in Ubuntu, then that's not an empathy problem as there is only a single patch to the upstream source, which has nothing to do with this.

[Chris Coulson (chrisccoulson)]

Actually, that last comment doesn't make much sense. Are those 2 screenshots from exactly the same environment? (same PC, same libraries etc)

[Chris Coulson (chrisccoulson)]

Right, I just had a look at the changelog. 2.25.4-1ubuntu1 dropped a patch affecting tabs (01fixtabbehavour.diff), which actually returned it to the upstream behaviour.

[Xavier Claessens (zdra)]

Ubuntu added a patch in previous packages to make tab only use the width the contact name. This patch was droped in latest package to come back to the upstream behaviour.

See upstream bug: http://bugzilla.gnome.org/show_bug.cgi?id=548260

In short the answer is there is not convention at all, each program does different things...

[Chris Coulson (chrisccoulson)]

Thanks Xavier. So, the answer is that the new Jaunty version actually uses the upstream behaviour (tabs fill the whole width of the window - screenshot 2), and the patch that Ubuntu originally carried to make the behaviour different (screenshot 1) to the upstream behaviour has not been accepted upstream, so Ubuntu dropped it.

Marking this as Won't Fix

[Joe_Bishop (denis-cheremisov-gmail)]

Lol, one guy from Empaty bugtracker said me Empathy 2.24 from Ubuntu 8.10 is
the default behaviour.
Then old Ubuntu 8.10 look is much better - do not follow upstream, please
lol.

2009/1/22 Chris Coulson <email address hidden>

> Thanks Xavier. So, the answer is that the new Jaunty version actually
> uses the upstream behaviour (tabs fill the whole width of the window -
> screenshot 2), and the patch that Ubuntu originally carried to make the
> behaviour different (screenshot 1) to the upstream behaviour has not
> been accepted upstream, so Ubuntu dropped it.
>
> Marking this as Won't Fix
>
> ** Changed in: empathy (Ubuntu)
> Status: Incomplete => Won't Fix
>
> --
> Empathy tabs apperance is ugly (return back upstream version)
> https://bugs.launchpad.net/bugs/319969
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Joe_Bishop (denis-cheremisov-gmail)]

Lol, one guy from Empaty bugtracker said me Empathy 2.24 from Ubuntu 8.10 is the default behaviour.
Then old Ubuntu 8.10 look is much better - do not follow upstream, please lol.

[Bruce Cowan (bruce89-deactivatedaccount)]

There is a precedent in gnome-terminal, and even Pidgin. Having as small a diff from upstream is a good thing too.