broken "linux" link in kernel headers

[Tormod Volden]

linux-headers-2.6.28-4-generic: /usr/src/linux-headers-2.6.28-4-generic/include/linux/linux
lrwxrwxrwx 1 root root 42 2009-01-07 22:39 linux -> ../../linux-headers-2.6.28-4/include/linux

Looks like a link was created after a directory of the same name had been created, although there shouldn't be a link in this case.

[Ben Collins (ben-collins)]

Looks like changes in .28's headers has caused our linking to do something wrong...checking into it.

[Andy Whitcroft (apw)]

Ok so there are actually two directories which are broken in the header packages:

    -lrwxrwxrwx root/root 0 2009-02-25 17:11 ./usr/src/linux-headers-2.6.28-8-generic/include/linux/linux -> ../../linux-headers-2.6.28-8/include/linux
    -lrwxrwxrwx root/root 0 2009-02-25 17:11 ./usr/src/linux-headers-2.6.28-8-generic/include/asm-x86/asm-x86 -> ../../linux-headers-2.6.28-8/include/asm-x86

These are caused by the sweep over the header to ensure we do have all the directories. This fails to check if we actually do, checking only if the file exists. Where the directory was already made due to a contained file, then we miss it and create the link triggering bogus links above.

Seems simple to fix. Patch attached. Will push to the kernel-team.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 2.6.28-9.29

---------------
linux (2.6.28-9.29) jaunty; urgency=low

  [ Andy Whitcroft ]

  * link-headers -- only link directories which do not already exist
    - LP: #315252

  [ Daniel Marjamäki ]

  * SAUCE: (drop after 2.6.28) netxen: fix memory leak in
    drivers/net/netxen_nic_init.c
    - LP: #330813

  [ Dhananjay Phadke ]

  * SAUCE: (drop after 2.6.28) netxen: fix endianness in firmware commands
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: fix ipv6 offload and tx cleanup
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: fix link speed reporting for some
    boards
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: firmware init fix
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: cleanup mac list on driver unload
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: hold tx lock while sending firmware
    commands
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: handle dma mapping failures
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: avoid invalid iounmap
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: include ipv6.h (fixes build failure)
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: fix vlan tso/checksum offload
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: reduce memory footprint
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: revert jumbo ringsize
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: fix msi-x interrupt handling
    - LP: #330813
  * SAUCE: (drop after 2.6.28) netxen: remove pcie workaround
    - LP: #330813

  [ Hannes Eder ]

  * SAUCE: (drop after 2.6.28) drivers/net/netxen: fix sparse warnings: use
    NULL pointer instead of plain integer
    - LP: #330813

  [ Huaxu Wan ]

  * SAUCE: report rfkill changes event if interface is down
    - LP: #193970

  [ Tim Gardner ]

  * MV78XX0 must specify a target in the vars definition.

  [ Upstream Kernel Changes ]

  * Revert "ext4: wait on all pending commits in ext4_sync_fs()"
  * jbd2: Fix return value of jbd2_journal_start_commit()
  * jbd2: Avoid possible NULL dereference in
    jbd2_journal_begin_ordered_truncate()
  * ext4: Fix to read empty directory blocks correctly in 64k
  * ext4: Fix lockdep warning
  * ext4: Initialize preallocation list_head's properly
  * ext4: Implement range_cyclic in ext4_da_writepages instead of
    write_cache_pages
  * ext4: Fix NULL dereference in ext4_ext_migrate()'s error handling
  * ext4: Add fallback for find_group_flex
  * ext4: Fix deadlock in ext4_write_begin() and ext4_da_write_begin()

  [ Brad Figg ]

  * Added mv78xx0 flavor

 -- Tim Gardner <email address hidden> Fri, 06 Mar 2009 06:13:31 -0700