project.cfg: remove COMPONENTS and SUBPROJECTS lists from [PROJECT] section and use explicit sections for components

Bug #314654 reported by Alexander Belchenko
4
Affects Status Importance Assigned to Milestone
ScmProj plugin
Fix Released
High
Alexander Belchenko

Bug Description

E.g.

[PROJECT]
...

[component "foo"]
BRANCHES = trunk dev

  [[branch "dev"]]

[subproject "spam"]
...

In this case PROJECT section could be optional too.

Related branches

Changed in bzr-scmproj:
importance: Undecided → High
status: New → Confirmed
Changed in bzr-scmproj:
assignee: nobody → bialix
Changed in bzr-scmproj:
status: Confirmed → In Progress
Revision history for this message
Marius Kruger (amanica) wrote :

Is there a reason why we have to quote the element names?
I think we can make the quoting optional or just not quote it.
eg.
[component foo]

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 314654] Re: project.cfg: remove COMPONENTS and SUBPROJECTS lists from [PROJECT] section and use explicit sections for components

Marius Kruger пишет:
> Is there a reason why we have to quote the element names?
> I think we can make the quoting optional or just not quote it.
> eg.
> [component foo]
>
Well, it was designed after git modules format.
http://www.kernel.org/pub/software/scm/git/docs/gitmodules.html

Perhaps we can omit quotes. I'm just found quotes easier to parse.
From other hand I've used very strict regex and allow only ASCII-alpha chars,
digits and minus and underscore signs. So quotes are not strictly needed
because space sign is not allowed.

I don't have strict opinion on this topic yet. Do you want to implement it?

Revision history for this message
Alexander Belchenko (bialix) wrote :

Alexander Belchenko пишет:
> Marius Kruger пишет:
>> Is there a reason why we have to quote the element names?
>> I think we can make the quoting optional or just not quote it.
>> eg.
>> [component foo]
>>
> Well, it was designed after git modules format.
> http://www.kernel.org/pub/software/scm/git/docs/gitmodules.html
>
> Perhaps we can omit quotes. I'm just found quotes easier to parse.
>>From other hand I've used very strict regex and allow only ASCII-alpha chars,
> digits and minus and underscore signs. So quotes are not strictly needed
> because space sign is not allowed.

OK, thinking further I'd say quotes should be optional but supported.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Alexander Belchenko пишет:
> Alexander Belchenko пишет:
>> Marius Kruger пишет:
>>> Is there a reason why we have to quote the element names?
>>> I think we can make the quoting optional or just not quote it.
>>> eg.
>>> [component foo]
>>>
>> Well, it was designed after git modules format.
>> http://www.kernel.org/pub/software/scm/git/docs/gitmodules.html
>>
>> Perhaps we can omit quotes. I'm just found quotes easier to parse.
>> >From other hand I've used very strict regex and allow only ASCII-alpha chars,
>> digits and minus and underscore signs. So quotes are not strictly needed
>> because space sign is not allowed.
>
> OK, thinking further I'd say quotes should be optional but supported.
>

I'll change this.

Changed in bzr-scmproj:
milestone: none → 0.4.5
Revision history for this message
Alexander Belchenko (bialix) wrote :

The code itself is almost ready to use, need to update the docs.

Revision history for this message
Alexander Belchenko (bialix) wrote :

doc is finished I guess. lp:~bialix/bzr-scmproj/format-change revno.180

Changed in bzr-scmproj:
status: In Progress → Fix Committed
Changed in bzr-scmproj:
milestone: 0.4.5 → 0.4.5a1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.