pump FTBFS

[Cesare Tirabassi]

Binary package hint: pump

pump FTBFS with the following message:

/build/buildd/pump-0.8.24/pump.c: In function 'runDaemon':
/build/buildd/pump-0.8.24/pump.c:558: error: ignoring return value of 'write', declared with attribute warn_unused_result
/build/buildd/pump-0.8.24/pump.c: In function 'openControlSocket':
/build/buildd/pump-0.8.24/pump.c:734: error: ignoring return value of 'read', declared with attribute warn_unused_result
/build/buildd/pump-0.8.24/pump.c:777: error: ignoring return value of 'chdir', declared with attribute warn_unused_result

This is due to Ubuntu using -D_FORTIFY_SOURCE=2 as a default gcc flag.

The following patch solves the problem, but I'd rather forward it upstream before committing (these are 1 byte read/write ops so there shouldn't be any need to retry).

[Brian Murray (brian-murray)]

Attached is a debdiff that will resolve this issue in Jaunty but it should still be forwarded upstream.

[Ilya Barygin (randomaction)]

Doesn't build in karmic:

cc -I/tmp/buildd/pump-0.8.24 -O2 -Ddebian -DUDEB=0 -I. -Wall -Werror -g -D__STANDALONE__ -DVERSION=\"\" -D_GNU_SOURCE -c -o dhcp.o /tmp/buildd/pump-0.8.24/dhcp.c
awk: cannot open pump.spec (No such file or directory)
cc1: warnings being treated as errors
/tmp/buildd/pump-0.8.24/dhcp.c: In function 'pumpPrepareInterface':
/tmp/buildd/pump-0.8.24/dhcp.c:370: error: dereferencing pointer 'addrp' does break strict-aliasing rules
/tmp/buildd/pump-0.8.24/dhcp.c:369: error: dereferencing pointer 'addrp' does break strict-aliasing rules
/tmp/buildd/pump-0.8.24/dhcp.c:366: error: dereferencing pointer 'addrp' does break strict-aliasing rules
/tmp/buildd/pump-0.8.24/dhcp.c:365: error: dereferencing pointer 'addrp' does break strict-aliasing rules
/tmp/buildd/pump-0.8.24/dhcp.c:364: note: initialized from here

[Ilya Barygin (randomaction)]

Updated debdiff (added -fno-strict-aliasing).

[Michael Terry (mterry)]

I pushed this in. Note that you shouldn't bother upstreaming the fix, as upstream (RedHat) is dead (in the sense that they don't work on it). It's also orphaned in Debian.

[Launchpad Janitor (janitor)]

This bug was fixed in the package pump - 0.8.24-5ubuntu1

---------------
pump (0.8.24-5ubuntu1) karmic; urgency=low

  [ Brian Murray ]
  * Resolve FTBFS on Jaunty because of -D_FORTIFY_SOURCE=2.
    Thanks to Cesare Tirabassi for the patch. (LP: #309848)

  [ Ilya Barygin ]
  * Build with -fno-strict-aliasing to fix FTBFS with gcc 4.4.

 -- Ilya Barygin <email address hidden> Tue, 13 Oct 2009 20:27:40 +0400