Typo in hooks/dmraid

[Chris Halse Rogers]

Binary package hint: dmraid

The update-initramfs dmraid hook dmraid installs in /usr/share/initramfs-tools/hooks/dmraid contains a typo. It references /etc/udev/rules.d/85_dmraid.rules, but dh_installudev installs this as 85-dmraid.rules.

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
NonfreeKernelModules: nvidia
Package: dmraid 1.0.0.rc15-1~exp1ubuntu1
ProcEnviron:
 PATH=/home/username/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_AU.UTF-8
 SHELL=/bin/zsh
SourcePackage: dmraid
Uname: Linux 2.6.28-2-generic x86_64

[Chris Halse Rogers (raof)]

Since I assume the error this raises in update-initramfs is harmful (at least for some users), here's a debdiff to fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dmraid - 1.0.0.rc15-1~exp1ubuntu2

---------------
dmraid (1.0.0.rc15-1~exp1ubuntu2) jaunty; urgency=low

  * debian/initramfs/dmraid.initramfs-hook/dmraid:
    + Fix name of udev rule; dh_installudev installs the file as
      85-dmraid.rules, not 85_dmraid.rules (LP: #306114)

 -- Christopher James Halse Rogers <email address hidden> Mon, 08 Dec 2008 11:52:16 +1100

[Giuseppe Iuculano (giuseppe-iuculano)]

This wasn't a typo, but a different dh_installudev naming schema in ubuntu/debian.

I fixed it in a different way:

# svn diff
Index: debian/changelog
===================================================================
--- debian/changelog (revisione 26)
+++ debian/changelog (copia locale)
@@ -4,8 +4,10 @@
   * debian/control:
     + Made the long description for the udeb shorter
     + Added initramfs-tools to dmraid Depends
- * debian/initramfs/dmraid.initramfs-hook/dmraid: Removed blank line added
- before the 'fi' in the dmraid initramfs-hook.
+ * debian/initramfs/dmraid.initramfs-hook/dmraid:
+ + Removed blank line added before the 'fi' in the dmraid initramfs-hook.
+ + check if 85_dmraid.rules or 85-dmraid.rules exists, and then copy it
+ (LP: #306114)
   * debian/patches/02_raid45_to_raid4-5.dpatch: Removed
   * debian/dmraid.postinst: initramfs-tools is in Depends, do not check for
     update-initramfs (fixed command-with-path-in-maintainer-script lintian
@@ -14,7 +16,7 @@
   * debian/patches/02_scsi_serial_remove_ws.dpatch: remove whitespace from
     serial id (LP: #305011)

- -- Giuseppe Iuculano <email address hidden> Fri, 05 Dec 2008 19:26:41 +0100
+ -- Giuseppe Iuculano <email address hidden> Mon, 08 Dec 2008 09:19:15 +0100

 dmraid (1.0.0.rc15-1~exp1) experimental; urgency=low

Index: debian/initramfs/dmraid.initramfs-hook/dmraid
===================================================================
--- debian/initramfs/dmraid.initramfs-hook/dmraid (revisione 25)
+++ debian/initramfs/dmraid.initramfs-hook/dmraid (copia locale)
@@ -24,7 +24,12 @@
  copy_exec /sbin/dmraid sbin
  copy_exec /sbin/dmraid-activate sbin
  mkdir -p ${DESTDIR}/etc/udev/rules.d
- cp -p /etc/udev/rules.d/85_dmraid.rules ${DESTDIR}/etc/udev/rules.d
+ if [ -f /etc/udev/rules.d/85_dmraid.rules ]; then
+ cp -p /etc/udev/rules.d/85_dmraid.rules ${DESTDIR}/etc/udev/rules.d
+ fi
+ if [ -f /etc/udev/rules.d/85-dmraid.rules ]; then
+ cp -p /etc/udev/rules.d/85-dmraid.rules ${DESTDIR}/etc/udev/rules.d
+ fi
 fi

 exit 0

[Giuseppe Iuculano (giuseppe-iuculano)]

To reduce the delta between Ubuntu and Debian, this bug should be fixed in a different way:

http://svn.debian.org/wsvn/dmraid-debian?op=comp&compare[]=%2F@26&compare[]=%2F@27

[Giuseppe Iuculano (giuseppe-iuculano)]

Fixed:
    + check if 85_dmraid.rules or 85-dmraid.rules exists, and then copy it
      (LP: #306114)