Launchpad itself

Codehosting VFS knows too much about which virtual paths are OK to remove

Bug #300551 reported by Jonathan Lange
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

The newly revised VFS code (see bug 272936) still assumes that virtual paths with three or fewer segments are virtual and thus cannot be deleted. This assumption should be removed.

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Curtis Hovey (sinzui)
tags: added: tech-debt
Jonathan Lange (jml)
visibility: private → public
Revision history for this message
Robert Collins (lifeless) wrote :

Why?

Changed in launchpad:
importance: Medium → Low
Revision history for this message
Jonathan Lange (jml) wrote :

First, it's the only thing in the codehosting vfs layer that has any Launchpad-specific assumptions. Everything else just delegates to translateVirtualPath.

Second, we have branch paths with five segments and this code handles it poorly.

I would solve this problem by just removing the ability to delete branches over the VFS.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.