Osmo crashes on contacts search

[Nacho Alonso]

In Ubuntu 8.10, Osmo crashes with a segmentation fault every time I try to search contacts unless the search does not return any contact. Searches worked fine in 8.04.

TEST CASE:
    1- Start Osmo with an empty contact list
    2- Add a new contact. Name it 'John'
    3- Click the search box
    4- Press 'j', Osmo crashes. If, for instance, you press 'a' instead of 'j' Osmo does not crash.

This bug only occurs with GTK+ >= 2.14 and has been fixed upstream in R619.

A minimal patch is:

--- a/src/contacts.c
+++ b/src/contacts.c
@@ -456,7 +456,7 @@
                 path = gtk_tree_path_new_first();
                 if (path != NULL) {
                     gtk_tree_view_set_cursor (GTK_TREE_VIEW (appGUI->cnt->contacts_list), path, NULL, FALSE);
- g_free(path);
+ gtk_tree_path_free(path);
                 }
             } else {
                 gui_clear_text_buffer (gtk_text_view_get_buffer(GTK_TEXT_VIEW(appGUI->cnt->contacts_desc_textview)), &titer);

[Eike Nicklas (eike-nicklas)]

Hi Nacho,

thanks for the report. I cannot reproduce this bug on Debian on amd64 and i386, will try to test on Ubuntu as soon as I have access to a suitable machine.

Which architecture (i386/amd64/ppc/...) are you using?

Have you used the official packages from the Ubuntu repositories? Have you tested version 0.2.4 from Jaunty? Have you tried the Debian packages (http://packages.debian.org/search?keywords=osmo)? When you talked about the last SVN version, have you compiled it yourself?

Sorry for all these questions, I am just trying to reproduce the bug...

Thanks for your help,
Eike

[Nacho Alonso (nacho-alonso-gonzalez)]

Sorry, I thought it would be so easy to reproduce I didn't even attach the terminal output. Here it is.

I have reproduced it with the official intrepid ibex package in a i686 architecture. Later I compiled myself the latest SVN revision. I have not tried version 0.2.4 from jaunty or the Debian package

In my opinion, this does not seem to be a bug in Osmo but in some library, since it affects versions of Osmo that worked before the upgrade.

Hope it helps

[Eike Nicklas (eike-nicklas)]

Sorry for the late reply. I finally have access to an Ubuntu machine and could also reproduce this bug. I will further investigate and let you know as soon as I find anything interesting. Thanks for reporting this issue!

[Eike Nicklas (eike-nicklas)]

I forwarded this bug upstream (see http://sourceforge.net/mailarchive/forum.php?thread_name=20081117234948.ee4567bd.eike%40ephys.de&forum_name=osmo-pim-friends).

This crash occurs only with GTK+ 2.14, but not with 2.12, what hopefully narrows down the possible sources of this bug...

[Eike Nicklas (eike-nicklas)]

This bug is fixed in upstream R619. I will backport the fix and upload as soon as possible.

[Nacho Alonso (nacho-alonso-gonzalez)]

Thank you. Eike

[Launchpad Janitor (janitor)]

This bug was fixed in the package osmo - 0.2.4-2

---------------
osmo (0.2.4-2) unstable; urgency=low

  * add osmo-dbg package
  * debian/patches:
    - add fix_gtk_crash.patch:
      fixes a crash with GTK+>=2.14 (Closes: LP: #296243)

 -- Ubuntu Archive Auto-Sync <email address hidden> Mon, 01 Dec 2008 08:17:30 +0000

[Eike Nicklas (eike-nicklas)]

I attached a debdiff against the osmo package in Intrepid. It uses quilt to apply the upstream patch to the source code. This way, the debdiff is not perfectly minimal any more, but I use this method in the current osmo package in Debian Unstable and Jaunty without problems and it makes managing patches a lot easier that applying them by hand. Hope this is acceptable.

[John Dong (jdong)]

Distribution should be intrepid-proposed, not intrepid. MOTU-SRU ACKs this debdiff provided that is fixed.

[John Dong (jdong)]

Thanks! Patch uploaded to Intrepid-proposed; awaiting approval.

[Martin Pitt (pitti)]

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

osmo (0.2.4-2) unstable; urgency=low

  * add osmo-dbg package
  * debian/patches:
    - add fix_gtk_crash.patch:
      fixes a crash with GTK+>=2.14 (Closes: LP: #296243)

 -- Ubuntu Archive Auto-Sync < <email address hidden>> Mon, 01 Dec 2008 08:17:30 +0000

[Eike Nicklas (eike-nicklas)]

Thanks for the upload, Martin! Tested the package from intrepid-proposed and it does not crash any more. Everything works fine here.

[Cesare Tirabassi (norsetto)]

Verification performed successfully.

[Launchpad Janitor (janitor)]

This bug was fixed in the package osmo - 0.2.0-1ubuntu0.1

---------------
osmo (0.2.0-1ubuntu0.1) intrepid-proposed; urgency=low

  * use quilt to manage patches
  * debian/patches:
    - add fix_gtk_crash.patch:
      fixes a crash with GTK+>=2.14 (LP: #296243)

 -- Eike Nicklas <email address hidden> Mon, 29 Nov 2008 12:34:42 +0100

[Colin Watson (cjwatson)]

Copied to intrepid-updates following successful verification.