crash when running auth-dialog and secret in keyring

[Alexander Sack]

Binary package hint: network-manager-pptp

Testcase:

/usr/lib/network-manager-pptp/nm-pptp-auth-dialog -u 1234 -n lalala -s org.freedesktop.NetworkManager.pptp

2. Enter some password
3. Check 'remember password for this session'
4. Press 'Ok'
5. ^C the program because it doesn't close for some reason
6. Run it again
7. Watch it crash and burn:

[Alexander Sack (asac)]

thanks for the great testcase in bug 284212. I dont think this crash causes all the issues there, but is definitly to fix.

[Alexander Sack (asac)]

ok, i plumbered a package out of it and uploaded to NM PPA:

 network-manager-pptp_0.7~~svn20081015t024626-0ubuntu2~nm3

[Clark Archer (clark-archer)]

Thanks Alexander. I just installed this version from PPA and can confirm that it fixes the issue and I can now save my VPN password in the keyring.

[Alexander Sack (asac)]

this seems to fix bug 284212 ... marking this bug as a duplicate of that one accordingly.

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-pptp - 0.7~~svn20081015t024626-0ubuntu2

---------------
network-manager-pptp (0.7~~svn20081015t024626-0ubuntu2) jaunty; urgency=low

  * LP: #259168 Network Manager unable to connect to PPTP VPN (bad NT-Domain
    escaping); we improve ppp domain in username encoding
    - add debian/patches/lp259168_ppp_nt_domain_escaping.patch
  * LP: #268667 MASTER - not all required ppp options get set on command line
    which makes ppp use bad values from /etc/ppp/options*; we explicitly set
    good values for: nodefaultroute, lcp-echo-failure and lcp-echo-interval
    - add debian/patches/lp268667_ppp_default_options.patch
  * LP: #292681 crash when running auth-dialog and secret in keyring;
    we use the proper memory functions in this patch (dupe-of LP: #284212
    VPN connection fails: "unable to find valid VPN secrets")
    - add debian/patches/lp_292681_keyring_memory_free.patch
  * LP: #290468 VPN fails, "/usr/bin/nm-ppp-starter missing"; we remove
    obsolete conffiles in .preinst now
    - add debian/network-manager-pptp.preinst

 -- Alexander Sack <email address hidden> Thu, 30 Oct 2008 00:22:51 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-pptp - 0.7~~svn20081015t024626-0ubuntu1.8.10.1

---------------
network-manager-pptp (0.7~~svn20081015t024626-0ubuntu1.8.10.1) intrepid-proposed; urgency=low

  * LP: #259168 Network Manager unable to connect to PPTP VPN (bad NT-Domain
    escaping); we improve ppp domain in username encoding
    - add debian/patches/lp259168_ppp_nt_domain_escaping.patch
  * LP: #268667 MASTER - not all required ppp options get set on command line
    which makes ppp use bad values from /etc/ppp/options*; we explicitly set
    good values for: nodefaultroute, lcp-echo-failure and lcp-echo-interval
    - add debian/patches/lp268667_ppp_default_options.patch
  * LP: #292681 crash when running auth-dialog and secret in keyring;
    we use the proper memory functions in this patch (dupe-of LP: #284212
    VPN connection fails: "unable to find valid VPN secrets")
    - add debian/patches/lp_292681_keyring_memory_free.patch
  * LP: #290468 VPN fails, "/usr/bin/nm-ppp-starter missing"; we remove
    obsolete conffiles in .preinst now
    - add debian/network-manager-pptp.preinst

 -- Alexander Sack <email address hidden> Thu, 30 Oct 2008 00:22:51 +0100