Browse button from Export show a GTK Dialog on Win32

Bug #292232 reported by Yann Papouin
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
theAdib

Bug Description

I just noticed that the browse button from the "Export to Bitmap" window shows a GTK Dialog, not the Win32 one that we can see now with Open/Save actions.

It should be replaced by the Win32 dialog.

Tags: win32
Changed in inkscape:
assignee: nobody → joel-airwebreathe
Revision history for this message
joelholdsworth (joel-airwebreathe) wrote :

Yes, I'm aware of this problem. It ought to be fixed. I'll see what I can do.

Revision history for this message
theAdib (theadib) wrote :

I attach a patch to that issue. It is win32 only using #ifdef WIN32 section.
However this code is gtk and should refactored to gtk++ soon.

HTH, Adib.

Changed in inkscape:
status: New → Confirmed
importance: Undecided → Medium
tags: added: win32
Revision history for this message
Chris Morgan (chris.morgan) wrote :

I've tested this patch on Windows Vista Service Pack 2 (32-bit), and it worked great... in fact it worked better than the file menu's open and save windows, as it used the newer Vista file picker (collapsible folder view, more like a mini-explorer window, etc.) which is used by all their programs, and things like OpenOffice.org, but Inskcape hadn't used them. I hope to test it on Windows 2000 soon and possibly XP.

Revision history for this message
Chris Morgan (chris.morgan) wrote :

Works fine on Windows 2000 unless the file name field is left blank before clicking on browse, in which case it just loses focus for an instant and regains it (file selection dialogue doesn't appear at all); in an older build, it just worked fine.

On Vista, if the file name field is left blank, it opened to C:\Users with the file name set to "user.*.png" (my username is user on this machine so I suspect it's doing something like %USERPROFILE%.*.png rather than %USERPROFILE%\*.png).

This is a minor regression, but I vote that the code be committed with or without that fixed. If it doesn't get committed before 0.47 Inkscape Portable will probably use it anyway to simplify things with the launcher, as %APPDATA%\gtk-2.0\filechooser.ini won't be created any more.

theAdib (theadib)
Changed in inkscape:
status: Confirmed → Fix Committed
Revision history for this message
theAdib (theadib) wrote :

Chris, I commited rev 21972 that contains my patch above and address your comments as well.
Tested under WinXP. Adib.

Changed in inkscape:
assignee: joelholdsworth (joel-airwebreathe) → theAdib (theadib)
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.