apt-cacher broken in intrepid

[Peter Matulis]

Binary package hint: apt-cacher

Version affected:

apt-cacher 1.6.4ubuntu1

Problem:

Clients cannot connect and apt-cacher error log fills up with:

Fri Oct 31 09:42:08 2008|warn [7148]: POSIX syntax [: :] belongs inside character classes in regex; marked by <-- HERE in m/(Index|Packages.gz|Packages.bz2|Release|Release.gpg|Sources.gz|Sources.bz2|Contents-.+\.gz|pkglist.*\.bz2|release$|release\..*|srclist.*\.bz2|Translation-.+\.bz2|[:alpha:] <-- HERE *\.tar\.gz\.gpg$)$/ at /usr/share/apt-cacher//apt-cacher-lib.pl line 360.
Fri Oct 31 09:42:08 2008|warn [7148]: flock() on closed filehandle $exlock at /usr/share/apt-cacher//apt-cacher-lib.pl line 279.
Fri Oct 31 09:42:08 2008|error [7148]: Unable to achieve lock on /var/cache/apt-cacher/private/exlock: Bad file descriptor at /usr/share/apt-cacher//apt-cacher-lib.pl line 281.
Fri Oct 31 09:42:08 2008|warn [7149]: POSIX syntax [: :] belongs inside character classes in regex; marked by <-- HERE in m/(Index|Packages.gz|Packages.bz2|Release|Release.gpg|Sources.gz|Sources.bz2|Contents-.+\.gz|pkglist.*\.bz2|release$|release\..*|srclist.*\.bz2|Translation-.+\.bz2|[:alpha:] <-- HERE *\.tar\.gz\.gpg$)$/ at /usr/share/apt-cacher//apt-cacher-lib.pl line 360.
Fri Oct 31 09:42:08 2008|warn [7149]: flock() on closed filehandle $exlock at /usr/share/apt-cacher//apt-cacher-lib.pl line 279.
Fri Oct 31 09:42:08 2008|error [7149]: Unable to achieve lock on /var/cache/apt-cacher/private/exlock: Bad file descriptor at /usr/share/apt-cacher//apt-cacher-lib.pl line 281.
Fri Oct 31 09:42:08 2008|warn [7150]: POSIX syntax [: :] belongs inside character classes in regex; marked by <-- HERE in m/(Index|Packages.gz|Packages.bz2|Release|Release.gpg|Sources.gz|Sources.bz2|Contents-.+\.gz|pkglist.*\.bz2|release$|release\..*|srclist.*\.bz2|Translation-.+\.bz2|[:alpha:] <-- HERE *\.tar\.gz\.gpg$)$/ at /usr/share/apt-cacher//apt-cacher-lib.pl line 360.
Fri Oct 31 09:42:08 2008|warn [7150]: flock() on closed filehandle $exlock at /usr/share/apt-cacher//apt-cacher-lib.pl line 279.
Fri Oct 31 09:42:08 2008|error [7150]: Unable to achieve lock on /var/cache/apt-cacher/private/exlock: Bad file descriptor at /usr/share/apt-cacher//apt-cacher-lib.pl line 281.

TEST CASE:
Configure and Intrepid system to use an Intrepid apt-cacher proxy. This can be done via a file in /etc/apt/apt.conf.d/ that contains the following:

Acquire
{
  http
  {
    Proxy "http://192.168.10.1:3142";
  };
};

Where 192.168.10.1 is the IP address of the apt-cacher system.

On the Intrepid system execute 'update-manager -d'.
Observe that no development release is listed.
Install the proposed version of apt-cacher.
Watch the upgrade proceed.

[Mary Gardiner (puzzlement)]

The error about "POSIX syntax" is fixed by the attached patch. This then uncovers a new error though:

Sun Nov 2 09:28:10 2008|error [29454]: Can't use an undefined value as a SCALAR reference at /usr/sbin/apt-cacher line 1255.

[Brian Murray (brian-murray)]

Looking at the attachments in this bug report, I noticed that "regexp.patch" was not flagged as a patch. A patch contains changes to an Ubuntu package that will resolve a bug and this attachment is one! Subsequently, I've checked the patch flag for it. In the future when submitting patches please use the patch checkbox as there are some Launchpad searches that use this feature. Thanks for your contribution Mary Gardiner!

[Launchpad Janitor (janitor)]

This bug was fixed in the package apt-cacher - 1.6.7ubuntu4

---------------
apt-cacher (1.6.7ubuntu4) jaunty; urgency=low

  * Resolve POSIX syntax error in apt-cacher-lib.pl for Ubuntu distribution
    upgrades. Thanks Mary Gardiner! (LP: #291606)
  * Add regular expression to apt-cacher-lib.pl to allow meta-release files
    to be cached thereby allowing update-manager to see new releases. Ubuntu
    specific, see Debian bug 502985. (LP: #309827)

 -- Brian Murray <email address hidden> Wed, 07 Jan 2009 19:48:22 -0800

[Ernst Kloppenburg (ernst-kloppenburg)]

it is important to fix this for intrepid too, otherwise updates from intrepid to jaunty won't work for apt-cacher users!!!

[Cody A.W. Somerville (cody-somerville)]

ACK

[Scott Kitterman (kitterman)]

Accepted into intrepid-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Ernst Kloppenburg (ernst-kloppenburg)]

I enabled intrepid-proposed
and updated apt-cacher to 1.6.4ubuntu2 using "apt-get install apt-cacher"

then 'update-manager -d' does offer the development release which it did not do before.
Also starting the upgrade begins correctly with downloading jaunty.tar.gz:
Thu Apr 16 20:26:01 2009|10779|::ffff:192.168.0.4|MISS|920839|jaunty.tar.gz

-> tested successfully

[Steve Beattie (sbeattie)]

I can confirm that with the version of apt-cacher in intrepid, 1.6.4ubuntu1, update-manager is prevented from seeing available upgrades when invoked as 'update-manager -d' and have also reproduced the regex warning that occurs. I have also verified that the apt-cacher in intrepid-proposed, 1.6.4ubuntu2, does permit update-manager to see available upgrades. Furthermore, I walked through updating a default intrepid installation with all the outstanding updates and then upgraded the same instance to jaunty (after rebooting) all proxied through the intrepid-proposed apt-cacher, exercising it pretty effectively.

Marking verification-done.

[Hugh Saunders (hughsaunders)]

I was also having the problem that development releases were not listed by do-release-upgrade -d. I upgraded apt-cacher to 1.6.4ubuntu2 from intreprid-proposed, which solved the problem.

Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package apt-cacher - 1.6.4ubuntu2

---------------
apt-cacher (1.6.4ubuntu2) intrepid-proposed; urgency=low

  * Resolve POSIX syntax error in apt-cacher-lib.pl for Ubuntu distribution
    upgrades. Thanks Mary Gardiner! (LP: #291606)
  * Add regular expression to apt-cacher-lib.pl to allow meta-release files
    to be cached thereby allowing update-manager to see new releases. Ubuntu
    specific, see Debian bug 502985. (LP: #309827)

 -- Brian Murray <email address hidden> Wed, 15 Apr 2009 11:43:29 -0700

[Ernst Kloppenburg (ernst-kloppenburg)]

has been fixed (a long time ago) and thus no longer affects update-manager-core