"File-->Import" wizard missing in Ubuntu's Firefox; it is in the official version

[cowpie]

Hi,
the dropdown menuitem that triggers Firefox' import wizard is missing in the Ubuntu version. I can't import anything without starting a new profile.

[Phil Bull (philbull)]

Thanks for the report.

Confirming this on Breezy firefox 1.0.7-0ubuntu20.

[Ian Jackson (ijackson)]

cowpie writes ("[Bug 28563] "File-->Import" wizard missing in Ubuntu's Firefox; it is in the official version"):
> Hi, the dropdown menuitem that triggers Firefox' import wizard is
> missing in the Ubuntu version. I can't import anything without
> starting a new profile.

I deliberately disabled this because in the default install it is
typically empty. The effect is then that if you are trying to import
some bookmarks from an existing file, you don't know that it's
possible because File / Import looks broken and you don't think to try
Bookmarks / Manage Bookmarks / File / Import.

What are you trying to use this wizard for and does it work in the
upstream version ?

Ian.

[cowpie (mistytorontodejected)]

HI, I use different browsers so I don't like having to make a new profile everytime I tyr to use Firefox again, but that is the only way if this option is missing in the menu.

[Steve-england (steve-england)]

From http://forums.mozillazine.org/viewtopic.php?p=2419806#2419806 & IRC

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060808 BonEcho/2.0b1 ID:2006080804

1. New profile
2. Bookmarks > Organize > Files > Import
3. If you have no other browsers installed to import bookmarks from, note the 'Next' button is disabled. This stops the user from importing bookmarks from the only displayed option, 'From File'.

[Steve-england (steve-england)]

I should have mentioned this bug is filed by proxy (me) and I'm on windows. The repo steps in comment 0 are what I suspect will lead to this problem being reproduced, but I can't actually say myself.

And confirmation would be appreciated.

[Amboyguy (amboyguy)]

(In reply to comment #0)
> From http://forums.mozillazine.org/viewtopic.php?p=2419806#2419806 & IRC
>
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060808
> BonEcho/2.0b1 ID:2006080804
>
> 1. New profile
> 2. Bookmarks > Organize > Files > Import
> 3. If you have no other browsers installed to import bookmarks from, note the
> 'Next' button is disabled. This stops the user from importing bookmarks from
> the only displayed option, 'From File'.
>

I confirm the problem with Linux i686 build ID:2006080804.

[Adam Guthrie (ispiked)]

This regressed between 2006-05-30-04 and 2006-05-31-04.

Checkins: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-30+03&maxdate=2006-05-31+05&cvsroot=%2Fcvsroot

Looks like fallout from bug 295683.

[Adam Guthrie (ispiked)]

Created attachment 232845
patch

Untested patch. I will test once my tree finishes building.

[Adam Guthrie (ispiked)]

Comment on attachment 232845
patch

Unforutunately, I can't trick my own build into thinking that I don't have Opear or SeaMonkey installed, so I guess this'll just have to go untested.

Gavin, is this too much of a hack?

[Gavin Sharp (gavin-sharp)]

Comment on attachment 232845
patch

Seems to me like this would be better fixed by initializing fromfile to null outside of the first if block, then changing http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/migration/content/migration.js&rev=1.29#107 to:
|var selectedMigrator = fromfile;|
with comments as appropriate.

[Adam Guthrie (ispiked)]

Created attachment 233005
patch v2.0

[Adam Guthrie (ispiked)]

Created attachment 233006
patch v2.1

[Gavin Sharp (gavin-sharp)]

Comment on attachment 233006
patch v2.1

>Index: browser/components/migration/content/migration.js

> onImportSourcePageShow: function ()
> {
>+ // Whether or not we offer to import bookmarks from a file
>+ var fromfile = null;

"Reference to the "From File" radio button" would be a better comment, I think.

>+ // The migrator to select. Initialize this to whether or not we can
>+ // import from a file, incase we can't get a migrator source below.
>+ var selectedMigrator = fromfile;

"If the "fromfile" migrator is available, use it as the default in case we have no other migrators"

[Adam Guthrie (ispiked)]

Created attachment 233382
patch v2.2

[Adam Guthrie (ispiked)]

Comment on attachment 233382
patch v2.2

I guess this really needs peer review before it can go in...

[Adam Guthrie (ispiked)]

Comment on attachment 233382
patch v2.2

Gavin just said mconnor OK'd this for checkin. Clearing request.

[Pkasting (pkasting)]

Checked in.

/mozilla/browser/components/migration/content/migration.js 1.31

[Adam Guthrie (ispiked)]

Comment on attachment 233382
patch v2.2

This is a very small patch that makes sure that a user can still import bookmarks from a file if there are no other browser installed (with bookmarks).

This IS a regression since 1.5.

[Mike Connor (mconnor)]

Comment on attachment 233382
patch v2.2

a=mconnor on behalf of drivers

[Martijn-martijn (martijn-martijn)]

Checking in migration.js;
/cvsroot/mozilla/browser/components/migration/content/migration.js,v <-- migra
tion.js
new revision: 1.22.2.10; previous revision: 1.22.2.9
done

Checked in on the 1.8.1 branch.

[Adam Guthrie (ispiked)]

*** Bug 351778 has been marked as a duplicate of this bug. ***

[Daniel Robitaille (robitaille)]

File -->Import option is still missing in the Firefox in Edgy Beta.

[Adam Guthrie (ispiked)]

Ian, I fixed this in Mozilla bug 347956 (https://bugzilla.mozilla.org/show_bug.cgi?id=347956) for Firefox 2. Can you re-enable the menu option now?

[Alexander Sack (asac)]

setting milestone to later.

[Alexander Sack (asac)]

this is committed for now and will most likely be included in next gutsy package update; lets see how this works out.

[Alexander Sack (asac)]

firefox (2.0.0.4+2-0ubuntu3) gutsy; urgency=low

  * drop more patches:
    * debian/patches/ubuntu-look-and-feel-patch.patch: drop patch removes
      File->Import dialog (LP: #28563)
    * debian/patches/series: drop ubuntu-look-and-feel-geometries.patch
      from patch series; remove that patch-file from debian/patches dir
      accordingly
  * debian/control: firefox recommends ubufox - the ubuntu firefox extension
  * drop config tweaks from patchset as they are now shipped in
    ubufox extension:
    * debian/patches/disable-default-setting-for-app.update.enabled-and-app.update.auto.patch,
      debian/patches/enable-kerberos-for-https.patch,
      debian/patches/locale-my-matchOS.patch,
      debian/patches/ubuntu-disable-default-browser-check.patch,
      debian/patches/use-intl.properties.patch: drop property only
      patches from patchset
    * debian/patches/ubuntu-no-nss-chk-create.patch: drop useless patch
      as we are now using system nss.
    * debian/patches/series: remove property only patches above from
      series file as well.
    * debian/patches/ubuntu-disable-welcome-update-url.patch,
      debian/patches/ubuntu-look-and-feel-disable-help-translate-menu.patch,
      debian/patches/ubuntu-look-and-feel-patch-fix-bookmarks-ubuntu-urls.patch,
      debian/patches/ubuntu-look-and-feel-patch.patch,
      debian/patches/ubuntu-look-and-feel-report-a-bug-menuitem.patch,
      debian/patches/ubuntu-printing-patch.patch: drop property parts
      and add TODO for patches that contain tweakings that can be
      moved to distro mods extension by overlays or other tricks.
    * debian/patches/no-have-stdint-h-ftbfs.patch: drop unused trunk
      patch from release branch package.
  * debian/build-tools/obscure.c, debian/rules: provide C helper
    (obscure-tool) to obscure firefox.cfg; build this helper in rules on
    pre-build:: and clean up on clean::
  * debian/firefox-dev.install: ship obscure-tool binary in pkglibdir of
    firefox-dev package.
  * Obscure firefox.cfg:
    - debian/firefox.cfg renamed to debian/firefox.cfg.source
    - debian/rules: produce obscured debian/firefox.cfg in pre-build:: and
      remove it in clean::" debian/rules debian/firefox.cfg.source
    - debian/firefox.cfg.source: don't tweak obscure_value anymore
  * debian/patches/bz270159-lp65164-empty-file-or-duplicate-extension-on-fat32-ntfs,
    debian/patches/series: added patch for bugzilla bug bz270159 "Download
    manager adds extension regardless of file's own extension" and bugzilla
    bug bz336113 "empty file saving on download (NTFS/FAT/SMB)" - patch
    submitted to bugzilla (LP: #65164).
  * debian/firefox.links: install compatibility links for libnspr4 and
    libnss3 shared libraries. This is done because our libnss and libnspr libs
    don't have same library name as upstream ones (e.g. we use versioned soname);
    so now we install links with original filename to pkglibdir of each mozilla
    application.

  [ Andrea Veri ]
  * Added svedish translations support to firefox's .desktop file.
    (LP: #107683)

 -- Alexander Sack <email address hidden> Fri, 8 Jun 2007 01:11:00 +0200