Please sync galrey 1.0.2-3 (universe) from Debian unstable (main)

Bug #268392 reported by Nathan Handler
6
Affects Status Importance Assigned to Milestone
galrey (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Please sync galrey 1.0.2-3 (universe) from Debian unstable (main).

Explanation of the Ubuntu delta and why it can be dropped:
debian/patches/bashism changes the interpreter in extra/massscale.sh to /bin/bash. debian/patches/bashism also corrects the only bashism in extra/rennum.sh, so there is no longer a reason to change the interpreter. We can drop the final Ubuntu change, updating the maintainer field.

Changelog since current intrepid version 1.0.2-2ubuntu1:

galrey (1.0.2-3) unstable; urgency=low

  * QA upload.
  * Added quilt for patches to fix bugs below.
  * galrey can't open files with spaces in filename. (Closes: #287468)
  * Problems with Galrey-Memofiles that do not include all images
    (Closes: #265872)
  * If input and output dir differ galrey doesn't work (Closes: #496308)

 -- Matthew Johnson <email address hidden> Sun, 24 Aug 2008 12:46:36 +0000

Tags: sync
Changed in galrey:
assignee: nobody → nhandler
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Nathan Handler (nhandler) wrote :
Revision history for this message
Nathan Handler (nhandler) wrote :
Revision history for this message
Nathan Handler (nhandler) wrote :

This is a bug fix only merge.

galrey (1.0.2-3ubuntu1) intrepid; urgency=low

  * Merge from debian unstable, remaining changes (LP: #268392):
    - debian/patches/bashims:
      + Change interpreter from /bin/sh to /bin/bash in extra/rennum.sh to
        make it work as expected.

 -- Nathan Handler <email address hidden> Tue, 09 Sep 2008 20:28:29 -0500

Changed in galrey:
assignee: nhandler → nobody
status: In Progress → Confirmed
Revision history for this message
Michael Bienia (geser) wrote :

Is the change of the interpreter for extra/rennum.sh really needed?

According to checkbashims it only complains about the usage of read which gets fixed in debian/patches/bashism.

$ checkbashisms extra/rennum.sh
possible bashism in extra/rennum.sh line 8 (should be read [-r] variable):
read

Changed in galrey:
status: Confirmed → Incomplete
Changed in galrey:
assignee: nobody → nhandler
status: Incomplete → In Progress
Revision history for this message
Nathan Handler (nhandler) wrote :

Michael, thanks for telling me about checkbashisms. I did not know about that tool before.

After reviewing extra/rennum.sh and debian/patches/bashism, I no longer feel that changing the interpreter is no longer needed. debian/patches/bashism takes care of changing the interpreter in extra/massscale.sh to /bin/bash. This means that we no longer have any significant Ubuntu changes that need to be kept. I have tested and verified that the Debian 1.0.2-3 package builds successfully in an Intrepid pbuilder, and I am changing this bug report to be a sync request.

Changed in galrey:
assignee: nhandler → nobody
status: In Progress → New
description: updated
Revision history for this message
Michael Bienia (geser) wrote :

Sync request ACKed.

Changed in galrey:
status: New → Confirmed
Revision history for this message
Steve Langasek (vorlon) wrote :

[Updating] galrey (1.0.2-2ubuntu1 [Ubuntu] < 1.0.2-3 [Debian])
 * Trying to add galrey...
  - <galrey_1.0.2-3.dsc: downloading from http://ftp.debian.org/debian/>
  - <galrey_1.0.2-3.diff.gz: downloading from http://ftp.debian.org/debian/>
  - <galrey_1.0.2.orig.tar.gz: already in distro - downloading from librarian>
I: galrey [universe] -> galrey_1.0.2-2ubuntu1 [universe].

Changed in galrey:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.