thunar-volman-settings path must no be hardcoded

[Christoph Wickert]

Currently the path of thunar-volman-settings is hardcoded in volman.c:
#define EXE "/usr/lib/thunar-volman/thunar-volman-settings"

This is bad, because the location of thunar-volman-settings is not predictable. On some distributions it's $(libdir)/thunar-volman/thunar-volman-settings (which is nonsense, because it's binary and not a lib) , on others it's $(libexecdir)/thunar-volman/thunar-volman-settings. If there are no additional options passed to ./configure of Thunar or thunar-volman they use $(libexecdir) (without subdir), so $(libexecdir)/thunar-volman-settings should be defined as default I think.

Nevertheless this is no real solution, ./configure should check for the location and make should pick it up automatically.

[Christoph (christoph-redhat-bugs)]

Spec URL: http://cwickert.fedorapeople.org/review/xfce-mcs-plugins-extra.spec
SRPM URL: http://cwickert.fedorapeople.org/review/xfce-mcs-plugins-extra-2.0-1.fc10.src.rpm
Description: This packages provides additional configuration items to be included
in the Xfce settings manager:
- Autostarted applications
- Menu editor
- Removable drives and media
- SCIM input method

[Rahul (rahul-redhat-bugs)]

OK | MUST: rpmlint is clean
OK | MUST: The package must be named according to the Package…
OK | MUST: The spec file name must match the base package…
OK | MUST: The package must meet the Packaging Guidelines…
OK | MUST: The package must be licensed with a Fedora approved…

NOK | MUST: The License field in the package spec file must…

License tag is incorrect. It is GPLv2 and not GPLv2+. Check the copyright
headers under src directory. They are explicitly licensed under GPL v2 only.

- | MUST: The spec file must be written in American English.
OK | MUST: The package must successfully compile and build…
OK | MUST: All build dependencies must be listed…
OK | MUST: The spec file MUST handle locales properly…
OK | MUST: Every binary RPM package which stores shared…
OK | MUST: If the package is designed to be relocatable…
OK | MUST: A package must own all directories that it creates
OK | MUST: A package must not contain any duplicate files
OK | MUST: Permissions on files must be set properly.
OK | MUST: Each package must have a %clean section
OK | MUST: Each package must consistently use macros
OK | MUST: The package must contain code, or permissible
N/A | MUST: Large documentation files should go in a -doc
OK | MUST: If a package includes something as %doc…
N/A | MUST: Header files must be in a -devel package.
N/A | MUST: Static libraries must be in a -static package.
Static files are disabled as per guidelines
N/A | MUST: Packages containing pkgconfig(.pc) files must…
N/A | MUST: If a package contains library files with a suffix…
N/A | MUST: In the vast majority of cases, devel packages must…
OK | MUST: Packages must NOT contain any .la libtool archives,
la files are removed correctly as per guidelines
N/A | MUST: Packages containing GUI applications must include…
OK | MUST: Packages must not own files or directories already
OK | MUST: At the beginning of %install, each package MUST…
OK | MUST: All filenames in rpm packages must be valid UTF-8.
OK | SHOULD: If the source package does not include license
- | SHOULD: The description and summary section … translations…
OK | SHOULD: The package builds in mock
- | SHOULD: The package builds on all supported architectures
OK | SHOULD: The reviewer should test that the package…
N/A | SHOULD: If scriptlets are used, those scriptlets must be sane…
N/A | SHOULD: Subpackages other than devel should usually require base…
N/A | SHOULD: The placement of pkgconfig(.pc) files depends on…
OK | SHOULD: If the package has file dependencies outside of shortlist…
OK | MUST: All build dependencies must be listed…

Install instructions mention that FSF is giving permission to copy, modify and
redistribute. This is incorrect. Only the copyright holders are doing so. That
bit needs to be fixed upstream. Please notify them.

You might want to pass --with-gnu-ld in configure to speed up the process

Please send a patch upstream to remove the hardcoded path you are working around
in your spec file.

[Christoph (christoph-redhat-bugs)]

(In reply to comment #1)
>
> NOK | MUST: The License field in the package spec file must…
>
> License tag is incorrect. It is GPLv2 and not GPLv2+. Check the copyright
> headers under src directory. They are explicitly licensed under GPL v2 only.

I thought I had looked that up but you are correct. Fixed.

> Install instructions mention that FSF is giving permission to copy, modify and
> redistribute. This is incorrect. Only the copyright holders are doing so. That
> bit needs to be fixed upstream. Please notify them.

Will do.

> You might want to pass --with-gnu-ld in configure to speed up the process

Done.

> Please send a patch upstream to remove the hardcoded path you are working around
> in your spec file.

Any idea how to do this best? I'm not really familiar with autotools, so I don't
want to add a ./configure. Debian/Ubuntu are also patching the file.

[Rahul (rahul-redhat-bugs)]

I am hardly a autotools expert but I send a patch for rssh upstream recently.

http://sourceforge.net/mailarchive/forum.php?thread_name=488525DF.3020800%40fedoraproject.org&forum_name=rssh-discuss

That should give you a general idea.

[Rakesh (rakesh-redhat-bugs)]

@Christoph
Review is stalled and needs update soon.

[Christoph (christoph-redhat-bugs)]

The review is stalled because I'm failing to patch the change Rahul requested in comment # 1. Unfortunately The suggestion from comment #3 does not work because I need to patch source but not only the Makefile.

I still have no idea how this is supposed to work: thunar-volman is installed in different locations on different distributions, so it's not just about removing the hardcoded path: Replacing /usr/libexec with %{libexecdir} is not enough because it can also be %{libexecdir}/thunar-volman or even %{libdir}. So in the end it _needs_ ./configure to check for the location and pick it up. As I said I'm not an autotools expert, so I have no idea how to do this.

[Christoph (christoph-redhat-bugs)]

Filed bug upstream at https://bugs.launchpad.net/bugs/264421

[Gauvain Pocentek (gpocentek)]

Fix committed in the bzr branch (revno 3).
I've added a '--with-volman=PATH' switch to configure.

[Christoph (christoph-redhat-bugs)]

New package with fix from upstream:

http://cwickert.fedorapeople.org/review/xfce-mcs-plugins-extra.spec
http://cwickert.fedorapeople.org/review/xfce-mcs-plugins-extra-2.0-2.fc10.src.rpm

[Rahul (rahul-redhat-bugs)]

APPROVED

[Christoph (christoph-redhat-bugs)]

New Package CVS Request
=======================
Package Name: xfce-mcs-plugins-extra
Short Description: Extra plugins for the Xfce mcs manager
Owners: cwickert, kevin
Branches: F-8 F-9
InitialCC:

[Kevin (kevin-redhat-bugs)]

cvs done.

[Fedora (fedora-redhat-bugs)]

xfce-mcs-plugins-extra-2.0-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/xfce-mcs-plugins-extra-2.0-2.fc9

[Fedora (fedora-redhat-bugs)]

xfce-mcs-plugins-extra-2.0-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/xfce-mcs-plugins-extra-2.0-2.fc8

[Fedora (fedora-redhat-bugs)]

xfce-mcs-plugins-extra-2.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

xfce-mcs-plugins-extra-2.0-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.