Please sponsor vino 2.23.91 (main) into Intrepid

[Pedro Fragoso]

Binary package hint: vino

vino (2.23.91-0ubuntu1) intrepid; urgency=low

  * New upstream release
    - Make vino work correctly with new gnome-session. (Jonh Wendell)
  * debian/control.in:
    - Add B-d on libgnomeui-dev

 -- Pedro Fragoso <email address hidden> Mon, 01 Sep 2008 19:42:50 +0100

[Loïc Minier (lool)]

Pedro, I ran interdiff -z -p1 vino_2.23.90-0ubuntu1.diff.gz vino_2.23.91-0ubuntu1.diff.gz and saw this:

--- vino-2.23.90/debian/control.in
+++ vino-2.23.91/debian/control.in
@@ -22,13 +22,14 @@
                libdbus-glib-1-dev,
                libnotify-dev (>= 0.4.4),
                libnotify-dev-gtk2.10,
- libgnome-keyring-dev
+ libgnome-keyring-dev,
+ libdbus-1-3 (>= 1.2.3)
 Standards-Version: 3.7.3
.
 Package: vino
 Architecture: any
 Depends: ${shlibs:Depends},
- ${misc:Depends}
+ ${misc:Depends},.........
 Suggests: vinagre,
           gnome-user-guide | gnome2-user-guide (>= 2.8.1)
 Description: VNC server for GNOME

1) You added whitespaces needlessly to the vino deps, be careful.

2) Upstream added checks on the dbus-1 pkg-config module:
-PKG_CHECK_MODULES(VINO_SERVER, glib-2.0 >= $GLIB_VERSION gtk+-x11-2.0 >= $GTK_VERSION gconf-2.0 libglade-2.0 libbonobo-2.0 dbus-glib-1)
+PKG_CHECK_MODULES(VINO_SERVER, glib-2.0 >= $GLIB_VERSION gtk+-x11-2.0 >= $GTK_VERSION gconf-2.0 libglade-2.0 dbus-1 >= $DBUS_VERSION dbus-glib-1 libgnomeui-2.0)
.
-PKG_CHECK_MODULES(VINO_CAPPLET, glib-2.0 >= $GLIB_VERSION gtk+-2.0 >= $GTK_VERSION gconf-2.0 libglade-2.0 dbus-glib-1)
+PKG_CHECK_MODULES(VINO_CAPPLET, glib-2.0 >= $GLIB_VERSION gtk+-2.0 >= $GTK_VERSION gconf-2.0 libglade-2.0 dbus-1 >= $DBUS_VERSION dbus-glib-1)

this means that you need to build-dep on the package providing dbus-1.pc; it is NOT libdbus-1-3

3) you missed the fact that the orbit2 / libbonobo pkg-config modules checks were dropped, but this is visible in the diff of configure.ac AND mentionned in the ChangeLog file

4) style: you mention the libgnomeui-dev build-dep as a separate change:
+ * New upstream release (LP: #263738)
+ - Make vino work correctly with new gnome-session. (Jonh Wendell)
+ * debian/control.in:
+ - Add B-d on libgnomeui-dev
but it's actually related to the new upstream release; I recommend you mention it along the upstream release.

5) you didn't actually add this build-dep......

[Pedro Fragoso (ember)]

Sorry Loic i completyed upload the wrong diff for this.

-rw-r--r-- 1 pmf pmf 461590 2008-09-01 20:46 /var/cache/pbuilder/intrepid/result/vino_2.23.91-0ubuntu1_i386.deb

1) fixed
2) I have this right sorry again for wrong upload
3) ditto
4) I've changed the changelog style
5) .

[Pedro Fragoso (ember)]

There's no need to be disappointed Loic, it was just a mistake on uploading the right diff, it can happen to anyone.

[Loïc Minier (lool)]

> There's no need to be disappointed Loic, it was just a mistake on uploading the right diff, it can happen to anyone.

I understand; the part about the libdbus bdep instead of libdbus-dev really made me "WTF" I guess

[Launchpad Janitor (janitor)]

This bug was fixed in the package vino - 2.23.91-0ubuntu1

---------------
vino (2.23.91-0ubuntu1) intrepid; urgency=low

  * New upstream release (LP: #263738)
    - Make vino work correctly with new gnome-session. (Jonh Wendell)
    - Add B-d on libgnomeui-dev and libdbus-1-dev
    - Drop b-d libbonobo-dev

 -- Pedro Fragoso <email address hidden> Mon, 01 Sep 2008 19:42:50 +0100