bzr add crashes on filenames with accented characters

[ed]

The tail end of the output from bzr add:

...
added "Archived/Resumés"
bzr: ERROR: exceptions.KeyError: u'Resume\u0301s'

Traceback (most recent call last):
  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 846, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/opt/local/lib/python2.5/site-packages/bzrlib/builtins.py", line 373, in run
    no_recurse, action=action, save=not dry_run)
  File "/opt/local/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 52, in tree_write_locked
    return unbound(self, *args, **kwargs)
  File "/opt/local/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 412, in smart_add
    this_ie = parent_ie.children[directory.base_path]
KeyError: u'Resume\u0301s'

bzr 1.5 on python 2.5.2 (darwin)
arguments: ['/opt/local/bin/bzr', 'add', '.']
encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'
plugins:
  launchpad /opt/local/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[ed (ed-mckenzie)]

Actually, this is a directory name, not a filename.

[Erik (erik-calissendorff)]

I'm having the same problem in bzr 1.9 with python 2.5.2 (darwin) here is the tracelog, this example is also on a directory but I believe the problem exists on files aswell. Quite a limitation not to be able to utilize international characters.

bzr: ERROR: exceptions.KeyError: u'Godka\u0308nda'

Traceback (most recent call last):
  File "/Library/Python/2.5/site-packages/bzrlib/commands.py", line 893, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/Library/Python/2.5/site-packages/bzrlib/commands.py", line 839, in run_bzr
    ret = run(*run_argv)
  File "/Library/Python/2.5/site-packages/bzrlib/commands.py", line 539, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/Library/Python/2.5/site-packages/bzrlib/builtins.py", line 499, in run
    no_recurse, action=action, save=not dry_run)
  File "/Library/Python/2.5/site-packages/bzrlib/mutabletree.py", line 52, in tree_write_locked
    return unbound(self, *args, **kwargs)
  File "/Library/Python/2.5/site-packages/bzrlib/mutabletree.py", line 447, in smart_add
    this_ie = parent_ie.children[directory.base_path]
KeyError: u'Godka\u0308nda'

[Erik (erik-calissendorff)]

Here is an example of the problem when trying to add a normal file with international (in this case swedish) characters.

Traceback (most recent call last):
  File "/usr/local/bin/bzr", line 130, in <module>
    exit_val = bzrlib.commands.main(sys.argv)
  File "/Library/Python/2.5/site-packages/bzrlib/commands.py", line 883, in main
    "encoding." % a))
bzrlib.errors.BzrError: Parameter ''Applications/Anso\xcc\x88kan konsultcheck.dot'' is unsupported by the current encoding.

[Robert Collins (lifeless)]

Are you on MacOSX ?

[ed (ed-mckenzie)]

Yes; I had this issue on 10.5.

[Erik (erik-calissendorff)]

Yes I'm on MacOS X 10.5

On Mon, Mar 16, 2009 at 12:50 AM, Robert Collins
<email address hidden> wrote:
> Are you on MacOSX ?
>
> ** Changed in: bzr
>       Status: New => Confirmed
>
> --
> bzr add crashes on filenames with accented characters
> https://bugs.launchpad.net/bugs/263421
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Bazaar Version Control System: Confirmed
>
> Bug description:
> The tail end of the output from bzr add:
>
> ...
> added "Archived/Resumés"
> bzr: ERROR: exceptions.KeyError: u'Resume\u0301s'
>
> Traceback (most recent call last):
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 846, in run_bzr_catch_errors
>    return run_bzr(argv)
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
>    ret = run(*run_argv)
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
>    return self.run(**all_cmd_args)
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/builtins.py", line 373, in run
>    no_recurse, action=action, save=not dry_run)
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 52, in tree_write_locked
>    return unbound(self, *args, **kwargs)
>  File "/opt/local/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 412, in smart_add
>    this_ie = parent_ie.children[directory.base_path]
> KeyError: u'Resume\u0301s'
>
> bzr 1.5 on python 2.5.2 (darwin)
> arguments: ['/opt/local/bin/bzr', 'add', '.']
> encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'
> plugins:
>  launchpad            /opt/local/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
> *** Bazaar has encountered an internal error.
>    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
>    including this traceback, and a description of what you
>    were doing when the error occurred.
>

--
Erik Calissendorff
Cell: [phone] (France)
Cell: [phone] (Sweden)
E-mail: <email address hidden>
Homepage: http://www.tansaki.com
--
CONFIDENTIALITY NOTICE
This e-mail or the documents accompanying this e-mail contain information which
may be confidential or privileged and exempt from disclosure under
applicable law.
If you have received this e-mail in error, please notify immediately
and delete this message.