Bug #26305 “initscript: completely broken” : Bugs : sysfsutils package : Ubuntu

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2005-11-28:

#1

Automatically imported from Debian bug report #341060 http://bugs.debian.org/341060

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2005-11-28:

#2

Message-ID: <email address hidden>
Date: Mon, 28 Nov 2005 00:22:57 -0200
From: Henrique de Moraes Holschuh <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: initscript: completely broken

Package: sysfsutils
Version: 1.3.0-3
Severity: grave
Justification: renders package unusable

if [ "$f1" ] ;... is NOT valid shell syntax. Nor is [ ... -a "$f2" ].
You're missing a "-n" in front of all bare string tests inside [ ].

-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.4-debian1+libata+bluesmoke+imq+lm85
Locale: LANG=pt_BR.ISO-8859-1, LC_CTYPE=pt_BR.ISO-8859-1 (charmap=ISO-8859-1)

Versions of packages sysfsutils depends on:
ii libc6 2.3.5-8.1 GNU C Library: Shared libraries an
ii libsysfs1 1.3.0-3 interface library to sysfs

sysfsutils recommends no packages.

-- no debconf information

--
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Revision history for this message

Martin Pitt (pitti) wrote on 2005-11-28:

#3

This is really a bogus report; I track it in Debian as normal
severity/needinfo+unreproducible.

Revision history for this message

In Debian Bug tracker #341060, Martin Pitt (pitti) wrote on 2005-11-28: Re: Bug#341060: initscript: completely broken

#4

severity 341060 normal
tag 341060 unreproducible moreinfo
thanks

Hi Henrique!

Henrique de Moraes Holschuh [2005-11-28 0:22 -0200]:
> Package: sysfsutils
> Version: 1.3.0-3
> Severity: grave
> Justification: renders package unusable
>
> if [ "$f1" ] ;... is NOT valid shell syntax. Nor is [ ... -a "$f2" ].
> You're missing a "-n" in front of all bare string tests inside [ ].

The script runs fine with bash and dash, and [ "$foo" ] is common
practice and described in test(1):

-n STRING
the length of STRING is nonzero

STRING equivalent to -n STRING

Downgrading severity since this runs fine at least on the majority of
installations.

So what exactly breaks for you? According to your initial report you
have /bin/sh linked to /bin/bash, do you use another shell?

Please give me the output of sh -nx /etc/init.d/sysfsutils if it
really breaks for you.

Thanks,

Martin
--
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2005-11-28:

#5

Message-ID: <email address hidden>
Date: Mon, 28 Nov 2005 12:42:46 +0100
From: Martin Pitt <email address hidden>
To: Henrique de Moraes Holschuh <email address hidden>,
<email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#341060: initscript: completely broken

--pvezYHf7grwyp3Bc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

severity 341060 normal
tag 341060 unreproducible moreinfo
thanks

Hi Henrique!

Henrique de Moraes Holschuh [2005-11-28 0:22 -0200]:
> Package: sysfsutils
> Version: 1.3.0-3
> Severity: grave
> Justification: renders package unusable
>=20
> if [ "$f1" ] ;... is NOT valid shell syntax. Nor is [ ... -a "$f2" ].
> You're missing a "-n" in front of all bare string tests inside [ ].

The script runs fine with bash and dash, and [ "$foo" ] is common
practice and described in test(1):

-n STRING
the length of STRING is nonzero

STRING equivalent to -n STRING

Downgrading severity since this runs fine at least on the majority of
installations.

So what exactly breaks for you? According to your initial report you
have /bin/sh linked to /bin/bash, do you use another shell?

Please give me the output of sh -nx /etc/init.d/sysfsutils if it
really breaks for you.

Thanks,

Martin
--=20
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?

--pvezYHf7grwyp3Bc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDiu01DecnbV4Fd/IRAiswAKCi5mZJUJT/UjpHdgPMHbLHvgrU3gCg4i+H
MUn7OiXdndrxkEcy4tIFBBA=
=w8DD
-----END PGP SIGNATURE-----

--pvezYHf7grwyp3Bc--

Revision history for this message

In Debian Bug tracker #341060, Henrique de Moraes Holschuh (hmh) wrote on 2005-11-29:

#6

severity 341060 grave
thanks

(I am setting it back to grave so that apt-listbugs warns people off until
an upload fixing the bug hits the archive. See the rest of the email).

On Mon, 28 Nov 2005, Martin Pitt wrote:
> The script runs fine with bash and dash, and [ "$foo" ] is common

Well, here it broke with bash from sid depending on the values of $foo,
which is probably why you could not reproduce it.

> practice and described in test(1:
>
> -n STRING
> the length of STRING is nonzero
>
> STRING equivalent to -n STRING

Braindamaged common practice, that one is. If with "-<something test
recognizes>" the string is, stupid things test will do.

Never use naked strings with test, it is courting an error mode. I *think*
it is smart enough not to croak if you [ "$string" ], but it will on [
"$string" -a something -a "$string2" ]...

In this case it barfs when some of the strings are "-1", see attached error
dump.

Try this:
a=1 ; b=-1 ; [ -n "$a" -a "$b" ] && echo ok

Interestingly enough,
a=1 ; b=-1 ; [ "$a" -a "$b" ] && echo ok
won't croak. This is bash trying to be smart, as
a=1 ; b=-1 ; /usr/bin/[ "$a" -a "$b" ] && echo ok
WILL croak.

> Please give me the output of sh -nx /etc/init.d/sysfsutils if it
> really breaks for you.

"if it really breaks"? I'd have worded that request very differently, the
way you did is not nice at all. I hope you did so because of the @d.o
address, and would not write something like that to a regular user.

Output attached, and sysfs.conf attached too. BTW, "-nx" gives no output, I
ran it with -x only.

also, just for completeness:
khazad-dum:/etc# ls -lad /bin/sh
lrwxrwxrwx 1 root root 4 Oct 14 19:47 /bin/sh -> bash

and
khazad-dum:/etc# head -n 1 /etc/init.d/sysfsutils
#! /bin/sh -e

--
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

severity 341060 grave
thanks

(I am setting it back to grave so that apt-listbugs warns people off until
an upload fixing the bug hits the archive.  See the rest of the email).

On Mon, 28 Nov 2005, Martin Pitt wrote:
> The script runs fine with bash and dash, and [ "$foo" ] is common

Well, here it broke with bash from sid depending on the values of $foo,
which is probably why you could not reproduce it.

> practice and described in test(1:
> 
>        -n STRING
>               the length of STRING is nonzero
> 
>        STRING equivalent to -n STRING

Braindamaged common practice, that one is.  If with "-<something test
recognizes>" the string is, stupid things test will do.

Never use naked strings with test, it is courting an error mode.  I *think*
it is smart enough not to croak if you [ "$string" ], but it will on [
"$string" -a something -a "$string2" ]...

In this case it barfs when some of the strings are "-1", see attached error
dump.

Try this:
	a=1 ; b=-1 ; [ -n "$a" -a "$b" ] && echo ok

Interestingly enough,
	a=1 ; b=-1 ; [ "$a" -a "$b" ] && echo ok
won't croak.  This is bash trying to be smart, as
	a=1 ; b=-1 ; /usr/bin/[ "$a" -a "$b" ] && echo ok
WILL croak.

> Please give me the output of sh -nx /etc/init.d/sysfsutils if it
> really breaks for you.

"if it really breaks"?  I'd have worded that request very differently, the
way you did is not nice at all.  I hope you did so because of the @d.o
address, and would not write something like that to a regular user.

Output attached, and sysfs.conf attached too.  BTW, "-nx" gives no output, I
ran it with -x only.

also, just for completeness:
khazad-dum:/etc# ls -lad /bin/sh  
lrwxrwxrwx 1 root root 4 Oct 14 19:47 /bin/sh -> bash

and
khazad-dum:/etc# head -n 1 /etc/init.d/sysfsutils 
#! /bin/sh -e

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2005-11-29:

#7

Download full text (17.3 KiB)

Message-ID: <email address hidden>
Date: Tue, 29 Nov 2005 10:39:00 -0200
From: Henrique de Moraes Holschuh <email address hidden>
To: Martin Pitt <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#341060: initscript: completely broken

--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

severity 341060 grave
thanks

(I am setting it back to grave so that apt-listbugs warns people off until
an upload fixing the bug hits the archive. See the rest of the email).

On Mon, 28 Nov 2005, Martin Pitt wrote:
> The script runs fine with bash and dash, and [ "$foo" ] is common

Well, here it broke with bash from sid depending on the values of $foo,
which is probably why you could not reproduce it.

> practice and described in test(1:
>
> -n STRING
> the length of STRING is nonzero
>
> STRING equivalent to -n STRING

Braindamaged common practice, that one is. If with "-<something test
recognizes>" the string is, stupid things test will do.

Never use naked strings with test, it is courting an error mode. I *think*
it is smart enough not to croak if you [ "$string" ], but it will on [
"$string" -a something -a "$string2" ]...

In this case it barfs when some of the strings are "-1", see attached error
dump.

Try this:
a=1 ; b=-1 ; [ -n "$a" -a "$b" ] && echo ok

Interestingly enough,
a=1 ; b=-1 ; [ "$a" -a "$b" ] && echo ok
won't croak. This is bash trying to be smart, as
a=1 ; b=-1 ; /usr/bin/[ "$a" -a "$b" ] && echo ok
WILL croak.

> Please give me the output of sh -nx /etc/init.d/sysfsutils if it
> really breaks for you.

"if it really breaks"? I'd have worded that request very differently, the
way you did is not nice at all. I hope you did so because of the @d.o
address, and would not write something like that to a regular user.

Output attached, and sysfs.conf attached too. BTW, "-nx" gives no output, I
ran it with -x only.

also, just for completeness:
khazad-dum:/etc# ls -lad /bin/sh
lrwxrwxrwx 1 root root 4 Oct 14 19:47 /bin/sh -> bash

and
khazad-dum:/etc# head -n 1 /etc/init.d/sysfsutils
#! /bin/sh -e

--
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="sysfs.conf"

#
# /etc/sysfs.conf - Configuration file for setting sysfs attributes.
#
# The sysfs mount directory is automatically prepended to the attribute paths.
#
# Examples:
#
# Always use the powersave CPU frequency governor
# devices/system/cpu/cpu0/cpufreq/scaling_governor=powersave
#
# Use userspace CPU frequency governor and set initial speed
# devices/system/cpu/cpu0/cpufreq/scaling_governor = userspace
# devices/system/cpu/cpu0/cpufreq/scaling_setspeed = 600000

##
## ADM-1027 temperature monitor / fan controller
##

# Device setup (maybe overriden later by /etc/sensors.conf)
# Generated using sensors.conf, look there.
class/i2c-adapter/i2c-0/device/0-002e/vrm = 91
class/i2c-adapter/i2c-0/device/0-002e/in0_max...

Message-ID: <20051129123900.GB9976@khazad-dum.debian.net>
Date: Tue, 29 Nov 2005 10:39:00 -0200
From: Henrique de Moraes Holschuh <hmh@debian.org>
To: Martin Pitt <mpitt@debian.org>
Cc: 341060@bugs.debian.org
Subject: Re: Bug#341060: initscript: completely broken