Desktop file is missing

[Dominik Holler]

Binary package hint: tipptrainer

There is no icon in menu, so copy tipptrainer.desktop to /usr/share/applications/tipptrainer.desktop to show one.

[Chris Coulson (chrisccoulson)]

Confirmed for 0.6.0-12 in Hardy

[Nathan Handler (nhandler)]

tipptrainer (0.6.0-14ubuntu1) intrepid; urgency=low

  * debian/tipptrainer.install
    - Install .desktop file (LP: #257406)
  * debian/tipptrainer.desktop
    - Modify to validate with desktop-file-validate
    - Modify icon path
    - Add Exec, StartupNotify, and Terminal fields
  * Bump Standards-Version to 3.8.0
    - Add debian/README.source

 -- Nathan Handler <email address hidden> Tue, 12 Aug 2008 19:49:01 -0500

[Siegfried Gevatter (rainct)]

-Icon=tipptrainer
+Icon=/usr/share/tipptrainer/tipptrainer.xpm

The icon was already right. It should include *no* path or extension; the menu application will determine which icon to use by itself. The same goes for the Exec line.

----

I won't object to uploading because of this, but adding debian/README.source is unneeded divergence.

----

Please forward your patch to Debian and link the Debian bug to this report.

[Nathan Handler (nhandler)]

Siegfried, the icon actually does require the full path since it is not installed in /usr/share/pixmaps. If you leave the icon path as 'tipptrainer', no icon is displayed. I did modify the Exec field to just have 'tipptrainer' instead of the absolute path.

This patch does not bump the Standards-Version or add debian/README.source. There really is no reason to add these changes in this patch.

I have also forwarded the patch to Debian.

tipptrainer (0.6.0-14ubuntu1) intrepid; urgency=low

  * debian/tipptrainer.install
    - Install .desktop file (LP: #257406)
  * debian/tiptrainer.desktop
    - Remove Encoding field to validate with desktop-file-validate
    - Add Exec field
    - Modify Icon field to correctly load icon

 -- Nathan Handler <email address hidden> Tue, 26 Aug 2008 22:54:39 -0500

[Nathan Handler (nhandler)]

The Debian Maintainer has already applied the patch. As a result, I am closing this Ubuntu bug. We can fix this bug when we sync/merge the package from Debian.

[Nathan Handler (nhandler)]

I have created a Sync Request for tipptrainer (LP: #262279). Once the package is synced, this bug should be resolved in Ubuntu.

[Colin Watson (cjwatson)]

The right model is not to close this bug as Invalid, but to let the sync close it automatically since there's an LP: tag in the changelog.

[Launchpad Janitor (janitor)]

This bug was fixed in the package tipptrainer - 0.6.0-15

---------------
tipptrainer (0.6.0-15) unstable; urgency=low

  * Switch to quilt
  * Standards-Version: 3.8.0 (no changes needed)
  * debian/control:
    - Vcs Fields
    - DM-Upload-Allowed: yes
  * Applied patch from Ubuntu by Nathan Handler <email address hidden>
    which makes desktop file work properly (Many thanks to Nathan!)
    - debian/tipptrainer.install
       + Install .desktop file (LP: #257406)
    - debian/tiptrainer.desktop
       + Remove Encoding field to validate with desktop-file-validate
       + Add Exec field
       + Modify Icon field to correctly load icon
    Closes: 496738

 -- Nathan Handler <email address hidden> Mon, 01 Sep 2008 16:31:31 +0100