XXX in templates should be updated so they're correctly captured by the xxxreporty.py tool

Bug #256212 reported by Diogo Matsubara
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Diogo Matsubara

Bug Description

We have a tool that generates a nice html report with all the XXX's found in the LP code. <https://devpad.canonical.com/~curtis/xxxreport.html>

This bug is about updating those XXX so the tool will correctly display them

Revision history for this message
Diogo Matsubara (matsubara) wrote :

<matsubara> sinzui: quick question about r6941: does xxxreport.py now include XXX in templates?
<sinzui> matsubara: it always has
<sinzui> matsubara: It may miss some of the comment text since HTML only has multiline comments. Using // or # in front of each line will ensure all the text is captured,
<matsubara> sinzui: cool, I wasn't aware of that. I'll mark bug 256212 as invalid then
<sinzui> matsubara: in https://devpad.canonical.com/~curtis/xxxreport.html you can see that from 708 on, XXX in templates are captured, but that the comment text is often shown in the context portion of the report.
<matsubara> sinzui: right. I missed those when I filed the report. I'll invalidate it. thanks!
<sinzui> matsubara: I think that bug is legitimate in part because XXX comments must always be in out XXX format, which they often are not in templates.
<sinzui> matsubara: so the fix is the review and correct XXX comments in the templates.
<matsubara> sinzui: good idea. I'll mutate that bug to say that.

description: updated
Changed in launchpad-foundations:
status: New → Triaged
Changed in launchpad-foundations:
assignee: nobody → matsubara
milestone: none → 2.1.11
Changed in launchpad-foundations:
milestone: 2.1.11 → 2.1.12
Revision history for this message
Diogo Matsubara (matsubara) wrote :

The following templates have XXX pointing to fix released bugs so they are good targets to the technical debt cleanup.
templates/bazaar-index.pt
templates/binarypackagepublishinghistory-listing-detailed.pt
templates/binarypackagerelease-index.pt
templates/translation-import-queue-macros.pt

Changed in launchpad-foundations:
status: Triaged → In Progress
Revision history for this message
Diogo Matsubara (matsubara) wrote :

As part of this fix I need to update (and move to the right wiki while at it) https://launchpad.canonical.com/PolicyandProcess/XXXPolicy to reflect the current style of adding XXXs on templates.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Fix in RF 7392

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.