lsb calls to usplash_write should fail silently

Bug #251656 reported by Dustin Kirkland 
4
Affects Status Importance Assigned to Milestone
usplash (Ubuntu)
Fix Released
Undecided
Dustin Kirkland 

Bug Description

Binary package hint: lsb

Init scripts, as well as other LSB-using scripts can be executed by non-privileged user. In such cases, the non-privileged user trying to execute usplash_write will yield an error message like:
  open: Permission denied

For example, in Intrepid, as a non-root user, run:
# /etc/init.d/ssh status
open: Permission denied
 * sshd is running.

This can be noisy and distracting, and in almost all cases, this is not a useful error message to that user.

:-Dustin

Related branches

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Patch attached.

Colin previously suggested that this could be handled in usplash itself. I have that patch as well, but I would thing that this approach (patching callers of usplash_write) would be preferred.

Please review, and advise.

:-Dustin

Changed in lsb:
assignee: nobody → kirkland
status: New → Triaged
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

As Colin pointed out in IRC, the above patch will silence all errors thrown by usplash.

As a different approach, here is a simple patch to usplash_write that silences EACCES errors.

:-Dustin

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

A bzr branch with these changes, proposed for merging:
 * https://code.launchpad.net/~kirkland/usplash/usplash.251656

:-Dustin

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usplash - 0.5.23

---------------
usplash (0.5.23) intrepid; urgency=low

  * usplash_write.c: do not perror(open) if EACCESS (LP: #251656).

 -- Dustin Kirkland <email address hidden> Mon, 28 Jul 2008 09:50:22 -0500

Changed in usplash:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.