"Work in progress" action should be titled "Cancel review request"

[Andrew Bennetts]

The actions portlet has a "Work in progress" action. That's not a verb phrase, so it's a bad name for an action.

Talking to jml, it apparently cancels a review request. So, call it "Cancel review request" instead.

Also, perhaps more fundamentally, it's not at all clear what the relationship between these actions and the "status" on the merge proposal page is. Perhaps the real fix is to change the "Status: work in progress"/"Status: needs review" to be:

 Status:
  * _needs review_ (from anyone) [Cancel review request]
  * _needs review_ (from Specific Person) [Cancel review request]
  [Add review request]

If there are no review requests, then:

 Status:
  No review requests
  [Add review request]

[Jonathan Lange (jml)]

I'm marking this as "confirmed" and assigning to Aaron, since I'd like to hear his thoughts on the bug first.

[Aaron Bentley (abentley)]

Requesting a review from an individual isn't a required part of the process. This change would make it seem so.

Sometimes, in the process of a review, it's determined that more work needs to be done. One approach would be to just delete the merge proposal at that point. Another is to mark it as WIP, and update it later.

I don't see a big problem with the current state.

[Jonathan Lange (jml)]

The problem isn't with the current state so much as the name of the transition.

All of the other review states have verb phrases as transitions (i.e. links on the action menu). The link to change to Work in Progress is just "Work in Progress". In some ways, something as silly as "Back to the drawing board" would be clearer.

[Martin Pool (mbp)]

Maybe 'withdraw' is clearer than 'cancel'?

--
Martin <http://launchpad.net/~mbp/>

[Jonathan Lange (jml)]

On Mon, Sep 8, 2008 at 11:08 AM, Martin Pool <email address hidden> wrote:
> Maybe 'withdraw' is clearer than 'cancel'?
>

Maybe. I think the confusion isn't so much to do with 'cancel' as it
is to do with 'review request'.

[Aaron Bentley (abentley)]

jml: agreed. Maybe "suspend merge proposal" would have the right flavour.

[Tim Penhey (thumper)]

Fixed in RF 7195.

There isn't a menu any more.