ushare config file identifiers incorrect

[Todd Ross]

Binary package hint: ushare

The default /etc/ushare.conf file ships with incorrectly named identifiers.

# Enable Web interface (yes/no)
ENABLE_WEB=

# Enable Telnet control interface (yes/no)
ENABLE_TELNET=

# Use XboX 360 compatibility mode (yes/no)
ENABLE_XBOX=

# Use DLNA profile (yes/no)
# This is needed for PlayStation3 to work (among other devices)
ENABLE_DLNA=

Should all be prefixed with USHARE_:

# Enable Web interface (yes/no)
USHARE_ENABLE_WEB=

# Enable Telnet control interface (yes/no)
USHARE_ENABLE_TELNET=

# Use XboX 360 compatibility mode (yes/no)
USHARE_ENABLE_XBOX=

# Use DLNA profile (yes/no)
# This is needed for PlayStation3 to work (among other devices)
USHARE_ENABLE_DLNA=

[nullack (nullack)]

Confirmed

[nullack (nullack)]

Ok, I have taken David Browns patch from http://netou.co.uk/ and applied it into a debdiff as per the attachment. This is my first deb diff so I cannot be sure it meets all MOTU requirements. I have however installed the pbuilder deb and confirmed its functionality. The patch fixes:

* This bug
* Another bug with music not working
* Another bug with multiple share directories not working

In terms of the tests I am satisfied with the functionality of the new deb. I note though:

1. Users will have to manually edit the ushare conf to setup the UPNP correctly for PS3, 360 and other UPNP devices etcetc
2. It doesnt automatically start on boot and requires a sudo /etc/init.d/ushare start to kick it off

[Nick Ellery (nick.ellery)]

u-u-s should be subscribed rather than assigned.

[James Westby (james-w)]

Hi nullack,

As we are past feature freeze these changes will need a feature
freeze exception I expect. Please see

  https://wiki.ubuntu.com/FreezeExceptionProcess

for information on how to request one.

Also, please close this bug from the changelog by putting

  (LP: #250122)

in debian/changelog. This will mean that the bug gets
closed automatically when the upload is done.

I'm un-subscribing the sponsors for now. Please re-subscribe
them when ready. I'll remain subscribed in case you have
any questions.

Thanks,

James

[Luca Falavigna (dktrkranz)]

Has this patch been submitted upstream? It could be useful to see upstream's comments.

[nullack (nullack)]

Hi Luca. There is a thread here about the patch and upstream:

http://www.geexbox.org/forum/viewtopic.php?t=9804&highlight=xbox

I no longer use this application due to missing features and lack of upstream development progress.

[Luca Falavigna (dktrkranz)]

We're in FeatureFreeze again, see James' comment, so re-unsubscribing u-u-s for now. If someone is interested, could he please provide some testing results about this?

[oscrp (oscarrb)]

I've been playing with this some hours and after building a new package with nullack's debdiff I've got a rid of all the problems, everything works. Also, I've no problem with running it as a daemon. It starts automatically on boot.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ushare - 1.1a-0ubuntu5

---------------
ushare (1.1a-0ubuntu5) lucid; urgency=low

  * Update copyright dates
  * Change compat to 7
  * Add backport r427 to fix the names in ushare.conf (LP: #250122)
  * Fix script restart (LP: #378788)
  * Fix launching order sequence (LP: #386965)
  * Remove /sbin path in config maintainer script
 -- Alexis Saettler <email address hidden> Sat, 16 Jan 2010 13:36:16 +0100