Please apply skstream-0.3.6-gcc43.patch from Fedora

[Nathan Handler]

Fedora has applied skstream-0.3.6-gcc43.patch. This patch makes skstream work with gcc 4.3. The patch has not yet been applied in Debian/Ubuntu as of version 0.3.6-3.

[Nathan Handler (nhandler)]

skstream (0.3.6-3ubuntu1) intrepid; urgency=low

  * Apply skstream-0.3.6-gcc43.patch from Fedora (LP: #249226)
    - Rebuild for gcc 4.3
  * Bump Standards-Version to 3.8.0
  * Modify Maintainer value to match the DebianMaintainerField
    specification.

 -- Nathan Handler <email address hidden> Wed, 16 Jul 2008 16:22:03 -0500

[Andrea Colangelo (warp10)]

Your debdiff modifies the source code inline. Using a patch (adding a patchsystem if needed) is a better choice.
Please, fix your debdiff, and send the patch to Debian, in case you think it apply there too.

[Nathan Handler (nhandler)]

I was told that when you are only making a small change to the source code, and the package does not have a patch system in place, it is better to simply make the changes inline. If this is not the case, is there any specific patch system that I should add? Or is it my choice?

[Andrea Colangelo (warp10)]

Personally, I prefer to always use a patch system, even for small changes, for many different reasons. In this case, you can apply the patchsystem you like most.

[Nathan Handler (nhandler)]

Well, it took a while, but I think I finally got a dpatch patch system added successfully.

skstream (0.3.6-3ubuntu1) intrepid; urgency=low

  * Add dpatch patch system
    - Add 01_skstream-0.3.6-gcc43.dpatch (LP: #249226)
  * Bump Standards-Version to 3.8.0
    - Add debian/README.source

 -- Nathan Handler <email address hidden> Fri, 25 Jul 2008 21:32:34 -0500

[Nathan Handler (nhandler)]

Here is an updated version of the previous debdiff. This debdiff includes a more complete debian/README.source file.

[Luca Falavigna (dktrkranz)]

I'm able to rebuild it on my pbuilder without any issues, is this really required?
Also, since current .diff.gz already ship inline modifications, I'd suggest to conform to it.

[Nathan Handler (nhandler)]

I just tested the package again Luca. It successfully built in my pbuilder. I am changing the status of this bug to 'Invalid', as the patch is not needed. I also only added a patch system because of Andrea's comment.