FTBFS on sparc, armel, hppa, ia64 due to false positive warning and -Wcast-align

[James Westby]

Binary package hint: packagekit-gnome

Hi,

http://launchpadlibrarian.net/16047515/buildlog_ubuntu-intrepid-sparc.packagekit-gnome_0.2.3-0ubuntu1_FAILEDTOBUILD.txt.gz

Thanks,

James

[Savvas Radevic (medigeek)]

Note: Build logs can be seen at: https://edge.launchpad.net/ubuntu/+source/packagekit-gnome/0.3.13-0ubuntu1

[Savvas Radevic (medigeek)]

Proposed patch (not tested yet)
It is based on a patch for bug #364443
This debdiff includes a patch that strips -Wcast-align

[Savvas Radevic (medigeek)]

I have re-attached the patch (identical to the one above, except without "(testing)" in debian/changelog).

$ apt-cache policy packagekit-gnome
packagekit-gnome:
  Installed: 0.3.13-0ubuntu2
  Candidate: 0.3.13-0ubuntu2
  Version table:
 *** 0.3.13-0ubuntu2 0
        100 /var/lib/dpkg/status
     0.3.13-0ubuntu1 0
        500 http://archive.ubuntu.com jaunty/universe Packages

The patch targets three bugs:
* includes the missing .desktop menu icons (LP: #349572) - icons for .desktop menu items (like Applications > System Tools > Service pack creator) were not included in the package. A total of 4 icons were missing, which are included now as links.
* fix FTBFS for amd64 and i386 by adding a check on which gtk version is used (LP: #364443)
* fix FTBFS of architectures sparc, hppa, armel, ia64 (LP: #249104) (this bug)

http://launchpadlibrarian.net/25848397/buildlog_ubuntu-jaunty-sparc.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz
http://launchpadlibrarian.net/25848884/buildlog_ubuntu-jaunty-armel.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz
http://launchpadlibrarian.net/25848931/buildlog_ubuntu-jaunty-hppa.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz
http://launchpadlibrarian.net/25848362/buildlog_ubuntu-jaunty-ia64.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz

http://launchpadlibrarian.net/25848426/buildlog_ubuntu-jaunty-amd64.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz
http://launchpadlibrarian.net/25848277/buildlog_ubuntu-jaunty-i386.packagekit-gnome_0.3.13-0ubuntu2~ppa1_FULLYBUILT.txt.gz

Sample .deb files at mcasadevall's PPA:
http://ppa.launchpad.net/mcasadevall/ppa/ubuntu/pool/main/p/packagekit-gnome/

Testing of the sparc package in under way.
Packages tested by myself on architectures: i386, amd64

[Savvas Radevic (medigeek)]

Fixed the changelog again:
- Attribution to Michael Bienia who proposed the fix for the 05_fix_set_tooltip_text.patch
- jaunty -> jaunty-proposed

[Devid Antonio Filoni (d.filoni)]

motu-sru ACK. Package uploaded changing the version from 0.3.13-0ubuntu2 to 0.3.13-0ubuntu1.1.

[Jonathan Riddell (jr)]

accepted into jaunty-proposed, please test

[Savvas Radevic (medigeek)]

We might need to use the patch for karmic as well:
https://launchpad.net/ubuntu/+source/packagekit-gnome/2.27.2-0ubuntu2

    * karmic sparc Dependency wait
    * karmic powerpc Failed to build
    * karmic lpia Successfully built (DONE)
    * karmic ia64 Failed to build
    * karmic i386 Successfully built (DONE)
    * karmic armel Failed to build
    * karmic amd64 Successfully built (DONE)

[Savvas Radevic (medigeek)]

> accepted into jaunty-proposed, please test

No FTBFS anymore! :)

[Devid Antonio Filoni (d.filoni)]

@Savvas: please, upload a new patch for karmic, I will upload it.

[Savvas Radevic (medigeek)]

I've created a bug report upstream about -Wcast-align:
http://bugzilla.gnome.org/show_bug.cgi?id=593177

We'll see how it goes. :)

[Savvas Radevic (medigeek)]

There's another FTBFS, but on all archs. bug #419554 :)

I will post a patch *here* (bug #249104) with some (rather minor) package improvements. I'll attach the patch when I test it. (I'll post a comment to the other related bugs as well!)

[Savvas Radevic (medigeek)]

@Devid: Here you go!

Patch for karmic attached: FTBFS fix and packaging improvements

Buildlog: http://launchpadlibrarian.net/30876802/buildlog_ubuntu-karmic-amd64.packagekit-gnome_2.27.2-0ubuntu3%2Bppa1_FULLYBUILT.txt.gz

  * debian/patches/configure.patch:
    + FTBFS on some archs: Disable -Wcast-align. (LP: #249104)
    + FTBFS: Disable GDK_MULTIHEAD_SAFE, as it breaks with new libcanberra-gtk.
      (LP: #419554)
  * debian/packagekit-gnome.install:
    - Use directories, there is no need to name files one by one:
      + debian/tmp/usr/bin/
      + debian/tmp/usr/share/man/
      + debian/tmp/usr/share/locale/
      + debian/tmp/usr/share/applications/
      + debian/tmp/usr/share/gnome-packagekit/
      + debian/tmp/usr/share/icons/hicolor/ (LP: #349572)
    - Sort list
  * debian/copyright: Now dep5-compatible, updated FSF address.
  * debian/control: Removed "edge" from XS-Vcs-Bzr.

[Savvas Radevic (medigeek)]

I've subscribed universe sponsors for karmic patch review. :)

[Devid Antonio Filoni (d.filoni)]

@Savvas: uploaded, thanks :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package packagekit-gnome - 2.27.2-0ubuntu3

---------------
packagekit-gnome (2.27.2-0ubuntu3) karmic; urgency=low

  * debian/patches/configure.patch:
    + FTBFS on some archs: Disable -Wcast-align. (LP: #249104)
    + FTBFS: Disable GDK_MULTIHEAD_SAFE, as it breaks with new libcanberra-gtk.
      (LP: #419554)
  * debian/packagekit-gnome.install:
    - Use directories, there is no need to name files one by one:
      + debian/tmp/usr/bin/
      + debian/tmp/usr/share/man/
      + debian/tmp/usr/share/locale/
      + debian/tmp/usr/share/applications/
      + debian/tmp/usr/share/gnome-packagekit/
      + debian/tmp/usr/share/icons/hicolor/ (LP: #349572)
    - Sort list
  * debian/copyright: Now dep5-compatible, updated FSF address.
  * debian/control: Removed "edge" from XS-Vcs-Bzr.

 -- Savvas Radevic <email address hidden> Wed, 26 Aug 2009 21:27:12 +0200

[Artur Rona (ari-tczew)]

Product: gnome-packagekit
Component: general
Version: git master
Status: RESOLVED
Resolution: FIXED
Priority: Normal
Severity: major

[Martin Pitt (pitti)]

Anyone who could test that the jaunty-proposed package still works?

[Artur Rona (ari-tczew)]

Builds
    * jaunty sparc Successfully built (DONE)
    * jaunty powerpc Successfully built (DONE)
    * jaunty lpia Successfully built (DONE)
    * jaunty ia64 Successfully built (DONE)
    * jaunty i386 Successfully built (DONE)
    * jaunty hppa Successfully built (DONE)
    * jaunty armel Successfully built (DONE)
    * jaunty amd64 Successfully built (DONE)

+1 from me for release package from proposed, comparing:
https://launchpad.net/ubuntu/+source/packagekit-gnome/0.3.13-0ubuntu1
https://launchpad.net/ubuntu/+source/packagekit-gnome/0.3.13-0ubuntu1.1
it works

[Launchpad Janitor (janitor)]

This bug was fixed in the package packagekit-gnome - 0.3.13-0ubuntu1.1

---------------
packagekit-gnome (0.3.13-0ubuntu1.1) jaunty-proposed; urgency=low

  * 05_fix_set_tooltip_text.patch: Fixes FTBFS on i386 and amd64
    Check GTK version, use gtk_status_icon_set_tooltip_text or
    gtk_status_icon_set_tooltip where applicable.
    Thanks to Michael Bienia (LP: #364443)
  * packagekit-gnome.install: Include usr/share/icons/hicolor (LP: #349572)
  * 10_configure_no_Wcast-align.patch: remove -Wcast-align from configure
    (LP: #249104)

 -- Savvas Radevic <email address hidden> Mon, 20 Apr 2009 19:28:06 +0000