Duplicate file entries after double-clicking path button in file dialog

[Diaa Sami]

Ubuntu hardy heron final with KDE3 installed
libgtk2.0-0: 2.12.9-3ubuntu4
kdesktop: 4:3.5.9-0ubuntu7.2

Step to reproduce the bug:
In KDE, Open the file dialog in any GTK application(say gedit), regardless of the location in the file system, double-click on the last button in the path bar which should represent the current folder .

What was expected:
Either nothing should happen or the contents of the current folder should be refreshed.

What happened instead:
Each item in the current folder is listed twice.

I was able to reproduce the bug consistently on 2 machines, I tried the same sequence in gnome but it works properly.

[Sebastien Bacher (seb128)]

thank you for your bug report, not confirming on my hardy installation, do you have the issue when using GNOME?

[Diaa Sami (diaa.sami)]

I mentioned this already, I couldn't reproduce the bug when using GNOME.

[Sebastien Bacher (seb128)]

likely another qt gtk engine bug

[Jonathan Thomas (echidnaman)]

I can reproduce this in the kde4 version of gtk-qt-engine as well.

[Diaa Sami (diaa.sami)]

I noticed that on my other machine(a laptop) where the bug is reproducible, gtk-qt-engine is not installed so it may not be a gtk-qt-engine bug, please see the image attached

[adw (adw)]

I am seeing this in Gnome/XFCE. I am running Hardy, and my install started out as Xubuntu Feisty.

I don't have gtk-qt-engine installed.

[Jonathan Thomas (echidnaman)]

Ok then probably not a gtk-qt-engine bug. But since I don't know which package would be appropriate, I'll just invalid the gtk-qt-engine-kde4 one so that this bug doesn't disappear.

[adw (adw)]

This always happens for me when I have the 'Location' entry box on.
It never happens when I have it off.
In Diaa Sami's screenshot I also see that it is on.

Can anyone confirm this behaviour?

[Sebastien Bacher (seb128)]

could you describe how to trigger the issue on a new ubuntu installation? are you sure that's a gtk bug?

[adw (adw)]

It's the GTK file chooser isn't it?

I don't have a clean installation to test on, but try this:
1. Open a GTK 'Open file' dialog.
2. Enable the location field (button in top-left of dialog, or Ctrl+L).
3. Double click one of the path component buttons.

[adw (adw)]

Actually, the duplicate says this is probably a bug in libgnomeui. Feel free to move if you think that's better (because I don't really know what I'm doing ;).

[Sebastien Bacher (seb128)]

could you run "dpkg -l | grep gtk" and attach the information to a comment?

[Sebastien Bacher (seb128)]

rather "dpkg -l | grep engines"

[adw (adw)]

$ dpkg -l|grep engines
ii gtk2-engines 1:2.14.1-0ubuntu1 theme engines for GTK+ 2.x
ii gtk2-engines-pixbuf 2.12.9-3ubuntu4 Pixbuf-based theme for GTK+ 2.x

[Sebastien Bacher (seb128)]

no idea about the issue but it's likely something specific to your configuration, to debug by somebody having the issue, you can try using a new user on the same installation and see if you still get the issue, could be some user configuration

[adw (adw)]

I created a new user, but it has the same problem.

Also, it doesn't just happen if I double click the buttons. If I get focus on one and press Enter twice within about 2 seconds, the same thing happens.

[adw (adw)]

I have analyzed and solved the problem I was seeing.

Let's look at gtk+2.0-2.12.9/gtk/gtkfilesystemmodel.c.
In the callback function got_root_folder_cb, there is this code:

 if (gtk_file_folder_is_finished_loading (model->root_folder))
   g_signal_emit (model, file_system_model_signals[FINISHED_LOADING], 0);
 else
   g_signal_connect_object (model->root_folder, "finished-loading",
       G_CALLBACK (root_folder_finished_loading_cb), model, 0);

Basically, this means: if the folder is already loaded, tell the dialog we're done, otherwise wait for the folder to load (and then tell the dialog).
The function then goes on to populate the model with the files in the folder:

 gtk_file_folder_list_children (model->root_folder, &roots, NULL);
 ...
 for (tmp_list = roots; tmp_list; tmp_list = tmp_list->next) { ... }

This is where things go wrong; it seems that this loop isn't necessary at all. The model is already populated in do_files_added.
If the folder hasn't been loaded yet, this doesn't even do anything because gtk_file_folder_list_children will return an empty list. But if the folder IS already loaded, then this loop will add all files a second time!

However, there is another question: Why does the above call to gtk_file_folder_is_finished_loading only return true on the second path bar click? In other words, why isn't the 'loaded' status reset before the second click?
Well, there is some sort of caching going on, for a duration of FOLDER_CACHE_LIFETIME. And guess what, it's exactly 2 seconds.

So, how do we solve the problem? Simply remove the superfluous loop mentioned above. Of course this might have nasty side effects, so someone who's familiar with gtk's internals should have a look at what's going on here.
Now another issue crops up. The selection doesn't show up after the second click. Maybe someone else can figure that one out.

[Sebastien Bacher (seb128)]

could you open the bug on bugzilla.gnome.org and attach your change there for comments? there is no gtk upstream hackers in the ubuntu team so it would be better to use the gnome bugzilla there

[adw (adw)]

Argh, it seems that the loop is already gone in SVN (since r20342: 2008-06-10 Carlos Garnacho <email address hidden>, Bug 520874 - Should use gio directly).

I can't get it to compile unfortunately, but I assume it's fixed.

[Sebastien Bacher (seb128)]

closing the bug then since the new version is already in intrepid