Send::Email doesn't finish SMTP transaction properly

[Tomasz Chomiuk]

Binary package hint: libemail-send-perl

hi, it looks like Send::Email forgets sending QUIT command after sending emails... in result there's many timeout connection log entries in mail.info

May 9 12:37:11 hostname postfix/smtpd[9395]: timeout after END-OF-MESSAGE from hostname[127.0.1.1]
May 9 12:37:11 hostname postfix/smtpd[9395]: disconnect from hostname[127.0.1.1]

thanks

[petski (petski)]

Please take a look at http://search.cpan.org/~rjbs/Email-Send-2.193/lib/Email/Send.pm#WAIT!_ACHTUNG!

[petski (petski)]

I suspect you're using "mailer => SMTP".

I just looked at the source code for Email::Send::SMTP, and noticed that "QUIT" is only called in two scenario's:

1) The Email::Send object get's out of scope
2) send() is called for the second time (which seems weird).

A workaround could be:

1) Make sure your Email::Send object get's out of scope sooner (using "if(1)" or "curly brackets"), like this:

=begin of code example=

# some code here
if(1) {
 my $sender = Email::Send->new({mailer => 'SMTP'});
 $sender->mailer_args([Host => 'smtp.example.com']);
 $sender->send($message);
}
# rest of code

=end of code example=

2) Use "mailer => Sendmail" instead

[Tomasz Chomiuk (t-chomiuk)]

thanks mate.. actually I've been using 'mailer => sendmail' for a
quite some time now since it makes more sense due to tsl/sasl setup.
think i should try e::sender some time soon.. please do keep up the
excellent work!

2008/12/30 petski <email address hidden>:
> I suspect you're using "mailer => SMTP".
>
> I just looked at the source code for Email::Send::SMTP, and noticed that
> "QUIT" is only called in two scenario's:
>
> 1) The Email::Send object get's out of scope
> 2) send() is called for the second time (which seems weird).
>
> A workaround could be:
>
> 1) Make sure your Email::Send object get's out of scope sooner (using
> "if(1)" or "curly brackets"), like this:
>
> =begin of code example=
>
> # some code here
> if(1) {
> my $sender = Email::Send->new({mailer => 'SMTP'});
> $sender->mailer_args([Host => 'smtp.example.com']);
> $sender->send($message);
> }
> # rest of code
>
> =end of code example=
>
> 2) Use "mailer => Sendmail" instead
>
> --
> Send::Email doesn't finish SMTP transaction properly
> https://bugs.launchpad.net/bugs/228679
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[petski (petski)]

No problem Tomasz.

Just to get things clear, could you please answer these two questions:

1) At the time you created this bug, you were using "mailer => SMTP"? If not, what did you use?

2) The script you used at that time had it's layout like this:

=begin of example=

# some code here
my $sender = Email::Send->new({mailer => 'SMTP'});
$sender->mailer_args([Host=> 'smtp.example.com']);
$sender->send($message);
# some other code that could take more than a couple of seconds
# etc etc

=end of example=

[Tomasz Chomiuk (t-chomiuk)]

question 1 - yes.

question 2 - normally the remaining code doesn't take that long to
finish, but now when u mentioned it I remember I had problems where a
child process (where the script is being run from) wouldn't exit
properly continuing to execute parent code. in that case the answer is
yes... however I use Email::Send throughout my app many times and not
all of the calls have got the same run scenario thus I don't know if
that one was the only one which caused the problems.

2008/12/31 petski <email address hidden>:
> No problem Tomasz.
>
> Just to get things clear, could you please answer these two questions:
>
> 1) At the time you created this bug, you were using "mailer => SMTP"? If
> not, what did you use?
>
> 2) The script you used at that time had it's layout like this:
>
> =begin of example=
>
> # some code here
> my $sender = Email::Send->new({mailer => 'SMTP'});
> $sender->mailer_args([Host=> 'smtp.example.com']);
> $sender->send($message);
> # some other code that could take more than a couple of seconds
> # etc etc
>
> =end of example=
>
> --
> Send::Email doesn't finish SMTP transaction properly
> https://bugs.launchpad.net/bugs/228679
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[petski (petski)]

Notified upstream at http://rt.cpan.org/Public/Bug/Display.html?id=42098

[petski (petski)]

Upstream has fixed this bug in a new release (version 2.194). Debdiff is attached.

I've also build the package for Intrepid in my PPA: https://launchpad.net/~petski/+archive

[Steve Stalcup (vorian)]

Great work so far!

Can you also take care of these:

W: libemail-send-perl source: out-of-date-standards-version 3.7.3 (current is 3.8.0)
W: libemail-send-perl source: versioned-dependency-satisfied-by-perl build-depends-indep: libmodule-pluggable-perl (>= 2.97)
E: libemail-send-perl source: build-depends-on-obsolete-package build-depends-indep: libmime-perl
Finished running lintian.

I'm unsubscribing u-u-s, please resubscribe universe sponsors when complete

Thanks!

[petski (petski)]

That's weird. When I ran lintian, the only output I got was the out-of-date-standards-version-3.7.3 warning. Are you sure it wasn't a patch problem?

I've used Launchpad's PPA to build an intrepid and a jaunty version for libemail-send-perl. I bumped to Standards-Version 3.8.0. Lintian is "clean" now.

pet@workmate:~/work$ lintian -i libemail-send-perl_2.194-0ubuntu1~ppa2+intrepid.dsc
pet@workmate:~/work$ lintian -i libemail-send-perl_2.194-0ubuntu1~ppa2+jaunty.dsc

Buildlogs can be found at https://launchpad.net/~petski/+archive

Debdiff for jaunty is attached.

[Steve Stalcup (vorian)]

uploaded.

Thanks for your contribution to Ubuntu. Please forward this change to Debian.